From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A4CC433FE for ; Mon, 20 Sep 2021 07:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD10C610A3 for ; Mon, 20 Sep 2021 07:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234778AbhITHYO (ORCPT ); Mon, 20 Sep 2021 03:24:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbhITHYN (ORCPT ); Mon, 20 Sep 2021 03:24:13 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7E16C061574; Mon, 20 Sep 2021 00:22:46 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1mSDdM-0005la-RP; Mon, 20 Sep 2021 09:22:36 +0200 Date: Mon, 20 Sep 2021 09:22:36 +0200 From: Florian Westphal To: Cole Dishington Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, shuah@kernel.org, linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, Anthony Lineham , Scott Parlane , Blair Steven Subject: Re: [PATCH net v5 1/2] net: netfilter: Limit the number of ftp helper port attempts Message-ID: <20210920072236.GH15906@breakpoint.cc> References: <20210920005905.9583-1-Cole.Dishington@alliedtelesis.co.nz> <20210920005905.9583-2-Cole.Dishington@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920005905.9583-2-Cole.Dishington@alliedtelesis.co.nz> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Cole Dishington wrote: > In preparation of fixing the port selection of ftp helper when using > NF_NAT_RANGE_PROTO_SPECIFIED, limit the number of ftp helper port > attempts to 128. > > Looping a large port range takes too long. Instead select a random > offset within [ntohs(exp->saved_proto.tcp.port), 65535] and try 128 > ports. LGTM, please fix the format argument error the kbuild robot reported and resend. You may add Acked-by: Florian Westphal when doing so.