From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: dsterba@suse.cz,
"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix initialiser warning in fs/btrfs/tree-checker.c
Date: Mon, 20 Sep 2021 10:31:25 +0200 [thread overview]
Message-ID: <20210920083125.GZ9286@twin.jikos.cz> (raw)
In-Reply-To: <7be281ea-1811-0ffe-0c78-c7491cafc3a6@suse.com>
On Mon, Sep 20, 2021 at 04:25:24PM +0800, Qu Wenruo wrote:
> > Kees Cook does a tree wide unification to { } because there are some
> > oddities with partial initialization and { 0 } so this will get fixed
> > eventually.
>
> Does this mean in the future only "= { }" is preferred?
Yes,
https://lore.kernel.org/all/20210910225207.3272766-1-keescook@chromium.org/
> It would looks a little weird to me as C89/C90 doesn't allow this.
>
> And I guess checkpatch would also be updated to handle that?
I think so but we can always override what checkpatch suggests.
prev parent reply other threads:[~2021-09-20 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 22:40 [PATCH] btrfs: fix initialiser warning in fs/btrfs/tree-checker.c Russell King (Oracle)
2021-09-19 22:44 ` Qu Wenruo
2021-09-19 22:46 ` Russell King (Oracle)
2021-09-19 22:50 ` Russell King (Oracle)
2021-09-19 22:57 ` Qu Wenruo
2021-09-20 8:12 ` David Sterba
2021-09-20 8:25 ` Qu Wenruo
2021-09-20 8:31 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920083125.GZ9286@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.