From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 747E5C433F5 for ; Mon, 20 Sep 2021 10:03:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FF9F60F5D for ; Mon, 20 Sep 2021 10:03:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234771AbhITKEe (ORCPT ); Mon, 20 Sep 2021 06:04:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:44430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234235AbhITKEc (ORCPT ); Mon, 20 Sep 2021 06:04:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D5EE60F21; Mon, 20 Sep 2021 10:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632132185; bh=9+DI7f38UVFXr+/Nh52c4dX/l/6rhwYCtppf9KioJ3k=; h=From:To:Cc:Subject:Date:From; b=M7e4wSfb0aQ3wRh5TZOnxxadO7wYdZcl9B/Vt0S8I1ZK+f9nbIYLMry6anWxnCYwq stA/LsrjKAIGIorakuN6xvTlFZW61OSYkkaRzuGN55gZDpixU17dhnAdADoG2GNsgv SLUvb0WeSfCiwbcXfTC/1TpkPOlN8D6u+vX9be4s7JFB3J7SFAqDdnnmW7cRYqAN8y xbJhFIpN49JgaAskc7b3GAREHFy9ooR8lpBmJ/7+vF05J1d5UAxP4xcFznLbPXg/sZ Qpbv6GwCKNA3rh4hiUjHnQI4kYz4LXiXQeaXbzVDg6LIGya3ABCEwsjoxH6x8PudDh N9eZ05jE8LlUA== From: Arnd Bergmann To: Sudeep Holla , Cristian Marussi , Igor Skalkin , Peter Hilber Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] firmware: arm_scmi: fix VIRTIO dependency Date: Mon, 20 Sep 2021 12:02:51 +0200 Message-Id: <20210920100301.1466486-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Building with CONFIG_VIRTIO=m but CONFIG_ARM_SCMI_PROTOCOL=y leads to a link error for the scmi virtio transport: arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_send_message': virtio.c:(.text+0x200): undefined reference to `virtqueue_add_sgs' arm-linux-gnueabi-ld: virtio.c:(.text+0x280): undefined reference to `virtqueue_kick' arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `scmi_vio_feed_vq_rx': virtio.c:(.text+0x390): undefined reference to `virtqueue_add_inbuf' arm-linux-gnueabi-ld: virtio.c:(.text+0x3dc): undefined reference to `virtqueue_kick' arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_scmi_exit': virtio.c:(.text+0x538): undefined reference to `unregister_virtio_driver' arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_chan_available': Prevent this configuration by making the Kconfig dependency a bit stricter. Fixes: 46abe13b5e3d ("firmware: arm_scmi: Add virtio transport") Signed-off-by: Arnd Bergmann --- drivers/firmware/arm_scmi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig index 7f4d2435503b..3d7081e84853 100644 --- a/drivers/firmware/arm_scmi/Kconfig +++ b/drivers/firmware/arm_scmi/Kconfig @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC config ARM_SCMI_TRANSPORT_VIRTIO bool "SCMI transport based on VirtIO" - depends on VIRTIO + depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL select ARM_SCMI_HAVE_TRANSPORT select ARM_SCMI_HAVE_MSG help -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42BE0C433EF for ; Mon, 20 Sep 2021 10:04:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09BFC60F9B for ; Mon, 20 Sep 2021 10:04:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 09BFC60F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=8s0oIOJwevJacB6mn3l4Nx9YUTeP+Sv7PpFV62IxW/k=; b=XihXdgaGK1q1zJ xowFa/U7Gxln71/nd5VQZHLS9GmP/jc2O0a3Geh+kFv9KVUlC3wgxkKs5NwoCwATR+RHOeaFxm9ry huYqQ41fo93B4s7S0C8dk3dTWoDI57f0/tBt8iwiJo/cAU9Jn4O8Sy99uRcKejRBnmjG20UskakCd bLLciS5bcHqk/Y4AwbiDcDinXR0CoX5mvhBfQakfxeoQZBTvphGOrxBJluBfnR8cUqsc5JuJLALmz MnZG1prg73Q0vfCkng+Vws8/UGQtrNshOn/sUD1CrPcjDKa6mxG6AIBZDcraV9HGC6A43huC6Nz+z ob8r7FGLjzdfuJzK1yQQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSG8k-001D4w-59; Mon, 20 Sep 2021 10:03:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSG8g-001D40-0z for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 10:03:07 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D5EE60F21; Mon, 20 Sep 2021 10:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632132185; bh=9+DI7f38UVFXr+/Nh52c4dX/l/6rhwYCtppf9KioJ3k=; h=From:To:Cc:Subject:Date:From; b=M7e4wSfb0aQ3wRh5TZOnxxadO7wYdZcl9B/Vt0S8I1ZK+f9nbIYLMry6anWxnCYwq stA/LsrjKAIGIorakuN6xvTlFZW61OSYkkaRzuGN55gZDpixU17dhnAdADoG2GNsgv SLUvb0WeSfCiwbcXfTC/1TpkPOlN8D6u+vX9be4s7JFB3J7SFAqDdnnmW7cRYqAN8y xbJhFIpN49JgaAskc7b3GAREHFy9ooR8lpBmJ/7+vF05J1d5UAxP4xcFznLbPXg/sZ Qpbv6GwCKNA3rh4hiUjHnQI4kYz4LXiXQeaXbzVDg6LIGya3ABCEwsjoxH6x8PudDh N9eZ05jE8LlUA== From: Arnd Bergmann To: Sudeep Holla , Cristian Marussi , Igor Skalkin , Peter Hilber Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] firmware: arm_scmi: fix VIRTIO dependency Date: Mon, 20 Sep 2021 12:02:51 +0200 Message-Id: <20210920100301.1466486-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_030306_166962_0EDF60FC X-CRM114-Status: GOOD ( 11.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann Building with CONFIG_VIRTIO=m but CONFIG_ARM_SCMI_PROTOCOL=y leads to a link error for the scmi virtio transport: arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_send_message': virtio.c:(.text+0x200): undefined reference to `virtqueue_add_sgs' arm-linux-gnueabi-ld: virtio.c:(.text+0x280): undefined reference to `virtqueue_kick' arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `scmi_vio_feed_vq_rx': virtio.c:(.text+0x390): undefined reference to `virtqueue_add_inbuf' arm-linux-gnueabi-ld: virtio.c:(.text+0x3dc): undefined reference to `virtqueue_kick' arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_scmi_exit': virtio.c:(.text+0x538): undefined reference to `unregister_virtio_driver' arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_chan_available': Prevent this configuration by making the Kconfig dependency a bit stricter. Fixes: 46abe13b5e3d ("firmware: arm_scmi: Add virtio transport") Signed-off-by: Arnd Bergmann --- drivers/firmware/arm_scmi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig index 7f4d2435503b..3d7081e84853 100644 --- a/drivers/firmware/arm_scmi/Kconfig +++ b/drivers/firmware/arm_scmi/Kconfig @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC config ARM_SCMI_TRANSPORT_VIRTIO bool "SCMI transport based on VirtIO" - depends on VIRTIO + depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL select ARM_SCMI_HAVE_TRANSPORT select ARM_SCMI_HAVE_MSG help -- 2.29.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel