From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980C1C433EF for ; Mon, 20 Sep 2021 10:48:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E9026109E for ; Mon, 20 Sep 2021 10:48:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233610AbhITKuB (ORCPT ); Mon, 20 Sep 2021 06:50:01 -0400 Received: from foss.arm.com ([217.140.110.172]:45684 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231686AbhITKtx (ORCPT ); Mon, 20 Sep 2021 06:49:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 063B51063; Mon, 20 Sep 2021 03:48:27 -0700 (PDT) Received: from bogus (unknown [10.57.23.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4101F3F719; Mon, 20 Sep 2021 03:48:25 -0700 (PDT) Date: Mon, 20 Sep 2021 11:48:06 +0100 From: Sudeep Holla To: Arnd Bergmann Cc: Cristian Marussi , Igor Skalkin , Peter Hilber , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] firmware: arm_scmi: fix VIRTIO dependency Message-ID: <20210920104806.bi4gky3y6w5h2rur@bogus> References: <20210920100301.1466486-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920100301.1466486-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 12:02:51PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with CONFIG_VIRTIO=m but CONFIG_ARM_SCMI_PROTOCOL=y leads to > a link error for the scmi virtio transport: > > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_send_message': > virtio.c:(.text+0x200): undefined reference to `virtqueue_add_sgs' > arm-linux-gnueabi-ld: virtio.c:(.text+0x280): undefined reference to `virtqueue_kick' > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `scmi_vio_feed_vq_rx': > virtio.c:(.text+0x390): undefined reference to `virtqueue_add_inbuf' > arm-linux-gnueabi-ld: virtio.c:(.text+0x3dc): undefined reference to `virtqueue_kick' > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_scmi_exit': > virtio.c:(.text+0x538): undefined reference to `unregister_virtio_driver' > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_chan_available': > > Prevent this configuration by making the Kconfig dependency a bit > stricter. > > Fixes: 46abe13b5e3d ("firmware: arm_scmi: Add virtio transport") > Signed-off-by: Arnd Bergmann > --- > drivers/firmware/arm_scmi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Hi Arnd, I have already queued similar fix by Cristain[1] a while ago. I was waiting to get other possible fixes sorted before sending pull request. Sorry for that, will do that soon. -- Regards, Sudeep [1] https://lore.kernel.org/all/20210816141609.41751-1-cristian.marussi@arm.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4462DC433F5 for ; Mon, 20 Sep 2021 10:50:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 14B0D6109E for ; Mon, 20 Sep 2021 10:50:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14B0D6109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9nQM0T33TgovOmo3iZX1AB+K+zuLjTZVwA4s5MeDTw0=; b=k3ycoBQuZnTKWS t8puMJFf1RtxkF7KUPodqe3aiRGiTM2U/jXRPth5oPY0K2CwQBidQ7d8xYr+YtF/kP0lHhkgyNbhd DzcokdCF1idDBmhh3HxgiQteL0Fm7BuvH6Ty9Ow6eDi9J9R2kWBNpY3Z80/T+kpSV3wUmrSvVqwlo 546ek4Lo9r7T6lK9VJ3jXvv7nlaHsVtHAxdmBfqCVnaOf8eH2BwW/Ghk0DS7qhcVC6W+m7E5SwvzR ske9vfrStezi52TD5xGVV3htyq0bDduQJ3eqmpJ5HNMeXU5m8/DSaqJpIWKhdljGau7AMHXyIfbhy ++3xCRt+y57PwfqUECAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSGqi-001J66-50; Mon, 20 Sep 2021 10:48:36 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSGqe-001J5Q-Qf for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 10:48:34 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 063B51063; Mon, 20 Sep 2021 03:48:27 -0700 (PDT) Received: from bogus (unknown [10.57.23.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4101F3F719; Mon, 20 Sep 2021 03:48:25 -0700 (PDT) Date: Mon, 20 Sep 2021 11:48:06 +0100 From: Sudeep Holla To: Arnd Bergmann Cc: Cristian Marussi , Igor Skalkin , Peter Hilber , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] firmware: arm_scmi: fix VIRTIO dependency Message-ID: <20210920104806.bi4gky3y6w5h2rur@bogus> References: <20210920100301.1466486-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210920100301.1466486-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_034832_951410_AA40E2F3 X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 20, 2021 at 12:02:51PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Building with CONFIG_VIRTIO=m but CONFIG_ARM_SCMI_PROTOCOL=y leads to > a link error for the scmi virtio transport: > > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_send_message': > virtio.c:(.text+0x200): undefined reference to `virtqueue_add_sgs' > arm-linux-gnueabi-ld: virtio.c:(.text+0x280): undefined reference to `virtqueue_kick' > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `scmi_vio_feed_vq_rx': > virtio.c:(.text+0x390): undefined reference to `virtqueue_add_inbuf' > arm-linux-gnueabi-ld: virtio.c:(.text+0x3dc): undefined reference to `virtqueue_kick' > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_scmi_exit': > virtio.c:(.text+0x538): undefined reference to `unregister_virtio_driver' > arm-linux-gnueabi-ld: drivers/firmware/arm_scmi/virtio.o: in function `virtio_chan_available': > > Prevent this configuration by making the Kconfig dependency a bit > stricter. > > Fixes: 46abe13b5e3d ("firmware: arm_scmi: Add virtio transport") > Signed-off-by: Arnd Bergmann > --- > drivers/firmware/arm_scmi/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Hi Arnd, I have already queued similar fix by Cristain[1] a while ago. I was waiting to get other possible fixes sorted before sending pull request. Sorry for that, will do that soon. -- Regards, Sudeep [1] https://lore.kernel.org/all/20210816141609.41751-1-cristian.marussi@arm.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel