All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Benjamin Berg <bberg@redhat.com>,
	Ulrich Huber <ulrich@huberulrich.de>,
	linux-usb@vger.kernel.org
Subject: [PATCH 4/7] usb: typec: ucsi: acpi: Reduce the command completion timeout
Date: Mon, 20 Sep 2021 17:24:16 +0300	[thread overview]
Message-ID: <20210920142419.54493-5-heikki.krogerus@linux.intel.com> (raw)
In-Reply-To: <20210920142419.54493-1-heikki.krogerus@linux.intel.com>

The huge delay was there to workaround a problem where the
firmware did not report that it was busy with the alternate
mode commands. Now that the alternate modes are polled, the
delay can be dropped.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/usb/typec/ucsi/ucsi_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/ucsi/ucsi_acpi.c b/drivers/usb/typec/ucsi/ucsi_acpi.c
index 04976435ad736..6771f05e32c29 100644
--- a/drivers/usb/typec/ucsi/ucsi_acpi.c
+++ b/drivers/usb/typec/ucsi/ucsi_acpi.c
@@ -78,7 +78,7 @@ static int ucsi_acpi_sync_write(struct ucsi *ucsi, unsigned int offset,
 	if (ret)
 		goto out_clear_bit;
 
-	if (!wait_for_completion_timeout(&ua->complete, 60 * HZ))
+	if (!wait_for_completion_timeout(&ua->complete, HZ))
 		ret = -ETIMEDOUT;
 
 out_clear_bit:
-- 
2.33.0


  parent reply	other threads:[~2021-09-20 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 14:24 [PATCH 0/7] usb: typec: ucsi: Driver improvements Heikki Krogerus
2021-09-20 14:24 ` [PATCH 1/7] usb: typec: ucsi: Always cancel the command if PPM reports BUSY condition Heikki Krogerus
2021-09-20 14:24 ` [PATCH 2/7] usb: typec: ucsi: Don't stop alt mode registration on busy condition Heikki Krogerus
2021-09-20 14:24 ` [PATCH 3/7] usb: typec: ucsi: Add polling mechanism for partner tasks like alt mode checking Heikki Krogerus
2021-09-20 14:24 ` Heikki Krogerus [this message]
2021-09-20 14:24 ` [PATCH 5/7] usb: typec: ucsi: Check the partner alt modes always if there is PD contract Heikki Krogerus
2021-09-20 14:24 ` [PATCH 6/7] usb: typec: ucsi: Read the PDOs in separate work Heikki Krogerus
2021-09-20 14:24 ` [PATCH 7/7] usb: typec: ucsi: Better fix for missing unplug events issue Heikki Krogerus
2021-09-23 14:38 ` [PATCH 0/7] usb: typec: ucsi: Driver improvements Benjamin Berg
2021-09-23 16:06   ` Ulrich Huber
2021-09-24 13:55     ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920142419.54493-5-heikki.krogerus@linux.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=bberg@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ulrich@huberulrich.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.