[PATCH] staging: vt6656: Fix warning message generated by checkpatch.pl

[PATCH] staging: vt6656: Fix warning message generated by checkpatch.pl

[Joshua de Block]

Description: Address the following checkpatch warning:
   * WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Joshua de Block <deblockj0482@gmail.com>
---
 drivers/staging/vt6656/rxtx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index a31947f2620d..b129397ef41f 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -58,7 +58,6 @@ static struct vnt_usb_send_context
 	struct vnt_usb_send_context *context = NULL;
 	int ii;
 
-	dev_dbg(&priv->usb->dev, "%s\n", __func__);
 
 	for (ii = 0; ii < priv->num_tx_context; ii++) {
 		if (!priv->tx_context[ii])
-- 
2.30.2

Re: [PATCH] staging: vt6656: Fix warning message generated by checkpatch.pl

[Dan Carpenter]

On Wed, Sep 15, 2021 at 01:57:39PM -0500, Joshua de Block wrote:
> Description: Address the following checkpatch warning:
>    * WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> 
> Signed-off-by: Joshua de Block <deblockj0482@gmail.com>
> ---
>  drivers/staging/vt6656/rxtx.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index a31947f2620d..b129397ef41f 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -58,7 +58,6 @@ static struct vnt_usb_send_context
>  	struct vnt_usb_send_context *context = NULL;
>  	int ii;
>  
> -	dev_dbg(&priv->usb->dev, "%s\n", __func__);
>  

Delete the next blank line as well.  Otherwise it introduces a new
checkpatch warning.

>  	for (ii = 0; ii < priv->num_tx_context; ii++) {
>  		if (!priv->tx_context[ii])

regards,
dan carpenter

[PATCH v2] staging: vt6656: Fix warning message generated by checkpatch.pl

[Joshua de Block]

Description: Address the following checkpatch warning:
   * WARNING: Unnecessary ftrace-like logging - prefer using ftrace

Signed-off-by: Joshua de Block <deblockj0482@gmail.com>
---
 drivers/staging/vt6656/rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index a31947f2620d..5839b34b2e93 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -58,8 +58,6 @@ static struct vnt_usb_send_context
 	struct vnt_usb_send_context *context = NULL;
 	int ii;
 
-	dev_dbg(&priv->usb->dev, "%s\n", __func__);
-
 	for (ii = 0; ii < priv->num_tx_context; ii++) {
 		if (!priv->tx_context[ii])
 			return NULL;
-- 
2.30.2

Hi Dan, 

Thanks for catching that. I've modified my commit. 

Joshua

Re: [PATCH v2] staging: vt6656: Fix warning message generated by checkpatch.pl

[Greg KH]

On Mon, Sep 20, 2021 at 09:31:08AM -0500, Joshua de Block wrote:
> Description: Address the following checkpatch warning:
>    * WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> 
> Signed-off-by: Joshua de Block <deblockj0482@gmail.com>
> ---
>  drivers/staging/vt6656/rxtx.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index a31947f2620d..5839b34b2e93 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -58,8 +58,6 @@ static struct vnt_usb_send_context
>  	struct vnt_usb_send_context *context = NULL;
>  	int ii;
>  
> -	dev_dbg(&priv->usb->dev, "%s\n", __func__);
> -
>  	for (ii = 0; ii < priv->num_tx_context; ii++) {
>  		if (!priv->tx_context[ii])
>  			return NULL;
> -- 
> 2.30.2
> 
> Hi Dan, 
> 
> Thanks for catching that. I've modified my commit. 
> 
> Joshua
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/SubmittingPatches for what needs to be done
  here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot