[PATCH v2 0/6] Input: goodix - Add support for controllers without flash

From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Bastien Nocera <hadess@hadess.net>,
	linux-input@vger.kernel.org
Subject: [PATCH v2 0/6] Input: goodix - Add support for controllers without flash
Date: Mon, 20 Sep 2021 17:06:37 +0200	[thread overview]
Message-ID: <20210920150643.155872-1-hdegoede@redhat.com> (raw)

Hi All,

Here is v2 of my patch-set to add support for Goodix controllers
without flash-memory.

Changes in v2:
- Decide if a controller does not have flash / needs firmware to be
  uploaded based on the presence of the "firmware-name" device-property,
  the autodetection code in v1 was causing false-positives on some
  devices

Original cover-letter:

A while ago I bought a Glavey TM800A550L tablet. This is a Bay Trail (x86)
tablet which comes with Android from the factory.

It is mostly just another Bay Trail tablet, but the way the Goodix
touchscreen on it works is interesting. The controller needs to have
firmware uploaded to it before it will work. After that it pretty much
works 100% the same as any other Goodix touchscreen controller.

I've described this patch-set in the Subject as "Add support for
controllers without flash", but I suspect that the Goodix controllers
used on Bay Trail devices which ship with Windows pre-installed may also
lack flash; and that the Windows version of the BIOS-es on these devices
does the upload for us. Anyways just something which I'm wondering about,
these patches are necessary to make things work regardless.

These patches should also be useful for supporting the Goodix controllers
on some ARM based devices, as some of those need the OS to upload the
firmware too AFAIK.

Regards,

Hans

Hans de Goede (6):
  Input: goodix - Change goodix_i2c_write() len parameter type to int
  Input: goodix - Add a goodix.h header file
  Input: goodix - Refactor reset handling
  Input: goodix - Push error logging up into i2c_read and i2c_write
    helpers
  Input: goodix - Allow specifying the config filename through a
    "goodix,config-name" device-property
  Input: goodix - Add support for controllers without flash

 MAINTAINERS                                 |   3 +-
 drivers/input/touchscreen/Makefile          |   3 +-
 drivers/input/touchscreen/goodix.c          | 240 +++++-------
 drivers/input/touchscreen/goodix.h          | 117 ++++++
 drivers/input/touchscreen/goodix_fwupload.c | 413 ++++++++++++++++++++
 5 files changed, 639 insertions(+), 137 deletions(-)
 create mode 100644 drivers/input/touchscreen/goodix.h
 create mode 100644 drivers/input/touchscreen/goodix_fwupload.c

-- 
2.31.1