From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9110C433EF for ; Mon, 20 Sep 2021 15:19:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83F28610F9 for ; Mon, 20 Sep 2021 15:19:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241407AbhITPUw (ORCPT ); Mon, 20 Sep 2021 11:20:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:49354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241390AbhITPU0 (ORCPT ); Mon, 20 Sep 2021 11:20:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A7FE161077; Mon, 20 Sep 2021 15:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632151139; bh=hMqD6PGf8FCPLkuwccE6s/NEp0UTku+p7fu9eNxoeKs=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=mD15+EK6ElnKTqCJSIZvB/+ThwMyeQH1d/qhx3ONsRTa4mvHnE7MlwDYOryDPYbeO gWNZGw7+khxdrccdIgJzpPGZEhNfpR8DqnsqK08Z8ffENAvi37Trobs2i1RcAGBN1D qeD9Sea3HNPW5C/GPQuqpeKVtud40gsihp5K2d4ijX+0nC06k6GROHXKXO0j9QzpAr Sir6OFBDFBu7las8I/dHU2b6YFp9y7gUORcDmazMPy3J7cSFlNd7cQZRVyYOqBgeR5 wup2sATMX5WnQCxoJhZ0sH257nQALMce9l6Z8SVyKdqd/qYH6qjHeeWtZ+/UcZ5GvO dzj8l6VavtoxQ== From: SeongJae Park To: Arnd Bergmann Cc: SeongJae Park , Andrew Morton , Brendan Higgins , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/damon: fix stringop-overread warning in kunit test Date: Mon, 20 Sep 2021 15:18:50 +0000 Message-Id: <20210920151850.4433-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210920100132.1390409-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 20 Sep 2021 12:01:23 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 points out that strnlen() with a fixed length on a constant > input makes no sense: > > In file included from mm/damon/dbgfs.c:623: > mm/damon/dbgfs-test.h: In function 'damon_dbgfs_test_str_to_target_ids': > mm/damon/dbgfs-test.h:23:47: error: 'strnlen' specified bound 128 exceeds source size 4 [-Werror=stringop-overread] > 23 | answers = str_to_target_ids(question, strnlen(question, 128), > | ^~~~~~~~~~~~~~~~~~~~~~ > mm/damon/dbgfs-test.h:30:47: error: 'strnlen' specified bound 128 exceeds source size 7 [-Werror=stringop-overread] > 30 | answers = str_to_target_ids(question, strnlen(question, 128), > | ^~~~~~~~~~~~~~~~~~~~~~ > mm/damon/dbgfs-test.h:37:47: error: 'strnlen' specified bound 128 exceeds source size 5 [-Werror=stringop-overread] > 37 | answers = str_to_target_ids(question, strnlen(question, 128), > | ^~~~~~~~~~~~~~~~~~~~~~ > > Use a plain strlen() instead. > > Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") > Signed-off-by: Arnd Bergmann Thank you for the patch! However, a same change has already merged[1] in -mm. Sorry for that. [1] https://lore.kernel.org/mm-commits/20210915033531.IdrhacHQk%25akpm@linux-foundation.org/ Thanks, SJ [...]