From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6655C43217 for ; Mon, 20 Sep 2021 18:43:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F134606A5 for ; Mon, 20 Sep 2021 18:43:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383670AbhITSov (ORCPT ); Mon, 20 Sep 2021 14:44:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:56468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382451AbhITSk2 (ORCPT ); Mon, 20 Sep 2021 14:40:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 866B163339; Mon, 20 Sep 2021 17:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632159077; bh=Lt8H//3PYyjNlRMNuMGGebseg7RKsl3v0b76htK/ZxM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VrlOIw1vlWVKc+LwBTjR0e9XQaVMc4LqXIzf851xzVW2Bb3XiqRl61IsMC9X4Gcoc 85oEiLpEJ6Pg0GA4f+PFtNxZqb1Uziu1GKaa/FiwZ/1jGz8yCQ5Q0wa3f5gSx+5ywE 1eohYN1XXij10seLrXZMWIRJ2ROT1r80iXg5NvXc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, John Stultz , Dan Carpenter , Srinivas Kandagatla , "David S. Miller" , Steev Klimaszewski Subject: [PATCH 5.14 033/168] net: qrtr: revert check in qrtr_endpoint_post() Date: Mon, 20 Sep 2021 18:42:51 +0200 Message-Id: <20210920163922.738362939@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210920163921.633181900@linuxfoundation.org> References: <20210920163921.633181900@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter commit d2cabd2dc8da78faf9b690ea521d03776686c9fe upstream. I tried to make this check stricter as a hardenning measure but it broke audo and wifi on these devices so revert it. Fixes: aaa8e4922c88 ("net: qrtr: make checks in qrtr_endpoint_post() stricter") Reported-by: John Stultz Signed-off-by: Dan Carpenter Tested-by: Srinivas Kandagatla Signed-off-by: David S. Miller Cc: Steev Klimaszewski Signed-off-by: Greg Kroah-Hartman --- net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -493,7 +493,7 @@ int qrtr_endpoint_post(struct qrtr_endpo goto err; } - if (!size || size & 3 || len != size + hdrlen) + if (!size || len != ALIGN(size, 4) + hdrlen) goto err; if (cb->dst_port != QRTR_PORT_CTRL && cb->type != QRTR_TYPE_DATA &&