From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 566F6C433F5 for ; Mon, 20 Sep 2021 22:14:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1269760F56 for ; Mon, 20 Sep 2021 22:14:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1269760F56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSRYX-0001I6-W9 for qemu-devel@archiver.kernel.org; Mon, 20 Sep 2021 18:14:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSR66-00038N-Qb for qemu-devel@nongnu.org; Mon, 20 Sep 2021 17:45:10 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:42965) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSR65-0001aZ-2e for qemu-devel@nongnu.org; Mon, 20 Sep 2021 17:45:10 -0400 Received: by mail-wr1-x42b.google.com with SMTP id q11so33568309wrr.9 for ; Mon, 20 Sep 2021 14:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Vx2dmg3HFxd0D29HGrTm+o8SOv+3wRTwCa15ndCgeUM=; b=m8ziF40J52/u1yKDfbYFuuNaThXb7y64HCXEw8Z8Bv8HKSynWACPyzJSRFIJ7Es3o+ gYOAz3fk4gEb5gLKJiXekdQJF2F66HlddC/BOu3lHr+ZWQADGT2vkWLE9xFsjIU3V2GU sxgYdsq1P+DItLZ6MW7qn3xDMLA+epovCcjkAJnx5MUY7wn8NO7wUj1I5zAwYmjNAewk ocJnyYzCflwZd7Z7kiEUIwEvdBF+1KLyj2+5m2fIvYDt18o3u2m2LGAo7YvFmuo/SliW /M0ASkqoqx0F8vm4SQ5vWNJY6FUjkhycqgSNtr4/jUmzdKU10ofdrrn9XNFtGPrFJ31r tE5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Vx2dmg3HFxd0D29HGrTm+o8SOv+3wRTwCa15ndCgeUM=; b=MAk8xQFRrEgXxh8xeRMUyrYp0IA6C7WXAPtqhW2IiZIuZ1U2AUYfwS2Qy90QDUy9rT ICElDs3HgVWP8E6b7nA6LngLqlZl4Xc8lB9+KaGP//JGejPu3j4ADgOxurnWuowedLIc LHhzriSdwHvtt9GNZDi5tyh7tXPOexBLlf7ECHj4/D+lHjnwuTOug0G7aL5ytwj/Wy+I 2xhVHrTx9Ono0ZEjUXmK9hVEG7/WKdawqBef33GcHGe/f2mUMBVlAOt2XgeMcEixmDTA vT33cx1Li2SA0xzyzBiiBJA9LcaOjgvMl9NHjco/E4lKmtd3Yhx35hGequ/s/HLPUfjw 4Qfg== X-Gm-Message-State: AOAM532wQj0Agfhtccgjd8qNLIWrxHxXcNJLlmnbDep06oqn6kvDSaq0 GYL10YolWRCKuUxS8FszKYznz7Ww2A0= X-Google-Smtp-Source: ABdhPJxR6+L3F4UHhDgi/bqh4LNq9zga4al+3z9thIBUPK6X+INQKQq4/nEmmRt689ybzTrYpdYTrA== X-Received: by 2002:a5d:530c:: with SMTP id e12mr31000085wrv.81.1632174307559; Mon, 20 Sep 2021 14:45:07 -0700 (PDT) Received: from x1w.. (118.red-83-35-24.dynamicip.rima-tde.net. [83.35.24.118]) by smtp.gmail.com with ESMTPSA id t1sm17188996wrz.39.2021.09.20.14.45.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 14:45:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v5 04/31] hw/core: Un-inline cpu_has_work() Date: Mon, 20 Sep 2021 23:44:20 +0200 Message-Id: <20210920214447.2998623-5-f4bug@amsat.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210920214447.2998623-1-f4bug@amsat.org> References: <20210920214447.2998623-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" We want to make cpu_has_work() per-accelerator. Only declare its prototype and move its definition to softmmu/cpus.c. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 8 +------- softmmu/cpus.c | 8 ++++++++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 2bd563e221f..e2dd171a13f 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -546,13 +546,7 @@ void cpu_dump_state(CPUState *cpu, FILE *f, int flags); * * Returns: %true if the CPU has work, %false otherwise. */ -static inline bool cpu_has_work(CPUState *cpu) -{ - CPUClass *cc = CPU_GET_CLASS(cpu); - - g_assert(cc->has_work); - return cc->has_work(cpu); -} +bool cpu_has_work(CPUState *cpu); /** * cpu_get_phys_page_attrs_debug: diff --git a/softmmu/cpus.c b/softmmu/cpus.c index 071085f840b..7e2cb2c571b 100644 --- a/softmmu/cpus.c +++ b/softmmu/cpus.c @@ -251,6 +251,14 @@ void cpu_interrupt(CPUState *cpu, int mask) } } +bool cpu_has_work(CPUState *cpu) +{ + CPUClass *cc = CPU_GET_CLASS(cpu); + + g_assert(cc->has_work); + return cc->has_work(cpu); +} + static int do_vm_stop(RunState state, bool send_stop) { int ret = 0; -- 2.31.1