All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	Jens Axboe <axboe@kernel.dk>
Cc: kbuild-all@lists.01.org, Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	linux-block@vger.kernel.org, nvdimm@lists.linux.dev
Subject: Re: [PATCH 2/3] nvdimm/pmem: move dax_attribute_group from dax to pmem
Date: Tue, 21 Sep 2021 02:00:13 +0800	[thread overview]
Message-ID: <202109210155.7rqblE6U-lkp@intel.com> (raw)
In-Reply-To: <20210920072726.1159572-3-hch@lst.de>

[-- Attachment #1: Type: text/plain, Size: 4375 bytes --]

Hi Christoph,

I love your patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v5.15-rc2 next-20210920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christoph-Hellwig/nvdimm-pmem-fix-creating-the-dax-group/20210920-162804
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: riscv-buildonly-randconfig-r006-20210920 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1a16d0f32f70bcd159a9f8cf32794f4024e8711e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christoph-Hellwig/nvdimm-pmem-fix-creating-the-dax-group/20210920-162804
        git checkout 1a16d0f32f70bcd159a9f8cf32794f4024e8711e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/dax/super.c:375:6: error: no previous prototype for 'run_dax' [-Werror=missing-prototypes]
     375 | void run_dax(struct dax_device *dax_dev)
         |      ^~~~~~~
>> drivers/dax/super.c:70:27: error: 'dax_get_by_host' defined but not used [-Werror=unused-function]
      70 | static struct dax_device *dax_get_by_host(const char *host)
         |                           ^~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/dax_get_by_host +70 drivers/dax/super.c

1b7646014e0d838b Christoph Hellwig 2021-08-26  65  
1b7646014e0d838b Christoph Hellwig 2021-08-26  66  /**
1b7646014e0d838b Christoph Hellwig 2021-08-26  67   * dax_get_by_host() - temporary lookup mechanism for filesystem-dax
1b7646014e0d838b Christoph Hellwig 2021-08-26  68   * @host: alternate name for the device registered by a dax driver
1b7646014e0d838b Christoph Hellwig 2021-08-26  69   */
1b7646014e0d838b Christoph Hellwig 2021-08-26 @70  static struct dax_device *dax_get_by_host(const char *host)
1b7646014e0d838b Christoph Hellwig 2021-08-26  71  {
1b7646014e0d838b Christoph Hellwig 2021-08-26  72  	struct dax_device *dax_dev, *found = NULL;
1b7646014e0d838b Christoph Hellwig 2021-08-26  73  	int hash, id;
1b7646014e0d838b Christoph Hellwig 2021-08-26  74  
1b7646014e0d838b Christoph Hellwig 2021-08-26  75  	if (!host)
1b7646014e0d838b Christoph Hellwig 2021-08-26  76  		return NULL;
1b7646014e0d838b Christoph Hellwig 2021-08-26  77  
1b7646014e0d838b Christoph Hellwig 2021-08-26  78  	hash = dax_host_hash(host);
1b7646014e0d838b Christoph Hellwig 2021-08-26  79  
1b7646014e0d838b Christoph Hellwig 2021-08-26  80  	id = dax_read_lock();
1b7646014e0d838b Christoph Hellwig 2021-08-26  81  	spin_lock(&dax_host_lock);
1b7646014e0d838b Christoph Hellwig 2021-08-26  82  	hlist_for_each_entry(dax_dev, &dax_host_list[hash], list) {
1b7646014e0d838b Christoph Hellwig 2021-08-26  83  		if (!dax_alive(dax_dev)
1b7646014e0d838b Christoph Hellwig 2021-08-26  84  				|| strcmp(host, dax_dev->host) != 0)
1b7646014e0d838b Christoph Hellwig 2021-08-26  85  			continue;
1b7646014e0d838b Christoph Hellwig 2021-08-26  86  
1b7646014e0d838b Christoph Hellwig 2021-08-26  87  		if (igrab(&dax_dev->inode))
1b7646014e0d838b Christoph Hellwig 2021-08-26  88  			found = dax_dev;
1b7646014e0d838b Christoph Hellwig 2021-08-26  89  		break;
1b7646014e0d838b Christoph Hellwig 2021-08-26  90  	}
1b7646014e0d838b Christoph Hellwig 2021-08-26  91  	spin_unlock(&dax_host_lock);
1b7646014e0d838b Christoph Hellwig 2021-08-26  92  	dax_read_unlock(id);
1b7646014e0d838b Christoph Hellwig 2021-08-26  93  
1b7646014e0d838b Christoph Hellwig 2021-08-26  94  	return found;
1b7646014e0d838b Christoph Hellwig 2021-08-26  95  }
1b7646014e0d838b Christoph Hellwig 2021-08-26  96  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28763 bytes --]

WARNING: multiple messages have this Message-ID
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/3] nvdimm/pmem: move dax_attribute_group from dax to pmem
Date: Tue, 21 Sep 2021 02:00:13 +0800	[thread overview]
Message-ID: <202109210155.7rqblE6U-lkp@intel.com> (raw)
In-Reply-To: <20210920072726.1159572-3-hch@lst.de>

[-- Attachment #1: Type: text/plain, Size: 4453 bytes --]

Hi Christoph,

I love your patch! Yet something to improve:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on linus/master v5.15-rc2 next-20210920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christoph-Hellwig/nvdimm-pmem-fix-creating-the-dax-group/20210920-162804
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: riscv-buildonly-randconfig-r006-20210920 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1a16d0f32f70bcd159a9f8cf32794f4024e8711e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christoph-Hellwig/nvdimm-pmem-fix-creating-the-dax-group/20210920-162804
        git checkout 1a16d0f32f70bcd159a9f8cf32794f4024e8711e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/dax/super.c:375:6: error: no previous prototype for 'run_dax' [-Werror=missing-prototypes]
     375 | void run_dax(struct dax_device *dax_dev)
         |      ^~~~~~~
>> drivers/dax/super.c:70:27: error: 'dax_get_by_host' defined but not used [-Werror=unused-function]
      70 | static struct dax_device *dax_get_by_host(const char *host)
         |                           ^~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors


vim +/dax_get_by_host +70 drivers/dax/super.c

1b7646014e0d838b Christoph Hellwig 2021-08-26  65  
1b7646014e0d838b Christoph Hellwig 2021-08-26  66  /**
1b7646014e0d838b Christoph Hellwig 2021-08-26  67   * dax_get_by_host() - temporary lookup mechanism for filesystem-dax
1b7646014e0d838b Christoph Hellwig 2021-08-26  68   * @host: alternate name for the device registered by a dax driver
1b7646014e0d838b Christoph Hellwig 2021-08-26  69   */
1b7646014e0d838b Christoph Hellwig 2021-08-26 @70  static struct dax_device *dax_get_by_host(const char *host)
1b7646014e0d838b Christoph Hellwig 2021-08-26  71  {
1b7646014e0d838b Christoph Hellwig 2021-08-26  72  	struct dax_device *dax_dev, *found = NULL;
1b7646014e0d838b Christoph Hellwig 2021-08-26  73  	int hash, id;
1b7646014e0d838b Christoph Hellwig 2021-08-26  74  
1b7646014e0d838b Christoph Hellwig 2021-08-26  75  	if (!host)
1b7646014e0d838b Christoph Hellwig 2021-08-26  76  		return NULL;
1b7646014e0d838b Christoph Hellwig 2021-08-26  77  
1b7646014e0d838b Christoph Hellwig 2021-08-26  78  	hash = dax_host_hash(host);
1b7646014e0d838b Christoph Hellwig 2021-08-26  79  
1b7646014e0d838b Christoph Hellwig 2021-08-26  80  	id = dax_read_lock();
1b7646014e0d838b Christoph Hellwig 2021-08-26  81  	spin_lock(&dax_host_lock);
1b7646014e0d838b Christoph Hellwig 2021-08-26  82  	hlist_for_each_entry(dax_dev, &dax_host_list[hash], list) {
1b7646014e0d838b Christoph Hellwig 2021-08-26  83  		if (!dax_alive(dax_dev)
1b7646014e0d838b Christoph Hellwig 2021-08-26  84  				|| strcmp(host, dax_dev->host) != 0)
1b7646014e0d838b Christoph Hellwig 2021-08-26  85  			continue;
1b7646014e0d838b Christoph Hellwig 2021-08-26  86  
1b7646014e0d838b Christoph Hellwig 2021-08-26  87  		if (igrab(&dax_dev->inode))
1b7646014e0d838b Christoph Hellwig 2021-08-26  88  			found = dax_dev;
1b7646014e0d838b Christoph Hellwig 2021-08-26  89  		break;
1b7646014e0d838b Christoph Hellwig 2021-08-26  90  	}
1b7646014e0d838b Christoph Hellwig 2021-08-26  91  	spin_unlock(&dax_host_lock);
1b7646014e0d838b Christoph Hellwig 2021-08-26  92  	dax_read_unlock(id);
1b7646014e0d838b Christoph Hellwig 2021-08-26  93  
1b7646014e0d838b Christoph Hellwig 2021-08-26  94  	return found;
1b7646014e0d838b Christoph Hellwig 2021-08-26  95  }
1b7646014e0d838b Christoph Hellwig 2021-08-26  96  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28763 bytes --]

  reply	other threads:[~2021-09-20 18:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20  7:27 fix a dax/block device attribute registration regression Christoph Hellwig
2021-09-20  7:27 ` [PATCH 1/3] nvdimm/pmem: fix creating the dax group Christoph Hellwig
2021-09-20 22:52   ` Ira Weiny
2021-09-20 23:09   ` Dan Williams
2021-09-20 23:09     ` Dan Williams
2021-09-20  7:27 ` [PATCH 2/3] nvdimm/pmem: move dax_attribute_group from dax to pmem Christoph Hellwig
2021-09-20 18:00   ` kernel test robot [this message]
2021-09-20 18:00     ` kernel test robot
2021-09-20 23:29     ` Dan Williams
2021-09-20 23:29       ` Dan Williams
2021-09-20 23:29       ` Dan Williams
2021-09-20 22:51   ` Ira Weiny
2021-09-20 23:36     ` Dan Williams
2021-09-20 23:36       ` Dan Williams
2021-09-20 23:37   ` Dan Williams
2021-09-20 23:37     ` Dan Williams
2021-09-20  7:27 ` [PATCH 3/3] block: warn if ->groups is set when calling add_disk Christoph Hellwig
2021-09-20 22:52   ` Ira Weiny
2021-09-20 23:50   ` Dan Williams
2021-09-20 23:50     ` Dan Williams
2021-09-21  6:32     ` Christoph Hellwig
2021-09-22 17:34 dax_supported() related cleanups v2 Christoph Hellwig
2021-09-22 17:34 ` [PATCH 2/3] nvdimm/pmem: move dax_attribute_group from dax to pmem Christoph Hellwig
2021-09-22 18:33 fix a dax/block device attribute registration regression Christoph Hellwig
2021-09-22 18:33 ` [PATCH 2/3] nvdimm/pmem: move dax_attribute_group from dax to pmem Christoph Hellwig
2021-09-22 21:40   ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109210155.7rqblE6U-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=axboe@kernel.dk \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=hch@lst.de \
    --cc=ira.weiny@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-block@vger.kernel.org \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.