From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B404C433EF for ; Tue, 21 Sep 2021 09:56:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF6CF61181 for ; Tue, 21 Sep 2021 09:56:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF6CF61181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s0+ATCzXIDM2+4De6bi9BBZWdNJuPGeL7HZrtrenGlI=; b=Eq6Rem2uozU0DP RIXYPjFJxEovGU3e5Tqh0LfeidWL8ovZrWiIwmSOWt7FCaJgDyvUGVcGRVgfmMJNybSZjoqKYrynx 3YjIjMNNwWnicN6yGW0k+qROMk/Uyywve2Blkza/I+Is6qxCBqkgEHAv/rlqfd4r4qjt7PTBFeAUp /DHKfEkbBPHc1H1wAWjiGOnjeNzmmORMEXini4MOTnlDYRpUkRxoK7e240u18N2REVkSPW+p742qG 40EhqO5/gCUtNc+/LtNIug1ElQx+KuSUYHkyOYzADG38dtZgnbaZnLF7OU6xzRatun0xTXANXX9I8 41c23bGSUcv0cpEG1Ztw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mScTu-00453l-2W; Tue, 21 Sep 2021 09:54:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mScTh-00451d-Rv for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 09:54:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CE5D761183; Tue, 21 Sep 2021 09:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632218057; bh=MaIL+DdDcgXUWtTGjk7YnJ87/wA7ezvCQd746VCVlYg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aCU5j1uC6RNRlvGdjlaEu+vXHrbToAiYWKU8VK6SpqSMDgFH1LuZrGoAT1d3w8HiF gq9miqUart+nuJzWywn7cWchFOMlte+MzUuLlrNOK+IKw1viISUL2KO9T4O1vaepb4 VOs81ous1A54Bht9G8JvVtv8fjzJWplZRpvyEDdyi2szyBWZqlBx1aPEuBQZiSXBPU NGfr1ZY5qTkVRMYeSdtEJe5c1TOeOvtyOhcjaDc/2KbC7PUsCmzCKJacJpT+vJ54JU z8JZq7UnLD9TIu3uFpGNqGZCOORVl0paMtWYH0Sy3R/AeBjYlCBwNpDvo3RYkBJ5wm ORS/npiPrp1HQ== From: Ard Biesheuvel To: linux@armlinux.org.uk Cc: linux-arm-kernel@lists.infradead.org, Ard Biesheuvel , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij Subject: [PATCH 01/10] ARM: fix incorrect use of get_kernel_nofault() Date: Tue, 21 Sep 2021 11:53:59 +0200 Message-Id: <20210921095408.133210-2-ardb@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210921095408.133210-1-ardb@kernel.org> References: <20210921095408.133210-1-ardb@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_025417_957904_B636E27B X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Commit 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead of set_fs()") replaced an occurrence of __get_user() with get_kernel_nofault(), but inverted the sense of the conditional in the process, resulting in no values to be printed at all. I.e., every exception stack now looks like this: Exception stack(0xc18d1fb0 to 0xc18d1ff8) 1fa0: ???????? ???????? ???????? ???????? 1fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ???????? 1fe0: ???????? ???????? ???????? ???????? ???????? ???????? which is rather unhelpful. Fixes: 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead of set_fs()") Signed-off-by: Ard Biesheuvel --- arch/arm/kernel/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c index 4a7edc6e848f..195dff58bafc 100644 --- a/arch/arm/kernel/traps.c +++ b/arch/arm/kernel/traps.c @@ -136,7 +136,7 @@ static void dump_mem(const char *lvl, const char *str, unsigned long bottom, for (p = first, i = 0; i < 8 && p < top; i++, p += 4) { if (p >= bottom && p < top) { unsigned long val; - if (get_kernel_nofault(val, (unsigned long *)p)) + if (!get_kernel_nofault(val, (unsigned long *)p)) sprintf(str + i * 9, " %08lx", val); else sprintf(str + i * 9, " ????????"); -- 2.30.2 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel