[PATCH 1/6] dt-bindings: hwmon: ti,tmp108: convert to dtschema

[PATCH 1/6] dt-bindings: hwmon: ti,tmp108: convert to dtschema

[Krzysztof Kozlowski]

Convert the TI TMP108 temperature sensor bindings to DT schema format.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../devicetree/bindings/hwmon/ti,tmp108.yaml  | 50 +++++++++++++++++++
 .../devicetree/bindings/hwmon/tmp108.txt      | 18 -------
 2 files changed, 50 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
 delete mode 100644 Documentation/devicetree/bindings/hwmon/tmp108.txt

diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
new file mode 100644
index 000000000000..eda55bbc172d
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/ti,tmp108.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TMP108 temperature sensor
+
+maintainers:
+  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
+
+properties:
+  compatible:
+    enum:
+      - ti,tmp108
+
+  interrupts:
+    items:
+      - description: alert interrupt
+
+  reg:
+    maxItems: 1
+
+  "#thermal-sensor-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@48 {
+            compatible = "ti,tmp108";
+            reg = <0x48>;
+            interrupt-parent = <&gpio1>;
+            interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
+            pinctrl-names = "default";
+            pinctrl-0 = <&tmp_alrt>;
+            #thermal-sensor-cells = <0>;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt
deleted file mode 100644
index 54d4beed4ee5..000000000000
--- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-TMP108 temperature sensor
--------------------------
-
-This device supports I2C only.
-
-Requires node properties:
-- compatible : "ti,tmp108"
-- reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
-
-Optional properties:
-- interrupts: Reference to the TMP108 alert interrupt.
-- #thermal-sensor-cells: should be set to 0.
-
-Example:
-	tmp108@48 {
-		compatible = "ti,tmp108";
-		reg = <0x48>;
-	};
-- 
2.30.2

[PATCH 2/6] dt-bindings: hwmon: ti,tmp102: add bindings and remove from trivial devices

[Krzysztof Kozlowski]

The TI TMP102 temperature sensor does not fit into trivial devices
bindings due to additional properties.  Add separate bindings for it.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../devicetree/bindings/hwmon/ti,tmp102.yaml  | 47 +++++++++++++++++++
 .../devicetree/bindings/trivial-devices.yaml  |  2 -
 2 files changed, 47 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
new file mode 100644
index 000000000000..d3eff4fac107
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TMP102 temperature sensor
+
+maintainers:
+  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
+
+properties:
+  compatible:
+    enum:
+      - ti,tmp102
+
+  interrupts:
+    maxItems: 1
+
+  reg:
+    maxItems: 1
+
+  "#thermal-sensor-cells":
+    const: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@48 {
+            compatible = "ti,tmp102";
+            reg = <0x48>;
+            interrupt-parent = <&gpio7>;
+            interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
+            #thermal-sensor-cells = <1>;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index c9333fb81fdf..6ad0628741cf 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -317,8 +317,6 @@ properties:
             # I2C Touch-Screen Controller
           - ti,tsc2003
             # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
-          - ti,tmp102
-            # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
           - ti,tmp103
             # Thermometer with SPI interface
           - ti,tmp121
-- 
2.30.2

[PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Krzysztof Kozlowski]

The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
trivial, so they can be integrated into trivial devices bindings.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../devicetree/bindings/hwmon/ibm,cffps1.txt  | 26 -------------------
 .../devicetree/bindings/trivial-devices.yaml  |  6 +++++
 MAINTAINERS                                   |  1 -
 3 files changed, 6 insertions(+), 27 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt

diff --git a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt b/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
deleted file mode 100644
index d9a2719f9243..000000000000
--- a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-Device-tree bindings for IBM Common Form Factor Power Supply Versions 1 and 2
------------------------------------------------------------------------------
-
-Required properties:
- - compatible				: Must be one of the following:
-						"ibm,cffps1"
-						"ibm,cffps2"
-						or "ibm,cffps" if the system
-						must support any version of the
-						power supply
- - reg = < I2C bus address >;		: Address of the power supply on the
-					  I2C bus.
-
-Example:
-
-    i2c-bus@100 {
-        #address-cells = <1>;
-        #size-cells = <0>;
-        #interrupt-cells = <1>;
-        < more properties >
-
-        power-supply@68 {
-            compatible = "ibm,cffps1";
-            reg = <0x68>;
-        };
-    };
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 6ad0628741cf..791079021f1b 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -113,6 +113,12 @@ properties:
           - mps,mp2975
             # Honeywell Humidicon HIH-6130 humidity/temperature sensor
           - honeywell,hi6130
+            # IBM Common Form Factor Power Supply Versions (all versions)
+          - ibm,cffps
+            # IBM Common Form Factor Power Supply Versions 1
+          - ibm,cffps1
+            # IBM Common Form Factor Power Supply Versions 2
+          - ibm,cffps2
             # Infineon IR36021 digital POL buck controller
           - infineon,ir36021
             # Infineon IR38064 Voltage Regulator
diff --git a/MAINTAINERS b/MAINTAINERS
index 15c4d3c809e8..cc5df54bdc51 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14956,7 +14956,6 @@ S:	Maintained
 W:	http://hwmon.wiki.kernel.org/
 W:	http://www.roeck-us.net/linux/drivers/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
-F:	Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
 F:	Documentation/devicetree/bindings/hwmon/ltc2978.txt
 F:	Documentation/devicetree/bindings/hwmon/max31785.txt
 F:	Documentation/hwmon/adm1275.rst
-- 
2.30.2

[PATCH 4/6] dt-bindings: hwmon: lltc,ltc4151: convert to dtschema

[Krzysztof Kozlowski]

Convert the LTC4151 current and voltage sensor bindings to DT schema
format.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../bindings/hwmon/lltc,ltc4151.yaml          | 41 +++++++++++++++++++
 .../devicetree/bindings/hwmon/ltc4151.txt     | 18 --------
 2 files changed, 41 insertions(+), 18 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml
 delete mode 100644 Documentation/devicetree/bindings/hwmon/ltc4151.txt

diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml
new file mode 100644
index 000000000000..4b5851c326f7
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml
@@ -0,0 +1,41 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/lltc,ltc4151.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: LTC4151 High Voltage I2C Current and Voltage Monitor
+
+maintainers:
+  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
+
+properties:
+  compatible:
+    const: lltc,ltc4151
+
+  reg:
+    maxItems: 1
+
+  shunt-resistor-micro-ohms:
+    description:
+      Shunt resistor value in micro-Ohms
+    default: 1000
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        sensor@6e {
+            compatible = "lltc,ltc4151";
+            reg = <0x6e>;
+            shunt-resistor-micro-ohms = <1500>;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/hwmon/ltc4151.txt b/Documentation/devicetree/bindings/hwmon/ltc4151.txt
deleted file mode 100644
index d008a5ef525a..000000000000
--- a/Documentation/devicetree/bindings/hwmon/ltc4151.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-LTC4151 High Voltage I2C Current and Voltage Monitor
-
-Required properties:
-- compatible: Must be "lltc,ltc4151"
-- reg: I2C address
-
-Optional properties:
-- shunt-resistor-micro-ohms
-	Shunt resistor value in micro-Ohms
-	Defaults to <1000> if unset.
-
-Example:
-
-ltc4151@6e {
-	compatible = "lltc,ltc4151";
-	reg = <0x6e>;
-	shunt-resistor-micro-ohms = <1500>;
-};
-- 
2.30.2

[PATCH 5/6] dt-bindings: hwmon: microchip,mcp3021: convert to dtschema

[Krzysztof Kozlowski]

Convert the Microchip MCP3021 ADC bindings to DT schema format.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../devicetree/bindings/hwmon/mcp3021.txt     | 21 ---------
 .../bindings/hwmon/microchip,mcp3021.yaml     | 43 +++++++++++++++++++
 2 files changed, 43 insertions(+), 21 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/hwmon/mcp3021.txt
 create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml

diff --git a/Documentation/devicetree/bindings/hwmon/mcp3021.txt b/Documentation/devicetree/bindings/hwmon/mcp3021.txt
deleted file mode 100644
index 294318ba6914..000000000000
--- a/Documentation/devicetree/bindings/hwmon/mcp3021.txt
+++ /dev/null
@@ -1,21 +0,0 @@
-mcp3021 properties
-
-Required properties:
-- compatible: Must be one of the following:
-	- "microchip,mcp3021" for mcp3021
-	- "microchip,mcp3221" for mcp3221
-- reg: I2C address
-
-Optional properties:
-
-- reference-voltage-microvolt
-	Reference voltage in microvolt (uV)
-
-Example:
-
-mcp3021@4d {
-	compatible = "microchip,mcp3021";
-	reg = <0x4d>;
-
-	reference-voltage-microvolt = <4500000>; /* 4.5 V */
-};
diff --git a/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml b/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
new file mode 100644
index 000000000000..c42051f8a191
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/microchip,mcp3021.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip MCP3021 A/D converter
+
+maintainers:
+  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
+
+properties:
+  compatible:
+    enum:
+      - microchip,mcp3021
+      - microchip,mcp3221
+
+  reg:
+    maxItems: 1
+
+  reference-voltage-microvolt:
+    description:
+      VDD supply power and reference voltage
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        adc@4d {
+            compatible = "microchip,mcp3021";
+            reg = <0x4d>;
+
+            reference-voltage-microvolt = <4500000>; /* 4.5 V */
+        };
+    };
-- 
2.30.2

[PATCH 6/6] dt-bindings: hwmon: sensirion,sht15: convert to dtschema

[Krzysztof Kozlowski]

Convert the Sensirion SHT15 humidity sensor to DT schema format.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .../bindings/hwmon/sensirion,sht15.yaml       | 43 +++++++++++++++++++
 .../devicetree/bindings/hwmon/sht15.txt       | 19 --------
 2 files changed, 43 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml
 delete mode 100644 Documentation/devicetree/bindings/hwmon/sht15.txt

diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml
new file mode 100644
index 000000000000..4669217d01e1
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/sensirion,sht15.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sensirion SHT15 humidity and temperature sensor
+
+maintainers:
+  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
+
+properties:
+  compatible:
+    const: sensirion,sht15
+
+  clk-gpios:
+    maxItems: 1
+
+  data-gpios:
+    maxItems: 1
+
+  vcc-supply:
+    description: regulator that drives the VCC pin
+
+required:
+  - compatible
+  - clk-gpios
+  - data-gpios
+  - vcc-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    sensor {
+        compatible = "sensirion,sht15";
+        clk-gpios = <&gpio4 12 0>;
+        data-gpios = <&gpio4 13 0>;
+        vcc-supply = <&reg_sht15>;
+
+        pinctrl-names = "default";
+        pinctrl-0 = <&pinctrl_sensor>;
+    };
diff --git a/Documentation/devicetree/bindings/hwmon/sht15.txt b/Documentation/devicetree/bindings/hwmon/sht15.txt
deleted file mode 100644
index 6a80277cc426..000000000000
--- a/Documentation/devicetree/bindings/hwmon/sht15.txt
+++ /dev/null
@@ -1,19 +0,0 @@
-Sensirion SHT15 Humidity and Temperature Sensor
-
-Required properties:
-
- - "compatible": must be "sensirion,sht15".
- - "data-gpios": GPIO connected to the data line.
- - "clk-gpios": GPIO connected to the clock line.
- - "vcc-supply": regulator that drives the VCC pin.
-
-Example:
-
-	sensor {
-		pinctrl-names = "default";
-		pinctrl-0 = <&pinctrl_sensor>;
-		compatible = "sensirion,sht15";
-		clk-gpios = <&gpio4 12 0>;
-		data-gpios = <&gpio4 13 0>;
-		vcc-supply = <&reg_sht15>;
-	};
-- 
2.30.2

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Guenter Roeck]

On Tue, Sep 21, 2021 at 12:28:29PM +0200, Krzysztof Kozlowski wrote:
> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
> trivial, so they can be integrated into trivial devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>

I won't accept any of those "move to trivial devices" patches. In many cases
the bindings are simply incomplete. I can not and will not make that call,
and I always did and will leave it up to driver authors to decide if they
want to add a device to trivial devices or provide explicit bindings.

Please stop sending those patches.

Guenter

> ---
>  .../devicetree/bindings/hwmon/ibm,cffps1.txt  | 26 -------------------
>  .../devicetree/bindings/trivial-devices.yaml  |  6 +++++
>  MAINTAINERS                                   |  1 -
>  3 files changed, 6 insertions(+), 27 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt b/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> deleted file mode 100644
> index d9a2719f9243..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -Device-tree bindings for IBM Common Form Factor Power Supply Versions 1 and 2
> ------------------------------------------------------------------------------
> -
> -Required properties:
> - - compatible				: Must be one of the following:
> -						"ibm,cffps1"
> -						"ibm,cffps2"
> -						or "ibm,cffps" if the system
> -						must support any version of the
> -						power supply
> - - reg = < I2C bus address >;		: Address of the power supply on the
> -					  I2C bus.
> -
> -Example:
> -
> -    i2c-bus@100 {
> -        #address-cells = <1>;
> -        #size-cells = <0>;
> -        #interrupt-cells = <1>;
> -        < more properties >
> -
> -        power-supply@68 {
> -            compatible = "ibm,cffps1";
> -            reg = <0x68>;
> -        };
> -    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6ad0628741cf..791079021f1b 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -113,6 +113,12 @@ properties:
>            - mps,mp2975
>              # Honeywell Humidicon HIH-6130 humidity/temperature sensor
>            - honeywell,hi6130
> +            # IBM Common Form Factor Power Supply Versions (all versions)
> +          - ibm,cffps
> +            # IBM Common Form Factor Power Supply Versions 1
> +          - ibm,cffps1
> +            # IBM Common Form Factor Power Supply Versions 2
> +          - ibm,cffps2
>              # Infineon IR36021 digital POL buck controller
>            - infineon,ir36021
>              # Infineon IR38064 Voltage Regulator
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 15c4d3c809e8..cc5df54bdc51 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14956,7 +14956,6 @@ S:	Maintained
>  W:	http://hwmon.wiki.kernel.org/
>  W:	http://www.roeck-us.net/linux/drivers/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> -F:	Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
>  F:	Documentation/devicetree/bindings/hwmon/ltc2978.txt
>  F:	Documentation/devicetree/bindings/hwmon/max31785.txt
>  F:	Documentation/hwmon/adm1275.rst
> -- 
> 2.30.2
> 

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Krzysztof Kozlowski]

On 21/09/2021 14:30, Guenter Roeck wrote:
> On Tue, Sep 21, 2021 at 12:28:29PM +0200, Krzysztof Kozlowski wrote:
>> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
>> trivial, so they can be integrated into trivial devices bindings.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> 
> I won't accept any of those "move to trivial devices" patches. In many cases
> the bindings are simply incomplete. I can not and will not make that call,
> and I always did and will leave it up to driver authors to decide if they
> want to add a device to trivial devices or provide explicit bindings.
> 
> Please stop sending those patches.
> 

Back in the older times, there were no trivial-devices and checkpatch
plus maintainers required documenting compatibles, so some of such
simple bindings were created.

I understand however your point, fair enough. I'll stop sending such
patches.

Best regards,
Krzysztof

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Guenter Roeck]

On Tue, Sep 21, 2021 at 02:45:42PM +0200, Krzysztof Kozlowski wrote:
> On 21/09/2021 14:30, Guenter Roeck wrote:
> > On Tue, Sep 21, 2021 at 12:28:29PM +0200, Krzysztof Kozlowski wrote:
> >> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
> >> trivial, so they can be integrated into trivial devices bindings.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > 
> > I won't accept any of those "move to trivial devices" patches. In many cases
> > the bindings are simply incomplete. I can not and will not make that call,
> > and I always did and will leave it up to driver authors to decide if they
> > want to add a device to trivial devices or provide explicit bindings.
> > 
> > Please stop sending those patches.
> > 
> 
> Back in the older times, there were no trivial-devices and checkpatch
> plus maintainers required documenting compatibles, so some of such
> simple bindings were created.
> 

At the same time, as I said, the bindings for many chips are incomplete.
For this driver, we can not make that call because the datasheet is not
public. The same is true for dps650ab. For others, the datasheet is
available, and a reasonable decision can be made if the chip may ever
need more complete bindings.

So, let's qualify my statement: I'll accept such patches if you can show,
from the datasheet, that it is unlikely that explicit bindings will ever
be needed. That would be the case for LM70, for example. That would need
more than a statement that "bindings are trivial", though. It also require
a statement along the line that you have confirmed, from to the datasheet,
that there is nothing to configure for this chip that would ever require
explicit bindings.

Thanks,
Guenter

> I understand however your point, fair enough. I'll stop sending such
> patches.
> 
> Best regards,
> Krzysztof

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Krzysztof Kozlowski]

On 21/09/2021 15:18, Guenter Roeck wrote:
> On Tue, Sep 21, 2021 at 02:45:42PM +0200, Krzysztof Kozlowski wrote:
>> On 21/09/2021 14:30, Guenter Roeck wrote:
>>> On Tue, Sep 21, 2021 at 12:28:29PM +0200, Krzysztof Kozlowski wrote:
>>>> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
>>>> trivial, so they can be integrated into trivial devices bindings.
>>>>
>>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>>
>>> I won't accept any of those "move to trivial devices" patches. In many cases
>>> the bindings are simply incomplete. I can not and will not make that call,
>>> and I always did and will leave it up to driver authors to decide if they
>>> want to add a device to trivial devices or provide explicit bindings.
>>>
>>> Please stop sending those patches.
>>>
>>
>> Back in the older times, there were no trivial-devices and checkpatch
>> plus maintainers required documenting compatibles, so some of such
>> simple bindings were created.
>>
> 
> At the same time, as I said, the bindings for many chips are incomplete.
> For this driver, we can not make that call because the datasheet is not
> public. The same is true for dps650ab. For others, the datasheet is
> available, and a reasonable decision can be made if the chip may ever
> need more complete bindings.
> 
> So, let's qualify my statement: I'll accept such patches if you can show,
> from the datasheet, that it is unlikely that explicit bindings will ever
> be needed. That would be the case for LM70, for example. That would need
> more than a statement that "bindings are trivial", though. It also require
> a statement along the line that you have confirmed, from to the datasheet,
> that there is nothing to configure for this chip that would ever require
> explicit bindings.

Thanks for longer explanation. I agree with your reasoning here. I'll
re-check my move-to-trivial patches and, if applicable, send a new
version with better explanation.

I hope this won't stop from reviewing the few other patches in the set
adding separate bindings.


Best regards,
Krzysztof

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Guenter Roeck]

On Tue, Sep 21, 2021 at 04:40:32PM +0200, Krzysztof Kozlowski wrote:
> 
> I hope this won't stop from reviewing the few other patches in the set
> adding separate bindings.
> 
I don't actively review dt patches, but rely on Rob to do that.
Reason for that is that I almost always get something wrong.
So let's wait for Rob's feedback.

Thanks,
Guenter

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Rob Herring]

On Tue, Sep 21, 2021 at 02:45:42PM +0200, Krzysztof Kozlowski wrote:
> On 21/09/2021 14:30, Guenter Roeck wrote:
> > On Tue, Sep 21, 2021 at 12:28:29PM +0200, Krzysztof Kozlowski wrote:
> >> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
> >> trivial, so they can be integrated into trivial devices bindings.
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> > 
> > I won't accept any of those "move to trivial devices" patches. In many cases
> > the bindings are simply incomplete. I can not and will not make that call,
> > and I always did and will leave it up to driver authors to decide if they
> > want to add a device to trivial devices or provide explicit bindings.
> > 
> > Please stop sending those patches.
> > 
> 
> Back in the older times, there were no trivial-devices and checkpatch
> plus maintainers required documenting compatibles, so some of such
> simple bindings were created.

We've had trivial-devices since at least 2011, but it was under i2c 
until 2017. Many existed before we had clock, regulator, etc. bindings, 
so they may have been complete at the time.

> 
> I understand however your point, fair enough. I'll stop sending such
> patches.

Just about every device has a power supply which would not fall in the 
current definition of trivial-devices, though maybe that could be 
extended. I do sometimes wonder if we should just get rid of 
trivial-devices.yaml.

On the flip side, I'd much rather have a schema for these than wait on 
someone to decide to convert them. That could mean a device.txt -> 
trivial-devices.yaml -> device.yaml trip, but that doesn't seem that 
terrible to me. Then we at least are running schema checks on the 
devices and know if actual users have more undocumented properties. 
We still have ~2000 free form binding docs to convert. I'm looking for 
whatever ways we can speed that up and this looks like one of them to 
me (both Krzysztof's great job doing all these conversions and utilizing 
trivial-devices.yaml).

Rob

Re: [PATCH 1/6] dt-bindings: hwmon: ti,tmp108: convert to dtschema

[Rob Herring]

On Tue, 21 Sep 2021 12:28:27 +0200, Krzysztof Kozlowski wrote:
> Convert the TI TMP108 temperature sensor bindings to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/hwmon/ti,tmp108.yaml  | 50 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/tmp108.txt      | 18 -------
>  2 files changed, 50 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/tmp108.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 2/6] dt-bindings: hwmon: ti,tmp102: add bindings and remove from trivial devices

[Rob Herring]

On Tue, 21 Sep 2021 12:28:28 +0200, Krzysztof Kozlowski wrote:
> The TI TMP102 temperature sensor does not fit into trivial devices
> bindings due to additional properties.  Add separate bindings for it.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/hwmon/ti,tmp102.yaml  | 47 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  2 -
>  2 files changed, 47 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 4/6] dt-bindings: hwmon: lltc,ltc4151: convert to dtschema

[Rob Herring]

On Tue, 21 Sep 2021 12:28:30 +0200, Krzysztof Kozlowski wrote:
> Convert the LTC4151 current and voltage sensor bindings to DT schema
> format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../bindings/hwmon/lltc,ltc4151.yaml          | 41 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/ltc4151.txt     | 18 --------
>  2 files changed, 41 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ltc4151.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 5/6] dt-bindings: hwmon: microchip,mcp3021: convert to dtschema

[Rob Herring]

On Tue, 21 Sep 2021 12:28:31 +0200, Krzysztof Kozlowski wrote:
> Convert the Microchip MCP3021 ADC bindings to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/hwmon/mcp3021.txt     | 21 ---------
>  .../bindings/hwmon/microchip,mcp3021.yaml     | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 21 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/mcp3021.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 6/6] dt-bindings: hwmon: sensirion,sht15: convert to dtschema

[Rob Herring]

On Tue, 21 Sep 2021 12:28:32 +0200, Krzysztof Kozlowski wrote:
> Convert the Sensirion SHT15 humidity sensor to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../bindings/hwmon/sensirion,sht15.yaml       | 43 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/sht15.txt       | 19 --------
>  2 files changed, 43 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/sht15.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/6] dt-bindings: hwmon: ti,tmp108: convert to dtschema

[Guenter Roeck]

On Tue, Sep 21, 2021 at 12:28:27PM +0200, Krzysztof Kozlowski wrote:
> Convert the TI TMP108 temperature sensor bindings to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ti,tmp108.yaml  | 50 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/tmp108.txt      | 18 -------
>  2 files changed, 50 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/tmp108.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> new file mode 100644
> index 000000000000..eda55bbc172d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp108.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ti,tmp108.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TMP108 temperature sensor
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tmp108
> +
> +  interrupts:
> +    items:
> +      - description: alert interrupt
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@48 {
> +            compatible = "ti,tmp108";
> +            reg = <0x48>;
> +            interrupt-parent = <&gpio1>;
> +            interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> +            pinctrl-names = "default";
> +            pinctrl-0 = <&tmp_alrt>;
> +            #thermal-sensor-cells = <0>;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/hwmon/tmp108.txt b/Documentation/devicetree/bindings/hwmon/tmp108.txt
> deleted file mode 100644
> index 54d4beed4ee5..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/tmp108.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -TMP108 temperature sensor
> --------------------------
> -
> -This device supports I2C only.
> -
> -Requires node properties:
> -- compatible : "ti,tmp108"
> -- reg : the I2C address of the device. This is 0x48, 0x49, 0x4a, or 0x4b.
> -
> -Optional properties:
> -- interrupts: Reference to the TMP108 alert interrupt.
> -- #thermal-sensor-cells: should be set to 0.
> -
> -Example:
> -	tmp108@48 {
> -		compatible = "ti,tmp108";
> -		reg = <0x48>;
> -	};

Re: [PATCH 2/6] dt-bindings: hwmon: ti,tmp102: add bindings and remove from trivial devices

[Guenter Roeck]

On Tue, Sep 21, 2021 at 12:28:28PM +0200, Krzysztof Kozlowski wrote:
> The TI TMP102 temperature sensor does not fit into trivial devices
> bindings due to additional properties.  Add separate bindings for it.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ti,tmp102.yaml  | 47 +++++++++++++++++++
>  .../devicetree/bindings/trivial-devices.yaml  |  2 -
>  2 files changed, 47 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> new file mode 100644
> index 000000000000..d3eff4fac107
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tmp102.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/ti,tmp102.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TMP102 temperature sensor
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tmp102
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@48 {
> +            compatible = "ti,tmp102";
> +            reg = <0x48>;
> +            interrupt-parent = <&gpio7>;
> +            interrupts = <16 IRQ_TYPE_LEVEL_LOW>;
> +            #thermal-sensor-cells = <1>;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index c9333fb81fdf..6ad0628741cf 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -317,8 +317,6 @@ properties:
>              # I2C Touch-Screen Controller
>            - ti,tsc2003
>              # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
> -          - ti,tmp102
> -            # Low Power Digital Temperature Sensor with SMBUS/Two Wire Serial Interface
>            - ti,tmp103
>              # Thermometer with SPI interface
>            - ti,tmp121

Re: [PATCH 4/6] dt-bindings: hwmon: lltc,ltc4151: convert to dtschema

[Guenter Roeck]

On Tue, Sep 21, 2021 at 12:28:30PM +0200, Krzysztof Kozlowski wrote:
> Convert the LTC4151 current and voltage sensor bindings to DT schema
> format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../bindings/hwmon/lltc,ltc4151.yaml          | 41 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/ltc4151.txt     | 18 --------
>  2 files changed, 41 insertions(+), 18 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ltc4151.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml b/Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml
> new file mode 100644
> index 000000000000..4b5851c326f7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/lltc,ltc4151.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/lltc,ltc4151.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LTC4151 High Voltage I2C Current and Voltage Monitor
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> +  compatible:
> +    const: lltc,ltc4151
> +
> +  reg:
> +    maxItems: 1
> +
> +  shunt-resistor-micro-ohms:
> +    description:
> +      Shunt resistor value in micro-Ohms
> +    default: 1000
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        sensor@6e {
> +            compatible = "lltc,ltc4151";
> +            reg = <0x6e>;
> +            shunt-resistor-micro-ohms = <1500>;
> +        };
> +    };
> diff --git a/Documentation/devicetree/bindings/hwmon/ltc4151.txt b/Documentation/devicetree/bindings/hwmon/ltc4151.txt
> deleted file mode 100644
> index d008a5ef525a..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ltc4151.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -LTC4151 High Voltage I2C Current and Voltage Monitor
> -
> -Required properties:
> -- compatible: Must be "lltc,ltc4151"
> -- reg: I2C address
> -
> -Optional properties:
> -- shunt-resistor-micro-ohms
> -	Shunt resistor value in micro-Ohms
> -	Defaults to <1000> if unset.
> -
> -Example:
> -
> -ltc4151@6e {
> -	compatible = "lltc,ltc4151";
> -	reg = <0x6e>;
> -	shunt-resistor-micro-ohms = <1500>;
> -};

Re: [PATCH 5/6] dt-bindings: hwmon: microchip,mcp3021: convert to dtschema

[Guenter Roeck]

On Tue, Sep 21, 2021 at 12:28:31PM +0200, Krzysztof Kozlowski wrote:
> Convert the Microchip MCP3021 ADC bindings to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/mcp3021.txt     | 21 ---------
>  .../bindings/hwmon/microchip,mcp3021.yaml     | 43 +++++++++++++++++++
>  2 files changed, 43 insertions(+), 21 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/mcp3021.txt
>  create mode 100644 Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/mcp3021.txt b/Documentation/devicetree/bindings/hwmon/mcp3021.txt
> deleted file mode 100644
> index 294318ba6914..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/mcp3021.txt
> +++ /dev/null
> @@ -1,21 +0,0 @@
> -mcp3021 properties
> -
> -Required properties:
> -- compatible: Must be one of the following:
> -	- "microchip,mcp3021" for mcp3021
> -	- "microchip,mcp3221" for mcp3221
> -- reg: I2C address
> -
> -Optional properties:
> -
> -- reference-voltage-microvolt
> -	Reference voltage in microvolt (uV)
> -
> -Example:
> -
> -mcp3021@4d {
> -	compatible = "microchip,mcp3021";
> -	reg = <0x4d>;
> -
> -	reference-voltage-microvolt = <4500000>; /* 4.5 V */
> -};
> diff --git a/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml b/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
> new file mode 100644
> index 000000000000..c42051f8a191
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/microchip,mcp3021.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/microchip,mcp3021.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip MCP3021 A/D converter
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - microchip,mcp3021
> +      - microchip,mcp3221
> +
> +  reg:
> +    maxItems: 1
> +
> +  reference-voltage-microvolt:
> +    description:
> +      VDD supply power and reference voltage
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@4d {
> +            compatible = "microchip,mcp3021";
> +            reg = <0x4d>;
> +
> +            reference-voltage-microvolt = <4500000>; /* 4.5 V */
> +        };
> +    };

Re: [PATCH 6/6] dt-bindings: hwmon: sensirion,sht15: convert to dtschema

[Guenter Roeck]

On Tue, Sep 21, 2021 at 12:28:32PM +0200, Krzysztof Kozlowski wrote:
> Convert the Sensirion SHT15 humidity sensor to DT schema format.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Applied.

Thanks,
Guenter

> ---
>  .../bindings/hwmon/sensirion,sht15.yaml       | 43 +++++++++++++++++++
>  .../devicetree/bindings/hwmon/sht15.txt       | 19 --------
>  2 files changed, 43 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/sht15.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml
> new file mode 100644
> index 000000000000..4669217d01e1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht15.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/sensirion,sht15.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SHT15 humidity and temperature sensor
> +
> +maintainers:
> +  - Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> +
> +properties:
> +  compatible:
> +    const: sensirion,sht15
> +
> +  clk-gpios:
> +    maxItems: 1
> +
> +  data-gpios:
> +    maxItems: 1
> +
> +  vcc-supply:
> +    description: regulator that drives the VCC pin
> +
> +required:
> +  - compatible
> +  - clk-gpios
> +  - data-gpios
> +  - vcc-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    sensor {
> +        compatible = "sensirion,sht15";
> +        clk-gpios = <&gpio4 12 0>;
> +        data-gpios = <&gpio4 13 0>;
> +        vcc-supply = <&reg_sht15>;
> +
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_sensor>;
> +    };
> diff --git a/Documentation/devicetree/bindings/hwmon/sht15.txt b/Documentation/devicetree/bindings/hwmon/sht15.txt
> deleted file mode 100644
> index 6a80277cc426..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/sht15.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -Sensirion SHT15 Humidity and Temperature Sensor
> -
> -Required properties:
> -
> - - "compatible": must be "sensirion,sht15".
> - - "data-gpios": GPIO connected to the data line.
> - - "clk-gpios": GPIO connected to the clock line.
> - - "vcc-supply": regulator that drives the VCC pin.
> -
> -Example:
> -
> -	sensor {
> -		pinctrl-names = "default";
> -		pinctrl-0 = <&pinctrl_sensor>;
> -		compatible = "sensirion,sht15";
> -		clk-gpios = <&gpio4 12 0>;
> -		data-gpios = <&gpio4 13 0>;
> -		vcc-supply = <&reg_sht15>;
> -	};

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Rob Herring]

On Tue, 21 Sep 2021 12:28:29 +0200, Krzysztof Kozlowski wrote:
> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
> trivial, so they can be integrated into trivial devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  .../devicetree/bindings/hwmon/ibm,cffps1.txt  | 26 -------------------
>  .../devicetree/bindings/trivial-devices.yaml  |  6 +++++
>  MAINTAINERS                                   |  1 -
>  3 files changed, 6 insertions(+), 27 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 3/6] dt-bindings: hwmon: ibm,cffps: move to trivial devices

[Guenter Roeck]

On Tue, Sep 21, 2021 at 12:28:29PM +0200, Krzysztof Kozlowski wrote:
> The IBM Common Form Factor Power Supply Versions 1 and 2 bindings are
> trivial, so they can be integrated into trivial devices bindings.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Following Rob's suggestion:

"... I'd much rather have a schema for these than wait on 
someone to decide to convert them. That could mean a device.txt -> 
trivial-devices.yaml -> device.yaml trip, but that doesn't seem that 
terrible to me. Then we at least are running schema checks on the 
devices and know if actual users have more undocumented properties."

Applied.

Thanks,
Guenter

> ---
>  .../devicetree/bindings/hwmon/ibm,cffps1.txt  | 26 -------------------
>  .../devicetree/bindings/trivial-devices.yaml  |  6 +++++
>  MAINTAINERS                                   |  1 -
>  3 files changed, 6 insertions(+), 27 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt b/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> deleted file mode 100644
> index d9a2719f9243..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -Device-tree bindings for IBM Common Form Factor Power Supply Versions 1 and 2
> ------------------------------------------------------------------------------
> -
> -Required properties:
> - - compatible				: Must be one of the following:
> -						"ibm,cffps1"
> -						"ibm,cffps2"
> -						or "ibm,cffps" if the system
> -						must support any version of the
> -						power supply
> - - reg = < I2C bus address >;		: Address of the power supply on the
> -					  I2C bus.
> -
> -Example:
> -
> -    i2c-bus@100 {
> -        #address-cells = <1>;
> -        #size-cells = <0>;
> -        #interrupt-cells = <1>;
> -        < more properties >
> -
> -        power-supply@68 {
> -            compatible = "ibm,cffps1";
> -            reg = <0x68>;
> -        };
> -    };
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 6ad0628741cf..791079021f1b 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -113,6 +113,12 @@ properties:
>            - mps,mp2975
>              # Honeywell Humidicon HIH-6130 humidity/temperature sensor
>            - honeywell,hi6130
> +            # IBM Common Form Factor Power Supply Versions (all versions)
> +          - ibm,cffps
> +            # IBM Common Form Factor Power Supply Versions 1
> +          - ibm,cffps1
> +            # IBM Common Form Factor Power Supply Versions 2
> +          - ibm,cffps2
>              # Infineon IR36021 digital POL buck controller
>            - infineon,ir36021
>              # Infineon IR38064 Voltage Regulator
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 15c4d3c809e8..cc5df54bdc51 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14956,7 +14956,6 @@ S:	Maintained
>  W:	http://hwmon.wiki.kernel.org/
>  W:	http://www.roeck-us.net/linux/drivers/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> -F:	Documentation/devicetree/bindings/hwmon/ibm,cffps1.txt
>  F:	Documentation/devicetree/bindings/hwmon/ltc2978.txt
>  F:	Documentation/devicetree/bindings/hwmon/max31785.txt
>  F:	Documentation/hwmon/adm1275.rst