From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14E52C4332F for ; Tue, 21 Sep 2021 19:01:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED1D0611CE for ; Tue, 21 Sep 2021 19:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233932AbhIUTCq (ORCPT ); Tue, 21 Sep 2021 15:02:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233905AbhIUTCn (ORCPT ); Tue, 21 Sep 2021 15:02:43 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13171C061574 for ; Tue, 21 Sep 2021 12:01:15 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id g14so463206pfm.1 for ; Tue, 21 Sep 2021 12:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uUvwtgDvS9z+MmLCsIbndyuppV43gHnzlz5qvL6KeNg=; b=c9uP+rap/UfN7fREE6h8u3lsZij8/9nesp5oAq6rWx9xNnYvzMF9PP463fCmsUqDar kEwNNzzupFjl3iVssQImb8bF3h2/B/8MlMGNIDKsuMe9bchBPSyFkLc+uuhUiy9QTIMI 6UVxssDsqkegyngHCgoDjyvtGGXIsR18yy7Rg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uUvwtgDvS9z+MmLCsIbndyuppV43gHnzlz5qvL6KeNg=; b=qbBTzHf18+G+9jpELCDkhYUN/tKmgDKIXIla3ElUbD41LgirLENzHvzqp2/2uMYqJC BKLNJhnJs1AW/nnWWfD6S5DRss6v+IDr9NOLJ/z/+497xfxQWNI1+U7xXl5GAO3Yy04D Ip+vhcH2Txawj0q8HVr2vDNZRnZUdXL7WwRuOZmQPxcl9BBS1L77b0i+Xr/As4unGsbs EVZyCn7wXYaz6EbHhkRwpv0KPJW0ujk1qgm5aVoI11yA8lrl4ob8QGK2GCo6g6ZfZ8Qs NfRq3dA29mKGkESOVaKo0+1ijlXGSW/BF9lrd+L0NUVfijhWlRwrIr1kGfcHeFo4JjNE 7R8g== X-Gm-Message-State: AOAM530NZGB+73oM7V6Kg6cK1FHNPI15EuLe9QgI7uwhikbNfOokMNdC GGufFUC4NwCeB8MRmugJ2asNWQ== X-Google-Smtp-Source: ABdhPJyhkEtFnUnBg+9qtMK4KmQYa6j/evLKD74iespv+jzZ07EoQOA7rlY7bUrm0t6g+7REwX8YJw== X-Received: by 2002:a63:2cce:: with SMTP id s197mr3869655pgs.45.1632250874538; Tue, 21 Sep 2021 12:01:14 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t6sm3451285pjr.36.2021.09.21.12.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 12:01:13 -0700 (PDT) Date: Tue, 21 Sep 2021 12:01:12 -0700 From: Kees Cook To: Stephen Kitt Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , James Morris , "Serge E . Hallyn" , linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK Message-ID: <202109211200.14E421C@keescook> References: <20210921061149.1091163-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210921061149.1091163-1-steve@sk2.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 08:11:49AM +0200, Stephen Kitt wrote: > This has served its purpose and is no longer used. All usercopy > violations appear to have been handled by now, any remaining > instances (or new bugs) will cause copies to be rejected. > > This isn't a direct revert of commit 2d891fbc3bb6 ("usercopy: Allow > strict enforcement of whitelists"); since usercopy_fallback is > effectively 0, the fallback handling is removed too. > > This also removes the usercopy_fallback module parameter on > slab_common. > > Link: https://github.com/KSPP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook Thanks for doing this! Acked-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0EF8C433F5 for ; Tue, 21 Sep 2021 19:02:03 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9DB61038 for ; Tue, 21 Sep 2021 19:02:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EA9DB61038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HDW4n2WK8z2ypW for ; Wed, 22 Sep 2021 05:02:01 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=c9uP+rap; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=chromium.org (client-ip=2607:f8b0:4864:20::429; helo=mail-pf1-x429.google.com; envelope-from=keescook@chromium.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=c9uP+rap; dkim-atps=neutral Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HDW410MyFz2xYN for ; Wed, 22 Sep 2021 05:01:18 +1000 (AEST) Received: by mail-pf1-x429.google.com with SMTP id 145so387806pfz.11 for ; Tue, 21 Sep 2021 12:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uUvwtgDvS9z+MmLCsIbndyuppV43gHnzlz5qvL6KeNg=; b=c9uP+rap/UfN7fREE6h8u3lsZij8/9nesp5oAq6rWx9xNnYvzMF9PP463fCmsUqDar kEwNNzzupFjl3iVssQImb8bF3h2/B/8MlMGNIDKsuMe9bchBPSyFkLc+uuhUiy9QTIMI 6UVxssDsqkegyngHCgoDjyvtGGXIsR18yy7Rg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uUvwtgDvS9z+MmLCsIbndyuppV43gHnzlz5qvL6KeNg=; b=acMSgLwFnqV7/f1CBz0hojO+BVMDIjG+uQVvGU1YccSRN2xB1Cd/d03M5IUXqkuFRG iNeM64Ga7D/yKBKkaw4SMPWNizEqSz+Zz4o22V39JwJ63+0bqLtlA1EzJdvQMVBMMPSY E4VqNGpF84iqfjstx+C3x2Ld+4Fk0QV5YBLeYfRAKVo15KhEohGrTeDYzOVIy5W10U7B sgKWyptpeWcg1Fq0deOwkLnmIDWLOK/UtwHM4wIicUQkNMmTVjixa0+QLgzjM+XOB52J DwkII0PkDrBfbOtyCPunLQaNkLsBHT5Y+crvtVKOFJagYlZ9dSdsvDEevLWwuNGfS9Vi 4BlA== X-Gm-Message-State: AOAM531y3DZTUGrNYc0EmukRNhh2j11ats5C7ksZf58V2FILbY1G7mTv i/LPikR5XWyK8Xlgc5XuLMM+EA== X-Google-Smtp-Source: ABdhPJyhkEtFnUnBg+9qtMK4KmQYa6j/evLKD74iespv+jzZ07EoQOA7rlY7bUrm0t6g+7REwX8YJw== X-Received: by 2002:a63:2cce:: with SMTP id s197mr3869655pgs.45.1632250874538; Tue, 21 Sep 2021 12:01:14 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t6sm3451285pjr.36.2021.09.21.12.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 12:01:13 -0700 (PDT) Date: Tue, 21 Sep 2021 12:01:12 -0700 From: Kees Cook To: Stephen Kitt Subject: Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK Message-ID: <202109211200.14E421C@keescook> References: <20210921061149.1091163-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210921061149.1091163-1-steve@sk2.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Morton , James Morris , linux-kernel@vger.kernel.org, Pekka Enberg , linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-hardening@vger.kernel.org, David Rientjes , Christoph Lameter , linuxppc-dev@lists.ozlabs.org, Joonsoo Kim , Vlastimil Babka , "Serge E . Hallyn" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Sep 21, 2021 at 08:11:49AM +0200, Stephen Kitt wrote: > This has served its purpose and is no longer used. All usercopy > violations appear to have been handled by now, any remaining > instances (or new bugs) will cause copies to be rejected. > > This isn't a direct revert of commit 2d891fbc3bb6 ("usercopy: Allow > strict enforcement of whitelists"); since usercopy_fallback is > effectively 0, the fallback handling is removed too. > > This also removes the usercopy_fallback module parameter on > slab_common. > > Link: https://github.com/KSPP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook Thanks for doing this! Acked-by: Kees Cook -- Kees Cook