From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA005C433F5 for ; Tue, 21 Sep 2021 14:44:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E03EA60EC0 for ; Tue, 21 Sep 2021 14:44:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E03EA60EC0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6915C83260; Tue, 21 Sep 2021 16:43:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="KyMQsmwj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7B34683278; Tue, 21 Sep 2021 16:43:57 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 33A5B8035E for ; Tue, 21 Sep 2021 16:43:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id b65so4576216qkc.13 for ; Tue, 21 Sep 2021 07:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=V0GXzO8ioRr37pJwZUo+upfduih+mEhlUPRO51mLN/k=; b=KyMQsmwjXIUJXrryoLDkoTWDoL5xC8m5jrcHtuWMZSPZvo5LkcuySG7uW8t1az5zUy ij/CVajpkMsrKQ4GhHkpwWqmPNYf/ypV4zStCLz5NPhfRl9OtL1axi1cZduHaAXCAuI0 EjZUdu8xCPX8juOQWAuFUhe+nt2ZLTdel62LA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=V0GXzO8ioRr37pJwZUo+upfduih+mEhlUPRO51mLN/k=; b=e3et/P3JO9S/ciQ+Q/2s37KXl1bUxXzzgoeGNgH0mzgRCJVqJ7mNo2jS4kWcmxAUJy 5wCpWDmDlbpzC8VYBGKQXf4SPlabo67PW0iNS2CiZPzvZgROsyLqwCBeVL7+H9m6CWDv axyLrJYZMb5uPl2CiJ/I93kU5Je/bM/BHrdaqvupiiNDHuBesKSBN1BeWTL+m5xOlDWR ciHFYF9mgeh02O6ttmu9eucKNtC+4w1dlHS2uvv8BbezOov6nxBds/aJpmum/ECLCeqy 1TpXxJhCjUzJUWcfBgXRiki9VLIqGL3XO3aHcT1hBPI1uzwduDG/6P95qPFGtRZS8BaA B+Vw== X-Gm-Message-State: AOAM5304KA6SHPvBVSKWqrqliGPa4Prx8KmJAQJvNweXeTwK9zx1FuZk rz/fhqsKidASCk12sN6sI6k6yQ== X-Google-Smtp-Source: ABdhPJzeO7LtTg/GkwOnZr3+xhHaM6V/ubE9NDbTfRUMB8U+XgmTSTYJTGn+RNK0KFS0Tbu7yJto4Q== X-Received: by 2002:a37:9a12:: with SMTP id c18mr21778810qke.218.1632235432102; Tue, 21 Sep 2021 07:43:52 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-24fc-d77e-8558-6741.res6.spectrum.com. [2603:6081:7b01:cbda:24fc:d77e:8558:6741]) by smtp.gmail.com with ESMTPSA id w20sm11246721qtj.72.2021.09.21.07.43.50 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Sep 2021 07:43:51 -0700 (PDT) Date: Tue, 21 Sep 2021 10:43:49 -0400 From: Tom Rini To: Wasim Khan Cc: priyanka.jain@nxp.com, v.sethi@nxp.com, u-boot@lists.denx.de, Wasim Khan Subject: Re: [PATCH] board/freescale/vid : move platform specific definitions Message-ID: <20210921144349.GF8579@bill-the-cat> References: <20210921142457.3485758-1-wasim.khan@oss.nxp.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9QtXyXGM8HCrXlir" Content-Disposition: inline In-Reply-To: <20210921142457.3485758-1-wasim.khan@oss.nxp.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --9QtXyXGM8HCrXlir Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 21, 2021 at 04:24:57PM +0200, Wasim Khan wrote: > From: Wasim Khan >=20 > VID is a common driver. Move platform specific definitions > to platform specific header files >=20 > Signed-off-by: Wasim Khan > --- > board/freescale/common/vid.h | 10 ---------- > include/configs/lx2160a_common.h | 7 +++++++ > 2 files changed, 7 insertions(+), 10 deletions(-) NAK. Things need to move out of include/configs/ and not in to them, please find another common header file to use. --=20 Tom --9QtXyXGM8HCrXlir Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFJ76IACgkQFHw5/5Y0 tywDZAv9FHM6o8KOyJOYyzg70K0HZXMu+ZRlc9FxD6x2dtaYZO4BNwFoPKrVLE0J YO4FyQnQUW8pQkJdw7Hu7s6eSC3adY/Z4O0x/xD3OhlV4ggOLkGTqJrLlHM12wih nZhYkmp0qSOQPnNzaJnwjUr+DSOmhD5aDEfWyTnGRzhVqOkv5lgX+i8GE8MUqFVZ J6ZtZ8uIUOanZ8s5AgCwntdnEs+wDBN/hTD9E/Xe1kSWANhBLL5FFATseqPm8FvI I3RNH/e9dyCrZoLq/InFB3c1M2AaFSdD6Ro8CZ1Dx8lTUsC0wmWh9gCyRE6nMjvT JfbIDkDQSN+WjxEfwalTlAELt1XdzmG0/zRSXIaO+KSq+IOlcKZ97I1CBShfwIzQ Q4vpFDGsrmkKSKA55A5y+dmZQdDlbrv2DuhRi+5mDRfGu4EyB6QBuYdZz/U0A6Dg uqGWXGB+voDWbBcG2PuhJ9m6Xywyu/xEcD3O20ZUpEfjDeiRIFkT9mkGhKu/odPp ZVKpilSa =tE65 -----END PGP SIGNATURE----- --9QtXyXGM8HCrXlir--