From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA6FC433EF for ; Tue, 21 Sep 2021 18:39:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CECDB61184 for ; Tue, 21 Sep 2021 18:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CECDB61184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B33CD832BE; Tue, 21 Sep 2021 20:39:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="U0MhowPB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7FA2F83124; Tue, 21 Sep 2021 20:39:14 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C5333832BE for ; Tue, 21 Sep 2021 20:39:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id x9so279177qtv.0 for ; Tue, 21 Sep 2021 11:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ytVTv1R1YAoodDepAHb3X6XkYeOiEJxlB2DbxZWyg9o=; b=U0MhowPB198KZVLudTXEqNsiYtC/1pyDli92MnLDdRu8bRbADnSFbQZhl+lB99CxU1 OnhoUZm6x6fCIh9WmapYrABobQw4KHPwfCXuheWOvhIGFTAEauWzeoPBKugbMqd9Og82 KtXX9a7EVr+IRwXyzJLiXcyt3TEt4xRPiigLo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ytVTv1R1YAoodDepAHb3X6XkYeOiEJxlB2DbxZWyg9o=; b=WjelPXvkz21gwKTkxjGCG5bNxWEv3BPRU0o7u1M7qoVC06yl7BwwYMI7HiRs2Eu+dH HNzkvqLwr0brP+syBQuA7pwyYh0Ed6G2PT+AH6bE1lAwHoAV5v0rusUCvdL3TRQKk/ZU nrAuVPspDYK5VOGv/Fv7cr1vmiyk4hCzEchr8c12WKxmvGRgu9B5sllHo5SwD9fubKMD drJtA4Rg0ECOV9EIck41yLgCWrv0xlb+blNYhSqjYFTPMPFP8DNwOmt1ynDkVTH8ublK HVKl3GSAapy8gUOTOSeYMIJH+mWh2HLNM6whWrIfq1AkRIROW0CyGpo/0LxTpjF//6in liMw== X-Gm-Message-State: AOAM5327mpsE9MEDo3VLklxHE7xKbNpqTNVj0Dw5QVb745c3tTtXtLIh tsiFsLtTfBvLTApyyekB2M7unQ== X-Google-Smtp-Source: ABdhPJxQnL0oWTBrYbjR+Gm/V0kJckOXqbMRzxBWCXT61XrNzVRNxhqfLfBaQnDRmfXo0Tgvrz/FlQ== X-Received: by 2002:a05:622a:1aaa:: with SMTP id s42mr29731766qtc.122.1632249547974; Tue, 21 Sep 2021 11:39:07 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-24fc-d77e-8558-6741.res6.spectrum.com. [2603:6081:7b01:cbda:24fc:d77e:8558:6741]) by smtp.gmail.com with ESMTPSA id 66sm2371410qke.118.2021.09.21.11.39.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 21 Sep 2021 11:39:07 -0700 (PDT) Date: Tue, 21 Sep 2021 14:39:05 -0400 From: Tom Rini To: Patrick Delaunay Cc: u-boot@lists.denx.de, Bin Meng , Heinrich Schuchardt , Priyanka Jain , Rick Chen , Simon Glass , Stefan Roese , U-Boot STM32 Subject: Re: [PATCH] configs: Migrate CONFIG_ST_SMI to Kconfig Message-ID: <20210921183905.GI8579@bill-the-cat> References: <20210921183600.1.I82d7f080bc204e75e2f305a8056363038d3d9c0d@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="leQ0ainWKcxhm+Q3" Content-Disposition: inline In-Reply-To: <20210921183600.1.I82d7f080bc204e75e2f305a8056363038d3d9c0d@changeid> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --leQ0ainWKcxhm+Q3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 21, 2021 at 06:36:03PM +0200, Patrick Delaunay wrote: > Use moveconfig.py script to convert the define CONFIG_ST_SMI to Kconfig > and move this entries to defconfigs. >=20 > Before migration, the st_smi.c driver was empty when CONFIG_MTD_NOR_FLASH > wasn't activated; it is now managed in Kconfig by the "depends on" and > this driver is not compiled. >=20 > After this patch, the driver st_smic.c is no more used in U-Boot; > it was only used in SPEAr products before commit 570c3dcfc153 ("arm: > Remove spear600 boards and the rest of SPEAr support"). >=20 > Signed-off-by: Patrick Delaunay > --- > In the first migration process (without depends on) the config > CONFIG_ST_SMI was added in bcm7445_defconfig and bcm7260_defconfig. >=20 > But after adding the "depends on MTD_NOR_FLASH" and a Rsync all defconfig > files using moveconfig.py the CONFIG_ST_SMI is also deactivated in these > 2 last users: > - bcm7260_defconfig > - bcm7445_defconfig >=20 > The U-Boot size don't change for these 2 defconfig (tested with buildman). Thanks for doing a migration. But, since you've found this is dead code now, it would make more sense to just delete the driver. --=20 Tom --leQ0ainWKcxhm+Q3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmFKJsIACgkQFHw5/5Y0 tyy3RQv8D+eJIVihB/JKxjatWhw0XOWRExPt93fSA4Cv9HPr7zZDHh9N1jprhj7T xSTYLGzAB3nMn3iWcqRD0GlrnyJCQZQucR0dODvs7jylehr66y6uiwZERHlJLpT+ Pw4JU+5IT0XEzVSXYpcZXyJ0zOYNaVim6oMx+4so1/yiEU6L67PLb3lksAqzUt4J HZBWt5pOboU0pVhzneEYQmE7wraxSoY9La/eMKe0421N0t1OuxUoTTUOJjjWJ5Av /dRRyHz+aem7gXY8iEI6PE2Rbi3uiKqcapZNm6kS07JsQv0xCY+leKlwkoex0bts YQpVyncBUx//8u85p3xyZh27ahwYAyJTd16J0xvJn2C8ZrXE/tNaqBBSd4eJMsIy 9EGa+w3LgL/PrYHDXe72i3A+KgRG3LJirhS5FWg5LWfoBAR3F9/nWVpiuMFdbRHJ yJQVP6qAdRLc9H1BO4bTNVbYG9biebIVEwFFNJMxEoU0THn2NP2UZ9KwfLWmBSgm wVdktnIo =nrWw -----END PGP SIGNATURE----- --leQ0ainWKcxhm+Q3--