From: Dave Chinner <email@example.com> To: Mel Gorman <firstname.lastname@example.org> Cc: Linux-MM <email@example.com>, NeilBrown <firstname.lastname@example.org>, Theodore Ts'o <email@example.com>, Andreas Dilger <firstname.lastname@example.org>, "Darrick J . Wong" <email@example.com>, Matthew Wilcox <firstname.lastname@example.org>, Michal Hocko <email@example.com>, Rik van Riel <firstname.lastname@example.org>, Vlastimil Babka <email@example.com>, Johannes Weiner <firstname.lastname@example.org>, Jonathan Corbet <email@example.com>, Linux-fsdevel <firstname.lastname@example.org>, LKML <email@example.com> Subject: Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ Date: Wed, 22 Sep 2021 06:46:21 +1000 [thread overview] Message-ID: <20210921204621.GY2361455@dread.disaster.area> (raw) In-Reply-To: <firstname.lastname@example.org> On Mon, Sep 20, 2021 at 09:54:31AM +0100, Mel Gorman wrote: > Cc list similar to "congestion_wait() and GFP_NOFAIL" as they're loosely > related. > > This is a prototype series that removes all calls to congestion_wait > in mm/ and deletes wait_iff_congested. It's not a clever > implementation but congestion_wait has been broken for a long time > (https://email@example.com/). > Even if it worked, it was never a great idea. While excessive > dirty/writeback pages at the tail of the LRU is one possibility that > reclaim may be slow, there is also the problem of too many pages being > isolated and reclaim failing for other reasons (elevated references, > too many pages isolated, excessive LRU contention etc). > > This series replaces the reclaim conditions with event driven ones > > o If there are too many dirty/writeback pages, sleep until a timeout > or enough pages get cleaned > o If too many pages are isolated, sleep until enough isolated pages > are either reclaimed or put back on the LRU > o If no progress is being made, let direct reclaim tasks sleep until > another task makes progress > > This has been lightly tested only and the testing was useless as the > relevant code was not executed. The workload configurations I had that > used to trigger these corner cases no longer work (yey?) and I'll need > to implement a new synthetic workload. If someone is aware of a realistic > workload that forces reclaim activity to the point where reclaim stalls > then kindly share the details. Got a git tree pointer so I can pull it into a test kernel so I can see what impact it has on behaviour before I try to make sense of the code? Cheers, Dave. -- Dave Chinner firstname.lastname@example.org
next prev parent reply other threads:[~2021-09-21 20:46 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-20 8:54 Mel Gorman 2021-09-20 8:54 ` [PATCH 1/5] mm/vmscan: Throttle reclaim until some writeback completes if congested Mel Gorman 2021-09-20 23:19 ` NeilBrown 2021-09-21 11:12 ` Mel Gorman 2021-09-21 21:27 ` NeilBrown 2021-09-21 0:13 ` NeilBrown 2021-09-21 10:58 ` Mel Gorman 2021-09-21 21:40 ` NeilBrown 2021-09-22 6:04 ` Dave Chinner 2021-09-22 8:03 ` Mel Gorman 2021-09-22 12:16 ` Hillf Danton 2021-09-22 14:13 ` Mel Gorman 2021-09-20 8:54 ` [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated Mel Gorman 2021-09-20 23:27 ` NeilBrown 2021-09-21 11:03 ` Mel Gorman 2021-09-21 18:45 ` Yang Shi 2021-09-21 18:45 ` Yang Shi 2021-09-22 8:11 ` Mel Gorman 2021-09-20 8:54 ` [PATCH 3/5] mm/vmscan: Throttle reclaim when no progress is being made Mel Gorman 2021-09-20 23:31 ` NeilBrown 2021-09-21 11:16 ` Mel Gorman 2021-09-21 21:46 ` NeilBrown 2021-09-22 9:21 ` Mel Gorman 2021-09-20 8:54 ` [PATCH 4/5] mm/writeback: Throttle based on page writeback instead of congestion Mel Gorman 2021-09-20 8:54 ` [PATCH 5/5] mm/page_alloc: Remove the throttling logic from the page allocator Mel Gorman 2021-09-20 11:42 ` [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/ Matthew Wilcox 2021-09-20 12:50 ` Mel Gorman 2021-09-20 14:11 ` David Sterba 2021-09-21 11:18 ` Mel Gorman 2021-09-20 19:51 ` Mel Gorman 2021-09-21 20:46 ` Dave Chinner [this message] 2021-09-22 17:52 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210921204621.GY2361455@dread.disaster.area \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [RFC PATCH 0/5] Remove dependency on congestion_wait in mm/' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.