From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,
david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru,
ferruh.yigit@intel.com, michaelba@nvidia.com,
viacheslavo@nvidia.com, xiaoyun.li@intel.com
Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com, yvugenfi@redhat.com,
ybendito@redhat.com, Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: [dpdk-dev] [PATCH v2 4/5] net/mlx5: fix RSS RETA update
Date: Wed, 22 Sep 2021 11:57:41 +0200 [thread overview]
Message-ID: <20210922095742.229262-5-maxime.coquelin@redhat.com> (raw)
In-Reply-To: <20210922095742.229262-1-maxime.coquelin@redhat.com>
This patch fixes RETA updating for entries above 64.
Without ithat, these entries are never updated as
calculated mask value will always be 0.
Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update")
Cc: stable@dpdk.org
Cc: nelio.laranjeiro@6wind.com
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/drivers/net/mlx5/mlx5_rss.c b/drivers/net/mlx5/mlx5_rss.c
index c32129cdc2..6dc52acee0 100644
--- a/drivers/net/mlx5/mlx5_rss.c
+++ b/drivers/net/mlx5/mlx5_rss.c
@@ -211,7 +211,7 @@ mlx5_dev_rss_reta_update(struct rte_eth_dev *dev,
for (idx = 0, i = 0; (i != reta_size); ++i) {
idx = i / RTE_RETA_GROUP_SIZE;
pos = i % RTE_RETA_GROUP_SIZE;
- if (((reta_conf[idx].mask >> i) & 0x1) == 0)
+ if (((reta_conf[idx].mask >> pos) & 0x1) == 0)
continue;
MLX5_ASSERT(reta_conf[idx].reta[pos] < priv->rxqs_n);
(*priv->reta_idx)[i] = reta_conf[idx].reta[pos];
--
2.31.1
next prev parent reply other threads:[~2021-09-22 10:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:57 [dpdk-dev] [PATCH v2 0/5] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support Maxime Coquelin
2021-09-22 11:20 ` Andrew Rybchenko
2021-09-22 12:28 ` Maxime Coquelin
2021-09-23 7:35 ` Xia, Chenbo
2021-09-29 9:02 ` Maxime Coquelin
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: fix RSS key length Maxime Coquelin
2021-09-22 11:25 ` Li, Xiaoyun
2021-09-23 7:52 ` Xia, Chenbo
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: fix RSS type display Maxime Coquelin
2021-09-22 12:01 ` Li, Xiaoyun
2021-09-23 7:59 ` Xia, Chenbo
2021-09-22 9:57 ` Maxime Coquelin [this message]
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info Maxime Coquelin
2021-09-22 11:31 ` Li, Xiaoyun
2021-09-29 7:27 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922095742.229262-5-maxime.coquelin@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=amorenoz@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=michaelba@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=ybendito@redhat.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.