From: Ben Hutchings <ben.hutchings@essensium.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH libgpiod-v2] gpioinfo: Show edge detection and debounce period if enabled
Date: Wed, 22 Sep 2021 13:49:25 +0200 [thread overview]
Message-ID: <20210922114924.GA24226@cephalopod> (raw)
In-Reply-To: <CAMRc=Me_UsY8b2wJx3CopJ2eX1Qb=fdSRqq_sRyR2vGXVULTbg@mail.gmail.com>
On Mon, Sep 20, 2021 at 03:52:17PM +0200, Bartosz Golaszewski wrote:
> On Thu, Jul 29, 2021 at 1:46 AM Ben Hutchings <ben.hutchings@mind.be> wrote:
[...]
> > @@ -166,6 +196,9 @@ static void list_lines(struct gpiod_chip *chip)
> > prinfo(&of, 13, "%s ",
> > active_low ? "active-low" : "active-high");
> >
> > + if (debounce_period)
> > + printf("debounce=%lu ", debounce_period);
>
> You should use prinfo here for formatting. But it would be even better
> if this became a flag - like the bias, drive etc settings and be shown
> inside the [] brackets at the end of the line - something like:
> "[pull-up, used, debounce-period=1000us]".
[...]
Well it's not a flag; it's an attribute with a value. But if you
think it should be grouped with the flags anyway, I can do that.
Ben.
--
Ben Hutchings · Senior Embedded Software Engineer, Essensium-Mind · mind.be
next prev parent reply other threads:[~2021-09-22 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 23:46 [PATCH libgpiod-v2] gpioinfo: Show edge detection and debounce period if enabled Ben Hutchings
2021-09-20 13:52 ` Bartosz Golaszewski
2021-09-22 11:49 ` Ben Hutchings [this message]
2021-09-22 12:59 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922114924.GA24226@cephalopod \
--to=ben.hutchings@essensium.com \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.