All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/i915/gem_cs_tlb: Drop gem_require_ring() check
Date: Wed, 22 Sep 2021 16:03:44 -0700	[thread overview]
Message-ID: <20210922230344.41384-1-ashutosh.dixit@intel.com> (raw)

80f48722f429 ("tests/i915/gem_cs_tlb: Convert to intel_ctx_t") passes a
intel_ctx_t (initialized with intel_ctx_create_all_physical()) into
run_on_ring(). However gem_require_ring() checks if the ring is available
to context 0, not the intel_ctx_t which is passed in. This will cause the
test to skip for all engines not available to context 0. Hence drop the
gem_require_ring() check since we already know that the intel_ctx_t has all
physical engines available to it.

Cc: "Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>"
Fixes: 80f48722f429 ("tests/i915/gem_cs_tlb: Convert to intel_ctx_t")
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/i915/gem_cs_tlb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/i915/gem_cs_tlb.c b/tests/i915/gem_cs_tlb.c
index 7a88866501c..2117b41e47c 100644
--- a/tests/i915/gem_cs_tlb.c
+++ b/tests/i915/gem_cs_tlb.c
@@ -102,7 +102,6 @@ static void run_on_ring(int fd, const intel_ctx_t *ctx,
 	} obj[2];
 	unsigned i;
 
-	gem_require_ring(fd, ring_id);
 	igt_require(has_softpin(fd));
 
 	for (i = 0; i < 2; i++) {
-- 
2.33.0

             reply	other threads:[~2021-09-22 23:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 23:03 Ashutosh Dixit [this message]
2021-09-23  0:01 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/i915/gem_cs_tlb: Drop gem_require_ring() check Patchwork
2021-09-23  2:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-09-27  4:01 ` [igt-dev] [PATCH i-g-t] " Melkaveri, Arjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210922230344.41384-1-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.