From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C9DC4332F for ; Thu, 23 Sep 2021 09:16:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B241461107 for ; Thu, 23 Sep 2021 09:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239959AbhIWJSZ (ORCPT ); Thu, 23 Sep 2021 05:18:25 -0400 Received: from foss.arm.com ([217.140.110.172]:59458 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238189AbhIWJSY (ORCPT ); Thu, 23 Sep 2021 05:18:24 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B570106F; Thu, 23 Sep 2021 02:16:53 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB0D13F59C; Thu, 23 Sep 2021 02:16:50 -0700 (PDT) Date: Thu, 23 Sep 2021 10:16:44 +0100 From: Lorenzo Pieralisi To: Jia He Cc: Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Ard Biesheuvel , Len Brown , Robert Moore , Erik Kaneda , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, Jeremy Linton , Hanjun Guo , "Rafael J . Wysocki" , Harb Abdulhamid Subject: Re: [PATCH v3] Revert "ACPI: Add memory semantics to acpi_os_map_memory()" Message-ID: <20210923091644.GA5882@lpieralisi> References: <20210923033557.19100-1-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210923033557.19100-1-justin.he@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Sep 23, 2021 at 11:35:57AM +0800, Jia He wrote: > This reverts commit 437b38c51162f8b87beb28a833c4d5dc85fa864e. > > The memory semantics added in commit 437b38c51162 causes SystemMemory > Operation region, whose address range is not described in the EFI memory > map to be mapped as NormalNC memory on arm64 platforms (through > acpi_os_map_memory() in acpi_ex_system_memory_space_handler()). > > This triggers the following abort on an ARM64 Ampere eMAG machine, > because presumably the physical address range area backing the Opregion > does not support NormalNC memory attributes driven on the bus. > > Internal error: synchronous external abort: 96000410 [#1] SMP > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0+ #462 > Hardware name: MiTAC RAPTOR EV-883832-X3-0001/RAPTOR, BIOS 0.14 02/22/2019 > pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [...snip...] > Call trace: > acpi_ex_system_memory_space_handler+0x26c/0x2c8 > acpi_ev_address_space_dispatch+0x228/0x2c4 > acpi_ex_access_region+0x114/0x268 > acpi_ex_field_datum_io+0x128/0x1b8 > acpi_ex_extract_from_field+0x14c/0x2ac > acpi_ex_read_data_from_field+0x190/0x1b8 > acpi_ex_resolve_node_to_value+0x1ec/0x288 > acpi_ex_resolve_to_value+0x250/0x274 > acpi_ds_evaluate_name_path+0xac/0x124 > acpi_ds_exec_end_op+0x90/0x410 > acpi_ps_parse_loop+0x4ac/0x5d8 > acpi_ps_parse_aml+0xe0/0x2c8 > acpi_ps_execute_method+0x19c/0x1ac > acpi_ns_evaluate+0x1f8/0x26c > acpi_ns_init_one_device+0x104/0x140 > acpi_ns_walk_namespace+0x158/0x1d0 > acpi_ns_initialize_devices+0x194/0x218 > acpi_initialize_objects+0x48/0x50 > acpi_init+0xe0/0x498 > > If the Opregion address range is not present in the EFI memory map there > is no way for us to determine the memory attributes to use to map it - > defaulting to NormalNC does not work (and it is not correct on a memory > region that may have read side-effects) and therefore commit > 437b38c51162 should be reverted, which means reverting back to the > original behavior whereby address ranges that are mapped using > acpi_os_map_memory() default to the safe devicenGnRnE attributes on > ARM64 if the mapped address range is not defined in the EFI memory map. > > Fixes: 437b38c51162 ("ACPI: Add memory semantics to acpi_os_map_memory()") > Signed-off-by: Jia He > Cc: Lorenzo Pieralisi > Cc: Ard Biesheuvel > Cc: Hanjun Guo > Cc: Catalin Marinas > Cc: Rafael J. Wysocki > Cc: Harb Abdulhamid > --- > V3: refine the commit log which came from Lorenzo Pieralisi > > arch/arm64/include/asm/acpi.h | 3 --- > arch/arm64/kernel/acpi.c | 19 +++---------------- > drivers/acpi/osl.c | 23 +++++++---------------- > include/acpi/acpi_io.h | 8 -------- > 4 files changed, 10 insertions(+), 43 deletions(-) Acked-by: Lorenzo Pieralisi Rafael if possible please apply it, thank you very much. > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > index 7535dc7cc5aa..bd68e1b7f29f 100644 > --- a/arch/arm64/include/asm/acpi.h > +++ b/arch/arm64/include/asm/acpi.h > @@ -50,9 +50,6 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); > void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size); > #define acpi_os_ioremap acpi_os_ioremap > > -void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size); > -#define acpi_os_memmap acpi_os_memmap > - > typedef u64 phys_cpuid_t; > #define PHYS_CPUID_INVALID INVALID_HWID > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > index 1c9c2f7a1c04..f3851724fe35 100644 > --- a/arch/arm64/kernel/acpi.c > +++ b/arch/arm64/kernel/acpi.c > @@ -273,8 +273,7 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr) > return __pgprot(PROT_DEVICE_nGnRnE); > } > > -static void __iomem *__acpi_os_ioremap(acpi_physical_address phys, > - acpi_size size, bool memory) > +void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) > { > efi_memory_desc_t *md, *region = NULL; > pgprot_t prot; > @@ -300,11 +299,9 @@ static void __iomem *__acpi_os_ioremap(acpi_physical_address phys, > * It is fine for AML to remap regions that are not represented in the > * EFI memory map at all, as it only describes normal memory, and MMIO > * regions that require a virtual mapping to make them accessible to > - * the EFI runtime services. Determine the region default > - * attributes by checking the requested memory semantics. > + * the EFI runtime services. > */ > - prot = memory ? __pgprot(PROT_NORMAL_NC) : > - __pgprot(PROT_DEVICE_nGnRnE); > + prot = __pgprot(PROT_DEVICE_nGnRnE); > if (region) { > switch (region->type) { > case EFI_LOADER_CODE: > @@ -364,16 +361,6 @@ static void __iomem *__acpi_os_ioremap(acpi_physical_address phys, > return __ioremap(phys, size, prot); > } > > -void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_ioremap(phys, size, false); > -} > - > -void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_ioremap(phys, size, true); > -} > - > /* > * Claim Synchronous External Aborts as a firmware first notification. > * > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index a43f1521efe6..45c5c0e45e33 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -284,8 +284,7 @@ acpi_map_lookup_virt(void __iomem *virt, acpi_size size) > #define should_use_kmap(pfn) page_is_ram(pfn) > #endif > > -static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz, > - bool memory) > +static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz) > { > unsigned long pfn; > > @@ -295,8 +294,7 @@ static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz, > return NULL; > return (void __iomem __force *)kmap(pfn_to_page(pfn)); > } else > - return memory ? acpi_os_memmap(pg_off, pg_sz) : > - acpi_os_ioremap(pg_off, pg_sz); > + return acpi_os_ioremap(pg_off, pg_sz); > } > > static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr) > @@ -311,10 +309,9 @@ static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr) > } > > /** > - * __acpi_os_map_iomem - Get a virtual address for a given physical address range. > + * acpi_os_map_iomem - Get a virtual address for a given physical address range. > * @phys: Start of the physical address range to map. > * @size: Size of the physical address range to map. > - * @memory: true if remapping memory, false if IO > * > * Look up the given physical address range in the list of existing ACPI memory > * mappings. If found, get a reference to it and return a pointer to it (its > @@ -324,8 +321,8 @@ static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr) > * During early init (when acpi_permanent_mmap has not been set yet) this > * routine simply calls __acpi_map_table() to get the job done. > */ > -static void __iomem __ref > -*__acpi_os_map_iomem(acpi_physical_address phys, acpi_size size, bool memory) > +void __iomem __ref > +*acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > { > struct acpi_ioremap *map; > void __iomem *virt; > @@ -356,7 +353,7 @@ static void __iomem __ref > > pg_off = round_down(phys, PAGE_SIZE); > pg_sz = round_up(phys + size, PAGE_SIZE) - pg_off; > - virt = acpi_map(phys, size, memory); > + virt = acpi_map(phys, size); > if (!virt) { > mutex_unlock(&acpi_ioremap_lock); > kfree(map); > @@ -375,17 +372,11 @@ static void __iomem __ref > mutex_unlock(&acpi_ioremap_lock); > return map->virt + (phys - map->phys); > } > - > -void __iomem *__ref > -acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_map_iomem(phys, size, false); > -} > EXPORT_SYMBOL_GPL(acpi_os_map_iomem); > > void *__ref acpi_os_map_memory(acpi_physical_address phys, acpi_size size) > { > - return (void *)__acpi_os_map_iomem(phys, size, true); > + return (void *)acpi_os_map_iomem(phys, size); > } > EXPORT_SYMBOL_GPL(acpi_os_map_memory); > > diff --git a/include/acpi/acpi_io.h b/include/acpi/acpi_io.h > index a0212e67d6f4..027faa8883aa 100644 > --- a/include/acpi/acpi_io.h > +++ b/include/acpi/acpi_io.h > @@ -14,14 +14,6 @@ static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys, > } > #endif > > -#ifndef acpi_os_memmap > -static inline void __iomem *acpi_os_memmap(acpi_physical_address phys, > - acpi_size size) > -{ > - return ioremap_cache(phys, size); > -} > -#endif > - > extern bool acpi_permanent_mmap; > > void __iomem __ref > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F9FBC433EF for ; Thu, 23 Sep 2021 09:19:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2639661107 for ; Thu, 23 Sep 2021 09:19:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2639661107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tSP5+2NVb9zCd7N6iQ5tDnXi64ZAGU4UU5O7zPJrXZc=; b=MNUKJSjxq561Xf 79A/ytSojrdN4LbUBYR2RP6ll1rVTiveoq+NRpVvgXJ0M5U1h7e7+QmhxIHAqevBJuo1XaVZuW7x4 aSZUXTznaL/Vgw56jK0ivhGoxqEqvNN7WLULQHCeAazOHT4x5Ant4Yyl2ggyRR+DBuZ8av12FjpJx daKrUtuZyZEm9GwaB8yvYbukB5LUNgE0De1jR+Nhjz185gCYdyplxonMoRQUH+yYtTjbYb4/xq38x gvQemd7I/LHRnZfmaUrzh76UUHbgQTXNeq6GZGAqlMUL3or2sc5l6HtfuJX6LD7h4Br3TadAUWU0+ tQhPmTYOOqvITOHD0VGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTKqi-00Akku-Ii; Thu, 23 Sep 2021 09:17:00 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTKqd-00Akjp-Mv for linux-arm-kernel@lists.infradead.org; Thu, 23 Sep 2021 09:16:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B570106F; Thu, 23 Sep 2021 02:16:53 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BB0D13F59C; Thu, 23 Sep 2021 02:16:50 -0700 (PDT) Date: Thu, 23 Sep 2021 10:16:44 +0100 From: Lorenzo Pieralisi To: Jia He Cc: Catalin Marinas , Will Deacon , "Rafael J. Wysocki" , Ard Biesheuvel , Len Brown , Robert Moore , Erik Kaneda , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, Jeremy Linton , Hanjun Guo , "Rafael J . Wysocki" , Harb Abdulhamid Subject: Re: [PATCH v3] Revert "ACPI: Add memory semantics to acpi_os_map_memory()" Message-ID: <20210923091644.GA5882@lpieralisi> References: <20210923033557.19100-1-justin.he@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210923033557.19100-1-justin.he@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_021655_896698_C6DE8BB3 X-CRM114-Status: GOOD ( 32.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 23, 2021 at 11:35:57AM +0800, Jia He wrote: > This reverts commit 437b38c51162f8b87beb28a833c4d5dc85fa864e. > > The memory semantics added in commit 437b38c51162 causes SystemMemory > Operation region, whose address range is not described in the EFI memory > map to be mapped as NormalNC memory on arm64 platforms (through > acpi_os_map_memory() in acpi_ex_system_memory_space_handler()). > > This triggers the following abort on an ARM64 Ampere eMAG machine, > because presumably the physical address range area backing the Opregion > does not support NormalNC memory attributes driven on the bus. > > Internal error: synchronous external abort: 96000410 [#1] SMP > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0+ #462 > Hardware name: MiTAC RAPTOR EV-883832-X3-0001/RAPTOR, BIOS 0.14 02/22/2019 > pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [...snip...] > Call trace: > acpi_ex_system_memory_space_handler+0x26c/0x2c8 > acpi_ev_address_space_dispatch+0x228/0x2c4 > acpi_ex_access_region+0x114/0x268 > acpi_ex_field_datum_io+0x128/0x1b8 > acpi_ex_extract_from_field+0x14c/0x2ac > acpi_ex_read_data_from_field+0x190/0x1b8 > acpi_ex_resolve_node_to_value+0x1ec/0x288 > acpi_ex_resolve_to_value+0x250/0x274 > acpi_ds_evaluate_name_path+0xac/0x124 > acpi_ds_exec_end_op+0x90/0x410 > acpi_ps_parse_loop+0x4ac/0x5d8 > acpi_ps_parse_aml+0xe0/0x2c8 > acpi_ps_execute_method+0x19c/0x1ac > acpi_ns_evaluate+0x1f8/0x26c > acpi_ns_init_one_device+0x104/0x140 > acpi_ns_walk_namespace+0x158/0x1d0 > acpi_ns_initialize_devices+0x194/0x218 > acpi_initialize_objects+0x48/0x50 > acpi_init+0xe0/0x498 > > If the Opregion address range is not present in the EFI memory map there > is no way for us to determine the memory attributes to use to map it - > defaulting to NormalNC does not work (and it is not correct on a memory > region that may have read side-effects) and therefore commit > 437b38c51162 should be reverted, which means reverting back to the > original behavior whereby address ranges that are mapped using > acpi_os_map_memory() default to the safe devicenGnRnE attributes on > ARM64 if the mapped address range is not defined in the EFI memory map. > > Fixes: 437b38c51162 ("ACPI: Add memory semantics to acpi_os_map_memory()") > Signed-off-by: Jia He > Cc: Lorenzo Pieralisi > Cc: Ard Biesheuvel > Cc: Hanjun Guo > Cc: Catalin Marinas > Cc: Rafael J. Wysocki > Cc: Harb Abdulhamid > --- > V3: refine the commit log which came from Lorenzo Pieralisi > > arch/arm64/include/asm/acpi.h | 3 --- > arch/arm64/kernel/acpi.c | 19 +++---------------- > drivers/acpi/osl.c | 23 +++++++---------------- > include/acpi/acpi_io.h | 8 -------- > 4 files changed, 10 insertions(+), 43 deletions(-) Acked-by: Lorenzo Pieralisi Rafael if possible please apply it, thank you very much. > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > index 7535dc7cc5aa..bd68e1b7f29f 100644 > --- a/arch/arm64/include/asm/acpi.h > +++ b/arch/arm64/include/asm/acpi.h > @@ -50,9 +50,6 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); > void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size); > #define acpi_os_ioremap acpi_os_ioremap > > -void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size); > -#define acpi_os_memmap acpi_os_memmap > - > typedef u64 phys_cpuid_t; > #define PHYS_CPUID_INVALID INVALID_HWID > > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > index 1c9c2f7a1c04..f3851724fe35 100644 > --- a/arch/arm64/kernel/acpi.c > +++ b/arch/arm64/kernel/acpi.c > @@ -273,8 +273,7 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr) > return __pgprot(PROT_DEVICE_nGnRnE); > } > > -static void __iomem *__acpi_os_ioremap(acpi_physical_address phys, > - acpi_size size, bool memory) > +void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) > { > efi_memory_desc_t *md, *region = NULL; > pgprot_t prot; > @@ -300,11 +299,9 @@ static void __iomem *__acpi_os_ioremap(acpi_physical_address phys, > * It is fine for AML to remap regions that are not represented in the > * EFI memory map at all, as it only describes normal memory, and MMIO > * regions that require a virtual mapping to make them accessible to > - * the EFI runtime services. Determine the region default > - * attributes by checking the requested memory semantics. > + * the EFI runtime services. > */ > - prot = memory ? __pgprot(PROT_NORMAL_NC) : > - __pgprot(PROT_DEVICE_nGnRnE); > + prot = __pgprot(PROT_DEVICE_nGnRnE); > if (region) { > switch (region->type) { > case EFI_LOADER_CODE: > @@ -364,16 +361,6 @@ static void __iomem *__acpi_os_ioremap(acpi_physical_address phys, > return __ioremap(phys, size, prot); > } > > -void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_ioremap(phys, size, false); > -} > - > -void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_ioremap(phys, size, true); > -} > - > /* > * Claim Synchronous External Aborts as a firmware first notification. > * > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index a43f1521efe6..45c5c0e45e33 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -284,8 +284,7 @@ acpi_map_lookup_virt(void __iomem *virt, acpi_size size) > #define should_use_kmap(pfn) page_is_ram(pfn) > #endif > > -static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz, > - bool memory) > +static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz) > { > unsigned long pfn; > > @@ -295,8 +294,7 @@ static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz, > return NULL; > return (void __iomem __force *)kmap(pfn_to_page(pfn)); > } else > - return memory ? acpi_os_memmap(pg_off, pg_sz) : > - acpi_os_ioremap(pg_off, pg_sz); > + return acpi_os_ioremap(pg_off, pg_sz); > } > > static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr) > @@ -311,10 +309,9 @@ static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr) > } > > /** > - * __acpi_os_map_iomem - Get a virtual address for a given physical address range. > + * acpi_os_map_iomem - Get a virtual address for a given physical address range. > * @phys: Start of the physical address range to map. > * @size: Size of the physical address range to map. > - * @memory: true if remapping memory, false if IO > * > * Look up the given physical address range in the list of existing ACPI memory > * mappings. If found, get a reference to it and return a pointer to it (its > @@ -324,8 +321,8 @@ static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr) > * During early init (when acpi_permanent_mmap has not been set yet) this > * routine simply calls __acpi_map_table() to get the job done. > */ > -static void __iomem __ref > -*__acpi_os_map_iomem(acpi_physical_address phys, acpi_size size, bool memory) > +void __iomem __ref > +*acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > { > struct acpi_ioremap *map; > void __iomem *virt; > @@ -356,7 +353,7 @@ static void __iomem __ref > > pg_off = round_down(phys, PAGE_SIZE); > pg_sz = round_up(phys + size, PAGE_SIZE) - pg_off; > - virt = acpi_map(phys, size, memory); > + virt = acpi_map(phys, size); > if (!virt) { > mutex_unlock(&acpi_ioremap_lock); > kfree(map); > @@ -375,17 +372,11 @@ static void __iomem __ref > mutex_unlock(&acpi_ioremap_lock); > return map->virt + (phys - map->phys); > } > - > -void __iomem *__ref > -acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_map_iomem(phys, size, false); > -} > EXPORT_SYMBOL_GPL(acpi_os_map_iomem); > > void *__ref acpi_os_map_memory(acpi_physical_address phys, acpi_size size) > { > - return (void *)__acpi_os_map_iomem(phys, size, true); > + return (void *)acpi_os_map_iomem(phys, size); > } > EXPORT_SYMBOL_GPL(acpi_os_map_memory); > > diff --git a/include/acpi/acpi_io.h b/include/acpi/acpi_io.h > index a0212e67d6f4..027faa8883aa 100644 > --- a/include/acpi/acpi_io.h > +++ b/include/acpi/acpi_io.h > @@ -14,14 +14,6 @@ static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys, > } > #endif > > -#ifndef acpi_os_memmap > -static inline void __iomem *acpi_os_memmap(acpi_physical_address phys, > - acpi_size size) > -{ > - return ioremap_cache(phys, size); > -} > -#endif > - > extern bool acpi_permanent_mmap; > > void __iomem __ref > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1902499280266973836==" MIME-Version: 1.0 From: Lorenzo Pieralisi Subject: [Devel] Re: [PATCH v3] Revert "ACPI: Add memory semantics to acpi_os_map_memory()" Date: Thu, 23 Sep 2021 10:16:44 +0100 Message-ID: <20210923091644.GA5882@lpieralisi> In-Reply-To: 20210923033557.19100-1-justin.he@arm.com List-ID: To: devel@acpica.org --===============1902499280266973836== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Sep 23, 2021 at 11:35:57AM +0800, Jia He wrote: > This reverts commit 437b38c51162f8b87beb28a833c4d5dc85fa864e. > = > The memory semantics added in commit 437b38c51162 causes SystemMemory > Operation region, whose address range is not described in the EFI memory > map to be mapped as NormalNC memory on arm64 platforms (through > acpi_os_map_memory() in acpi_ex_system_memory_space_handler()). > = > This triggers the following abort on an ARM64 Ampere eMAG machine, > because presumably the physical address range area backing the Opregion > does not support NormalNC memory attributes driven on the bus. > = > Internal error: synchronous external abort: 96000410 [#1] SMP > Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.14.0+ #462 > Hardware name: MiTAC RAPTOR EV-883832-X3-0001/RAPTOR, BIOS 0.14 02/22/20= 19 > pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) > [...snip...] > Call trace: > acpi_ex_system_memory_space_handler+0x26c/0x2c8 > acpi_ev_address_space_dispatch+0x228/0x2c4 > acpi_ex_access_region+0x114/0x268 > acpi_ex_field_datum_io+0x128/0x1b8 > acpi_ex_extract_from_field+0x14c/0x2ac > acpi_ex_read_data_from_field+0x190/0x1b8 > acpi_ex_resolve_node_to_value+0x1ec/0x288 > acpi_ex_resolve_to_value+0x250/0x274 > acpi_ds_evaluate_name_path+0xac/0x124 > acpi_ds_exec_end_op+0x90/0x410 > acpi_ps_parse_loop+0x4ac/0x5d8 > acpi_ps_parse_aml+0xe0/0x2c8 > acpi_ps_execute_method+0x19c/0x1ac > acpi_ns_evaluate+0x1f8/0x26c > acpi_ns_init_one_device+0x104/0x140 > acpi_ns_walk_namespace+0x158/0x1d0 > acpi_ns_initialize_devices+0x194/0x218 > acpi_initialize_objects+0x48/0x50 > acpi_init+0xe0/0x498 > = > If the Opregion address range is not present in the EFI memory map there > is no way for us to determine the memory attributes to use to map it - > defaulting to NormalNC does not work (and it is not correct on a memory > region that may have read side-effects) and therefore commit > 437b38c51162 should be reverted, which means reverting back to the > original behavior whereby address ranges that are mapped using > acpi_os_map_memory() default to the safe devicenGnRnE attributes on > ARM64 if the mapped address range is not defined in the EFI memory map. > = > Fixes: 437b38c51162 ("ACPI: Add memory semantics to acpi_os_map_memory()") > Signed-off-by: Jia He > Cc: Lorenzo Pieralisi > Cc: Ard Biesheuvel > Cc: Hanjun Guo > Cc: Catalin Marinas > Cc: Rafael J. Wysocki > Cc: Harb Abdulhamid > --- > V3: refine the commit log which came from Lorenzo Pieralisi > = > arch/arm64/include/asm/acpi.h | 3 --- > arch/arm64/kernel/acpi.c | 19 +++---------------- > drivers/acpi/osl.c | 23 +++++++---------------- > include/acpi/acpi_io.h | 8 -------- > 4 files changed, 10 insertions(+), 43 deletions(-) Acked-by: Lorenzo Pieralisi Rafael if possible please apply it, thank you very much. > diff --git a/arch/arm64/include/asm/acpi.h b/arch/arm64/include/asm/acpi.h > index 7535dc7cc5aa..bd68e1b7f29f 100644 > --- a/arch/arm64/include/asm/acpi.h > +++ b/arch/arm64/include/asm/acpi.h > @@ -50,9 +50,6 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr); > void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size= ); > #define acpi_os_ioremap acpi_os_ioremap > = > -void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size); > -#define acpi_os_memmap acpi_os_memmap > - > typedef u64 phys_cpuid_t; > #define PHYS_CPUID_INVALID INVALID_HWID > = > diff --git a/arch/arm64/kernel/acpi.c b/arch/arm64/kernel/acpi.c > index 1c9c2f7a1c04..f3851724fe35 100644 > --- a/arch/arm64/kernel/acpi.c > +++ b/arch/arm64/kernel/acpi.c > @@ -273,8 +273,7 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr) > return __pgprot(PROT_DEVICE_nGnRnE); > } > = > -static void __iomem *__acpi_os_ioremap(acpi_physical_address phys, > - acpi_size size, bool memory) > +void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) > { > efi_memory_desc_t *md, *region =3D NULL; > pgprot_t prot; > @@ -300,11 +299,9 @@ static void __iomem *__acpi_os_ioremap(acpi_physical= _address phys, > * It is fine for AML to remap regions that are not represented in the > * EFI memory map at all, as it only describes normal memory, and MMIO > * regions that require a virtual mapping to make them accessible to > - * the EFI runtime services. Determine the region default > - * attributes by checking the requested memory semantics. > + * the EFI runtime services. > */ > - prot =3D memory ? __pgprot(PROT_NORMAL_NC) : > - __pgprot(PROT_DEVICE_nGnRnE); > + prot =3D __pgprot(PROT_DEVICE_nGnRnE); > if (region) { > switch (region->type) { > case EFI_LOADER_CODE: > @@ -364,16 +361,6 @@ static void __iomem *__acpi_os_ioremap(acpi_physical= _address phys, > return __ioremap(phys, size, prot); > } > = > -void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_ioremap(phys, size, false); > -} > - > -void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_ioremap(phys, size, true); > -} > - > /* > * Claim Synchronous External Aborts as a firmware first notification. > * > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index a43f1521efe6..45c5c0e45e33 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -284,8 +284,7 @@ acpi_map_lookup_virt(void __iomem *virt, acpi_size si= ze) > #define should_use_kmap(pfn) page_is_ram(pfn) > #endif > = > -static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned lon= g pg_sz, > - bool memory) > +static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned lon= g pg_sz) > { > unsigned long pfn; > = > @@ -295,8 +294,7 @@ static void __iomem *acpi_map(acpi_physical_address p= g_off, unsigned long pg_sz, > return NULL; > return (void __iomem __force *)kmap(pfn_to_page(pfn)); > } else > - return memory ? acpi_os_memmap(pg_off, pg_sz) : > - acpi_os_ioremap(pg_off, pg_sz); > + return acpi_os_ioremap(pg_off, pg_sz); > } > = > static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr) > @@ -311,10 +309,9 @@ static void acpi_unmap(acpi_physical_address pg_off,= void __iomem *vaddr) > } > = > /** > - * __acpi_os_map_iomem - Get a virtual address for a given physical addr= ess range. > + * acpi_os_map_iomem - Get a virtual address for a given physical addres= s range. > * @phys: Start of the physical address range to map. > * @size: Size of the physical address range to map. > - * @memory: true if remapping memory, false if IO > * > * Look up the given physical address range in the list of existing ACPI= memory > * mappings. If found, get a reference to it and return a pointer to it= (its > @@ -324,8 +321,8 @@ static void acpi_unmap(acpi_physical_address pg_off, = void __iomem *vaddr) > * During early init (when acpi_permanent_mmap has not been set yet) this > * routine simply calls __acpi_map_table() to get the job done. > */ > -static void __iomem __ref > -*__acpi_os_map_iomem(acpi_physical_address phys, acpi_size size, bool me= mory) > +void __iomem __ref > +*acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > { > struct acpi_ioremap *map; > void __iomem *virt; > @@ -356,7 +353,7 @@ static void __iomem __ref > = > pg_off =3D round_down(phys, PAGE_SIZE); > pg_sz =3D round_up(phys + size, PAGE_SIZE) - pg_off; > - virt =3D acpi_map(phys, size, memory); > + virt =3D acpi_map(phys, size); > if (!virt) { > mutex_unlock(&acpi_ioremap_lock); > kfree(map); > @@ -375,17 +372,11 @@ static void __iomem __ref > mutex_unlock(&acpi_ioremap_lock); > return map->virt + (phys - map->phys); > } > - > -void __iomem *__ref > -acpi_os_map_iomem(acpi_physical_address phys, acpi_size size) > -{ > - return __acpi_os_map_iomem(phys, size, false); > -} > EXPORT_SYMBOL_GPL(acpi_os_map_iomem); > = > void *__ref acpi_os_map_memory(acpi_physical_address phys, acpi_size siz= e) > { > - return (void *)__acpi_os_map_iomem(phys, size, true); > + return (void *)acpi_os_map_iomem(phys, size); > } > EXPORT_SYMBOL_GPL(acpi_os_map_memory); > = > diff --git a/include/acpi/acpi_io.h b/include/acpi/acpi_io.h > index a0212e67d6f4..027faa8883aa 100644 > --- a/include/acpi/acpi_io.h > +++ b/include/acpi/acpi_io.h > @@ -14,14 +14,6 @@ static inline void __iomem *acpi_os_ioremap(acpi_physi= cal_address phys, > } > #endif > = > -#ifndef acpi_os_memmap > -static inline void __iomem *acpi_os_memmap(acpi_physical_address phys, > - acpi_size size) > -{ > - return ioremap_cache(phys, size); > -} > -#endif > - > extern bool acpi_permanent_mmap; > = > void __iomem __ref > -- = > 2.17.1 >=20 --===============1902499280266973836==--