All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Fertser <fercerpav@gmail.com>
To: linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-kernel@vger.kernel.org, Paul Fertser <fercerpav@gmail.com>
Subject: [PATCH v2 2/3] hwmon: tmp421: report /PVLD condition
Date: Thu, 23 Sep 2021 12:48:00 +0300	[thread overview]
Message-ID: <20210923094801.23332-2-fercerpav@gmail.com> (raw)
In-Reply-To: <20210923094801.23332-1-fercerpav@gmail.com>

For both local and remote sensors all the supported ICs can report an
"undervoltage lockout" condition which means the conversion wasn't
properly performed due to insufficient power supply voltage and so the
measurement results can't be trusted.

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
---

Changes from v1:
 - Trivial rebase

 drivers/hwmon/tmp421.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
index 63cb6badb478..9f0a4db695db 100644
--- a/drivers/hwmon/tmp421.c
+++ b/drivers/hwmon/tmp421.c
@@ -182,10 +182,10 @@ static int tmp421_read(struct device *dev, enum hwmon_sensor_types type,
 		return 0;
 	case hwmon_temp_fault:
 		/*
-		 * The OPEN bit signals a fault. This is bit 0 of the temperature
-		 * register (low byte).
+		 * Any of OPEN or /PVLD bits indicate a hardware mulfunction
+		 * and the conversion result may be incorrect
 		 */
-		*val = tmp421->temp[channel] & 0x01;
+		*val = !!(tmp421->temp[channel] & 0x03);
 		return 0;
 	default:
 		return -EOPNOTSUPP;
@@ -198,9 +198,6 @@ static umode_t tmp421_is_visible(const void *data, enum hwmon_sensor_types type,
 {
 	switch (attr) {
 	case hwmon_temp_fault:
-		if (channel == 0)
-			return 0;
-		return 0444;
 	case hwmon_temp_input:
 		return 0444;
 	default:
-- 
2.17.1


  reply	other threads:[~2021-09-23  9:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 13:41 [PATCH 1/3] hwmon: tmp421: handle I2C errors Paul Fertser
2021-09-22 13:41 ` [PATCH 2/3] hwmon: tmp421: report /PVLD condition Paul Fertser
2021-09-22 13:41 ` [PATCH 3/3] hwmon: tmp421: fix rounding for negative values Paul Fertser
2021-09-22 15:53 ` [PATCH 1/3] hwmon: tmp421: handle I2C errors Guenter Roeck
2021-09-23  9:47   ` [PATCH v2 " Paul Fertser
2021-09-23  9:48     ` Paul Fertser [this message]
2021-09-23  9:48     ` [PATCH v2 3/3] hwmon: tmp421: fix rounding for negative values Paul Fertser
2021-09-24  2:21       ` Guenter Roeck
2021-09-24  2:20     ` [PATCH v2 1/3] hwmon: tmp421: handle I2C errors Guenter Roeck
2021-09-24  7:44       ` Paul Fertser
2021-09-24 11:35         ` Guenter Roeck
2021-09-24 19:52           ` [PATCH] hwmon: cleanup non-bool "valid" data fields Paul Fertser
2021-09-25 13:23             ` Guenter Roeck
2021-10-08 14:21             ` Guenter Roeck
2021-09-24  9:30       ` [PATCH v3 1/3] hwmon: tmp421: handle I2C errors Paul Fertser
2021-09-24  9:30         ` [PATCH v3 2/3] hwmon: tmp421: report /PVLD condition as fault Paul Fertser
2021-09-24 11:59           ` Guenter Roeck
2021-09-24  9:30         ` [PATCH v3 3/3] hwmon: tmp421: fix rounding for negative values Paul Fertser
2021-09-24 12:01           ` Guenter Roeck
2021-09-24 11:58         ` [PATCH v3 1/3] hwmon: tmp421: handle I2C errors Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923094801.23332-2-fercerpav@gmail.com \
    --to=fercerpav@gmail.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.