From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73631C433FE for ; Thu, 23 Sep 2021 13:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C2D761164 for ; Thu, 23 Sep 2021 13:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241422AbhIWNhj (ORCPT ); Thu, 23 Sep 2021 09:37:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241240AbhIWNhc (ORCPT ); Thu, 23 Sep 2021 09:37:32 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E772C061757 for ; Thu, 23 Sep 2021 06:36:00 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id pf3-20020a17090b1d8300b0019e081aa87bso4953211pjb.0 for ; Thu, 23 Sep 2021 06:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LJqsayGSV0vpx1xLxjFKNF/KjYBVBG9Ud2Yl5xQheZo=; b=D2Rh5rHhzAV1xWW2d/eJUB9j5HU67L2BY92Ko4tZU0fYJMt469/jTf4snBMuv0HODu MaCYguDaTCKfeB+gJbasD0PbWzQ22JqgOV3M9ZG1FZ9U+jsRrLi7QGG/YOjPKp/6mOYK vTsMUSN1xpVRgLjWUvaCHGfk8lEJNdWk53MfypTBsKKt5tGiNZbRllmzOdSko/3yfZUt kOtTiqs24RLPgebhTijL3N7NnXM+TcIBKix/vF6Ys1NyFeYvrkLsq8SXzgSoaeHAFfDC w7XjQREBoRSTDUKAwmk/4OfV3pmTjQEMiVLz9tsZXQ6gNLEW7oyoDiCzTB4ZywJmItOn P2FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LJqsayGSV0vpx1xLxjFKNF/KjYBVBG9Ud2Yl5xQheZo=; b=S63GEVUYKiCM+vhCmYc08jk5KKNObSWVLyk7vquUGjsUWUJm/1OUrbPImj/7ii83Ru LwgDIjTGFanHNy3GGibQV44tM3S/GQECbCOMLdqpgPFS8/JPL5sbe/RZOoyixEUTEaJz ievWQef7ECqqGkIE3wM43Mf7ThwVH+De73e4w3EDJ1ZznFJTSLIfeCn1W7qMO8MkvdiG 33wHQhirLLuMiepsk4vSVKOdaAhYlsMVDeDUzxXEl80WId8iycDiFXfRs8JnFcvlIS0x yclYhQvpIyPwhqaAQq5dYYes6KX+Lpw6nMw8m1yi0JuRtkXKL7ndVOS/GHsgw6WCxkoS kbpQ== X-Gm-Message-State: AOAM533isKeVWe+a6gA2/61xa5sqwstvUo1vpm9pPFtcKRCkuloKMYgc LVAMRU30zEvJ6jT7QjD9Xqf9bA== X-Google-Smtp-Source: ABdhPJy7AdMNlnQsmc7ahmOLVyKj7KOQ0/XwFlLX4I3udO/Hou5pjQYlp3yMffNH8puN+0qemFNS+g== X-Received: by 2002:a17:90b:4d07:: with SMTP id mw7mr17215427pjb.66.1632404159921; Thu, 23 Sep 2021 06:35:59 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([213.173.35.225]) by smtp.gmail.com with ESMTPSA id p10sm6259198pge.38.2021.09.23.06.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 06:35:59 -0700 (PDT) Date: Thu, 23 Sep 2021 21:35:54 +0800 From: Leo Yan To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 2/5] perf arm-spe: Print size using consistent format Message-ID: <20210923133554.GF400258@leoy-ThinkPad-X240s> References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-2-german.gomez@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916154635.1525-2-german.gomez@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 04:46:32PM +0100, German Gomez wrote: > From: Andrew Kilroy > > Since the size is already printed earlier in hex, print the same data > using the same format, in hex. > > Reviewed-by: James Clark > Signed-off-by: Andrew Kilroy > Signed-off-by: German Gomez Reviewed-by: Leo Yan > --- > tools/perf/util/arm-spe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c > index 58b7069c5a5f..2196291976d9 100644 > --- a/tools/perf/util/arm-spe.c > +++ b/tools/perf/util/arm-spe.c > @@ -100,7 +100,7 @@ static void arm_spe_dump(struct arm_spe *spe __maybe_unused, > const char *color = PERF_COLOR_BLUE; > > color_fprintf(stdout, color, > - ". ... ARM SPE data: size %zu bytes\n", > + ". ... ARM SPE data: size %#zx bytes\n", > len); > > while (len) { > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EB5DC433F5 for ; Thu, 23 Sep 2021 13:43:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F266260F6F for ; Thu, 23 Sep 2021 13:43:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F266260F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zDNFtIU0N9SXyNO0jgqgVdwqTKnfpNIAh2yIrTeA6Pc=; b=4fk4SphlC9EKPD a7TVC4oOU1XkgiEVMVh1eEyGPrPQHDheK2Ubvz3Gb58UYVopTatK0Z0CC/u9PoVDDz4ja0H3kl/JJ ropY9MZRPNuy6W2GxAxytokNoWTE2nrZzlvna2j53Ew5bg54kLmfjCit6E8m5gZTx2QNNIM4oEzCx TDlvQ5dbbD81C0lVOnBBIsxsCuiP0uNWmdQmsW6axWBIfu26ANibaqeLuYe9J42VdBpe4TX078gtd 3cr1V51qLXbcNPgaRXZEQnljvTUfZJmlwK+S96WSg8jR7KFdEmnZsjunp0WCWAT4Mom2hVqM0ZrwP XjR2b5dD2HpKXl+FxhLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTOyL-00BhaP-N8; Thu, 23 Sep 2021 13:41:11 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTOtN-00Bfhv-5C for linux-arm-kernel@lists.infradead.org; Thu, 23 Sep 2021 13:36:02 +0000 Received: by mail-pl1-x62b.google.com with SMTP id j14so4032458plx.4 for ; Thu, 23 Sep 2021 06:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LJqsayGSV0vpx1xLxjFKNF/KjYBVBG9Ud2Yl5xQheZo=; b=D2Rh5rHhzAV1xWW2d/eJUB9j5HU67L2BY92Ko4tZU0fYJMt469/jTf4snBMuv0HODu MaCYguDaTCKfeB+gJbasD0PbWzQ22JqgOV3M9ZG1FZ9U+jsRrLi7QGG/YOjPKp/6mOYK vTsMUSN1xpVRgLjWUvaCHGfk8lEJNdWk53MfypTBsKKt5tGiNZbRllmzOdSko/3yfZUt kOtTiqs24RLPgebhTijL3N7NnXM+TcIBKix/vF6Ys1NyFeYvrkLsq8SXzgSoaeHAFfDC w7XjQREBoRSTDUKAwmk/4OfV3pmTjQEMiVLz9tsZXQ6gNLEW7oyoDiCzTB4ZywJmItOn P2FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LJqsayGSV0vpx1xLxjFKNF/KjYBVBG9Ud2Yl5xQheZo=; b=71fOWhZcn2c4ORQfst/otsJTWWVX5zAmKg43K8O1NB2ML5CIdEgt6qYC8tFtRkjYcL 7wyVDRLE5w5C+2R9ClP0Sk2kYXab/QTJfEfDp3P0laG/MZ2czzEC/A1YleTjq2h8OLon soRTBqS/6qjrRFvnO/5PSjYaaYuY1gZuJNwuKCIK/Xt4rU6gkcyhiyQ7vSADPeuQevYV DpMs7u/aReLG/YiO9tSQnr309np4YwV3DabPUfHjGJnFS5FPqPNTkw82I4FaSANgFFQo uLOXSknmNcVsgHWngK66S/sENUWLrUSgzkTpuIeIdBBo6NMdBlOjgiEoKC/0SnA1J1Gh /C4A== X-Gm-Message-State: AOAM533mywx06YooyePkMEmm1YqAbnoawlT8Dm4i74ZiCVAnpAdOFhIg 8sFERjpcPK+B4MEoKjjMRlmPqw== X-Google-Smtp-Source: ABdhPJy7AdMNlnQsmc7ahmOLVyKj7KOQ0/XwFlLX4I3udO/Hou5pjQYlp3yMffNH8puN+0qemFNS+g== X-Received: by 2002:a17:90b:4d07:: with SMTP id mw7mr17215427pjb.66.1632404159921; Thu, 23 Sep 2021 06:35:59 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([213.173.35.225]) by smtp.gmail.com with ESMTPSA id p10sm6259198pge.38.2021.09.23.06.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 06:35:59 -0700 (PDT) Date: Thu, 23 Sep 2021 21:35:54 +0800 From: Leo Yan To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Mathieu Poirier , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 2/5] perf arm-spe: Print size using consistent format Message-ID: <20210923133554.GF400258@leoy-ThinkPad-X240s> References: <20210916154635.1525-1-german.gomez@arm.com> <20210916154635.1525-2-german.gomez@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916154635.1525-2-german.gomez@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_063601_265232_CA69A8D5 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 16, 2021 at 04:46:32PM +0100, German Gomez wrote: > From: Andrew Kilroy > > Since the size is already printed earlier in hex, print the same data > using the same format, in hex. > > Reviewed-by: James Clark > Signed-off-by: Andrew Kilroy > Signed-off-by: German Gomez Reviewed-by: Leo Yan > --- > tools/perf/util/arm-spe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c > index 58b7069c5a5f..2196291976d9 100644 > --- a/tools/perf/util/arm-spe.c > +++ b/tools/perf/util/arm-spe.c > @@ -100,7 +100,7 @@ static void arm_spe_dump(struct arm_spe *spe __maybe_unused, > const char *color = PERF_COLOR_BLUE; > > color_fprintf(stdout, color, > - ". ... ARM SPE data: size %zu bytes\n", > + ". ... ARM SPE data: size %#zx bytes\n", > len); > > while (len) { > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel