From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 031BEC433EF for ; Thu, 23 Sep 2021 16:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4FC860EB2 for ; Thu, 23 Sep 2021 16:24:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242116AbhIWQ0P (ORCPT ); Thu, 23 Sep 2021 12:26:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232675AbhIWQ0J (ORCPT ); Thu, 23 Sep 2021 12:26:09 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69880C061756 for ; Thu, 23 Sep 2021 09:24:37 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id z14-20020a17090a8b8e00b0019cc29ceef1so7363512pjn.1 for ; Thu, 23 Sep 2021 09:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+mvRxQ/9Ym+apTi7SELQjAMP9+j2UVU8a1FoPdxwoEw=; b=vXfpnwJPn+o1iDrAYRTpffl3dtTT5keS2pP2UOw4dSffaueW2sfsKr57vhKD33fGi9 ltf/5XEb/K3uHQNPWmuiiIpQW/skVtWh9Jhf5l6JA6IjKvD0ykUjRH48dgI/DlmjVRKx ssQ9A+kghQp5K65sPfianrXagszo6ri4/rzecyTWMUNrUvuJC3dHl3WhYu3Y50lHX16J XewsAlUQoKMVQJIbb0k19dkZaBzvUHgPAnzML3wtNkYvCICkl7JAQW4Odu/Yygen6PXc CX+nHSmI35C1yhfhnsUFTXftjJUb35u3aR5yd/qjDmf1pS7NDU6FHiQKbwTAegEKryFK o7NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+mvRxQ/9Ym+apTi7SELQjAMP9+j2UVU8a1FoPdxwoEw=; b=oWSg9uxTroCXwrbpSV1+iVsEawe4DX2qEP2r7bGYQFwSfKj1SkHaDarkyEBxgfDjVr 3lgOTskvb/ujkdM+K9Zkh1yT9mbJKHJC6kIqGTWUBS+G2DI0Y8sYDE5b5TDeE33nM+Up Hih3HPccHpPq9Z4daWWOHEVu9YhelIefCo72PZm1o7cYSAurpvHJ9/n9vUkVPbe/+DDx eO5UCeAMEE/NAFcaTInwwpMcmAMI648xEvn/KS4ozSqN0VBVzdn3X16Br1ruwlsrP/hy 2jGLDhqhHMUGjmLr9jw8bDQEdcOhQsPgHFdpghIRGIq5ABriqj3b3Po3W4JdsGRH6HrY E0Cg== X-Gm-Message-State: AOAM533/788srDwEM98jrErZVsy4mm/8J73b6YOtSnG0Sdhtqzi8tQNv ONRWR2v54e4U5UEUiCUGf19HlA== X-Google-Smtp-Source: ABdhPJxU3AEW85yNwW19+0HD60DixujFWhwIpdqfyAJEXe3AY6IzRlCipZYeYp/E02g04gpVHzW9Mg== X-Received: by 2002:a17:90a:9912:: with SMTP id b18mr18911339pjp.46.1632414276879; Thu, 23 Sep 2021 09:24:36 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id w13sm9822413pjc.29.2021.09.23.09.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 09:24:36 -0700 (PDT) Date: Thu, 23 Sep 2021 10:24:34 -0600 From: Mathieu Poirier To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format Message-ID: <20210923162434.GA2189675@p14s> References: <20210916154635.1525-1-german.gomez@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916154635.1525-1-german.gomez@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi German, On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > From: Andrew Kilroy > > Since the size is already printed earlier in hex, print the same data > using the same format, in hex. > > Reviewed-by: James Clark > Signed-off-by: Andrew Kilroy > Signed-off-by: German Gomez > --- > tools/perf/util/cs-etm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index f323adb1af85..4f672f7d008c 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq, > > fprintf(stdout, "\n"); > color_fprintf(stdout, color, > - ". ... CoreSight %s Trace data: size %zu bytes\n", > + ". ... CoreSight %s Trace data: size %#zx bytes\n", Reviewed-by: Mathieu Poirier A couple of things to improve for your next interactions with the Linux community: 1) Using a cover letter, even for small changes, is always a good idea. 2) RB tags should be picked up publicly rather than done internally and added to a patchset. 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do with 01, 02 and 03. Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to this patchset. As such he will not see your work. Ask James about how to proceed when submitting patches to the perf tools. Thanks, Mathieu > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > do { > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEB2CC433F5 for ; Thu, 23 Sep 2021 16:25:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABBA5610D1 for ; Thu, 23 Sep 2021 16:25:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ABBA5610D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/UN/RKJsGdNxiPo5nNoH4RQmA/Iy6cBi9y3aFHyueC8=; b=Qw7CVCspZVceA7 eWLraL0qqrPSlTKl0xuyWSKDMoB6sD3SU1Zzhe021B/L1nN5iFmLg2GQTgTFfep6mxWnG/FsPzknO pGeBZzjHmK2vKvi4ciK+77q7fHfCKMXFpOBOEujHMzSlioMARwG4RMt7+eVU7lYMYWtjtRysY0ma/ CMJ6aHcxo7Gbdjp0SUUJSPwBYaaCYdgPih0CeQBmTharOAn61O6VtF8D5v0xksA99rHOCj7OB6YZp ocwQZCBvf1/b0FMZTzQB6onomXZI1fSVa1k/nGff2GuL5AP+y0hhV4gvdxt8VD90cuKye7S9/quTu MPL0gm1c1fc1PjZgacDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTRWc-00C8pY-F1; Thu, 23 Sep 2021 16:24:42 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTRWY-00C8oG-SV for linux-arm-kernel@lists.infradead.org; Thu, 23 Sep 2021 16:24:40 +0000 Received: by mail-pj1-x102d.google.com with SMTP id dw14so4825490pjb.1 for ; Thu, 23 Sep 2021 09:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+mvRxQ/9Ym+apTi7SELQjAMP9+j2UVU8a1FoPdxwoEw=; b=vXfpnwJPn+o1iDrAYRTpffl3dtTT5keS2pP2UOw4dSffaueW2sfsKr57vhKD33fGi9 ltf/5XEb/K3uHQNPWmuiiIpQW/skVtWh9Jhf5l6JA6IjKvD0ykUjRH48dgI/DlmjVRKx ssQ9A+kghQp5K65sPfianrXagszo6ri4/rzecyTWMUNrUvuJC3dHl3WhYu3Y50lHX16J XewsAlUQoKMVQJIbb0k19dkZaBzvUHgPAnzML3wtNkYvCICkl7JAQW4Odu/Yygen6PXc CX+nHSmI35C1yhfhnsUFTXftjJUb35u3aR5yd/qjDmf1pS7NDU6FHiQKbwTAegEKryFK o7NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+mvRxQ/9Ym+apTi7SELQjAMP9+j2UVU8a1FoPdxwoEw=; b=nPa2E7+aibNxz0Omd+V3yRDaQ6U1HABq9OWD6hX4Wqv4JpxkZW4p4iZIwKE4hBzj0Z lizMfWgY5BDWQiFMnk+2yTe/34r05a1r0B7TLq8t8NMj8RabiIDKZxT12yG6STZ+o/2/ HxNHcfvaa2VhKIpymIo4JDe6CitVqy8L7qCpqBTM39acR6dMBmUyREeO9NCle1IJdLaD woGB6lHfQe0s75gEsFzpnw5tADFO1Zm1WnpeLjuZo6jcNWCDr6N4FLzjgRNsI8H02k2Z 6sgBUdKXY3wUExBKCYqK7/gLgYfHSW/YFPtWwdh2+HHG5R4UekWmylMkGxgwPvpGWmyn xKOA== X-Gm-Message-State: AOAM53264XPCXBjcGjv9l147zx5gd2gDH9FDXCqEAGVDFa2Qvn6hSntN J8Q/5fGAxjQC2ierr7Nl9pOnbw== X-Google-Smtp-Source: ABdhPJxU3AEW85yNwW19+0HD60DixujFWhwIpdqfyAJEXe3AY6IzRlCipZYeYp/E02g04gpVHzW9Mg== X-Received: by 2002:a17:90a:9912:: with SMTP id b18mr18911339pjp.46.1632414276879; Thu, 23 Sep 2021 09:24:36 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id w13sm9822413pjc.29.2021.09.23.09.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 09:24:36 -0700 (PDT) Date: Thu, 23 Sep 2021 10:24:34 -0600 From: Mathieu Poirier To: German Gomez Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Andrew Kilroy , John Garry , Will Deacon , Leo Yan , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Mike Leach , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org Subject: Re: [PATCH 1/5] perf cs-etm: Print size using consistent format Message-ID: <20210923162434.GA2189675@p14s> References: <20210916154635.1525-1-german.gomez@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210916154635.1525-1-german.gomez@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210923_092438_976015_B9EBF69F X-CRM114-Status: GOOD ( 20.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi German, On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > From: Andrew Kilroy > > Since the size is already printed earlier in hex, print the same data > using the same format, in hex. > > Reviewed-by: James Clark > Signed-off-by: Andrew Kilroy > Signed-off-by: German Gomez > --- > tools/perf/util/cs-etm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index f323adb1af85..4f672f7d008c 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq, > > fprintf(stdout, "\n"); > color_fprintf(stdout, color, > - ". ... CoreSight %s Trace data: size %zu bytes\n", > + ". ... CoreSight %s Trace data: size %#zx bytes\n", Reviewed-by: Mathieu Poirier A couple of things to improve for your next interactions with the Linux community: 1) Using a cover letter, even for small changes, is always a good idea. 2) RB tags should be picked up publicly rather than done internally and added to a patchset. 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do with 01, 02 and 03. Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to this patchset. As such he will not see your work. Ask James about how to proceed when submitting patches to the perf tools. Thanks, Mathieu > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > do { > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel