* [PATCH v2] NIOS2: fix kconfig unmet dependency warning for SERIAL_CORE_CONSOLE
@ 2021-09-24 0:29 Randy Dunlap
2021-09-24 15:59 ` Dinh Nguyen
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2021-09-24 0:29 UTC (permalink / raw)
To: linux-kernel; +Cc: Randy Dunlap, Dinh Nguyen
SERIAL_CORE_CONSOLE depends on TTY so EARLY_PRINTK should also
depend on TTY so that it does not select SERIAL_CORE_CONSOLE
inadvertently.
WARNING: unmet direct dependencies detected for SERIAL_CORE_CONSOLE
Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
Selected by [y]:
- EARLY_PRINTK [=y]
Fixes: e8bf5bc776ed ("nios2: add early printk support")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dinh Nguyen <dinguyen@kernel.org>
---
v2: resend to new maintainer
arch/nios2/Kconfig.debug | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-next-20210923.orig/arch/nios2/Kconfig.debug
+++ linux-next-20210923/arch/nios2/Kconfig.debug
@@ -3,9 +3,10 @@
config EARLY_PRINTK
bool "Activate early kernel debugging"
default y
+ depends on TTY
select SERIAL_CORE_CONSOLE
help
- Enable early printk on console
+ Enable early printk on console.
This is useful for kernel debugging when your machine crashes very
early before the console code is initialized.
You should normally say N here, unless you want to debug such a crash.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] NIOS2: fix kconfig unmet dependency warning for SERIAL_CORE_CONSOLE
2021-09-24 0:29 [PATCH v2] NIOS2: fix kconfig unmet dependency warning for SERIAL_CORE_CONSOLE Randy Dunlap
@ 2021-09-24 15:59 ` Dinh Nguyen
0 siblings, 0 replies; 2+ messages in thread
From: Dinh Nguyen @ 2021-09-24 15:59 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
On 9/23/21 7:29 PM, Randy Dunlap wrote:
> SERIAL_CORE_CONSOLE depends on TTY so EARLY_PRINTK should also
> depend on TTY so that it does not select SERIAL_CORE_CONSOLE
> inadvertently.
>
> WARNING: unmet direct dependencies detected for SERIAL_CORE_CONSOLE
> Depends on [n]: TTY [=n] && HAS_IOMEM [=y]
> Selected by [y]:
> - EARLY_PRINTK [=y]
>
> Fixes: e8bf5bc776ed ("nios2: add early printk support")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> ---
> v2: resend to new maintainer
Applied!
Thanks,
Dinh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-24 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 0:29 [PATCH v2] NIOS2: fix kconfig unmet dependency warning for SERIAL_CORE_CONSOLE Randy Dunlap
2021-09-24 15:59 ` Dinh Nguyen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.