From: Kees Cook <keescook@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kees Cook <keescook@chromium.org>,
"Tobin C. Harding" <me@tobin.cc>,
Tycho Andersen <tycho@tycho.pizza>, Helge Deller <deller@gmx.de>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Vito Caputo <vcaputo@pengaru.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Jann Horn <jannh@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Mark Rutland <mark.rutland@arm.com>, Jens Axboe <axboe@kernel.dk>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
Lai Jiangshan <laijs@linux.alibaba.com>,
Stefan Metzmacher <metze@samba.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Michal Hocko <mhocko@suse.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Randy Dunlap <rdunlap@infradead.org>,
Ohhoon Kwon <ohoono.kwon@samsung.com>,
YiFei Zhu <yifeifz2@illinois.edu>,
kernel test robot <oliver.sang@intel.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-hardening@vger.kernel.org, x86@kernel.org,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 2/3] leaking_addresses: Always print a trailing newline
Date: Thu, 23 Sep 2021 23:20:05 -0700 [thread overview]
Message-ID: <20210924062006.231699-3-keescook@chromium.org> (raw)
In-Reply-To: <20210924062006.231699-1-keescook@chromium.org>
For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
net line, making things look corrupted.
Unconditionally remove the newline on input, and write it back out on
output.
[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/
Cc: "Tobin C. Harding" <me@tobin.cc>
Cc: Tycho Andersen <tycho@tycho.pizza>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
scripts/leaking_addresses.pl | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.pl
index b2d8b8aa2d99..8f636a23bc3f 100755
--- a/scripts/leaking_addresses.pl
+++ b/scripts/leaking_addresses.pl
@@ -455,8 +455,9 @@ sub parse_file
open my $fh, "<", $file or return;
while ( <$fh> ) {
+ chomp;
if (may_leak_address($_)) {
- print $file . ': ' . $_;
+ printf("$file: $_\n");
}
}
close $fh;
--
2.30.2
next prev parent reply other threads:[~2021-09-24 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 6:20 [PATCH 0/3] wchan: Fix ORC support and leaky fallback Kees Cook
2021-09-24 6:20 ` [PATCH 1/3] Revert "proc/wchan: use printk format instead of lookup_symbol_name()" Kees Cook
2021-09-24 8:17 ` Helge Deller
2021-09-24 6:20 ` Kees Cook [this message]
2021-09-24 6:20 ` [PATCH 3/3] x86: Fix get_wchan() to support the ORC unwinder Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924062006.231699-3-keescook@chromium.org \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=christian.brauner@ubuntu.com \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=jpoimboe@redhat.com \
--cc=laijs@linux.alibaba.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=me@tobin.cc \
--cc=metze@samba.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=ohoono.kwon@samsung.com \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.pizza \
--cc=vcaputo@pengaru.com \
--cc=x86@kernel.org \
--cc=yifeifz2@illinois.edu \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.