From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE61CC433EF for ; Fri, 24 Sep 2021 07:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87EF46124C for ; Fri, 24 Sep 2021 07:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244166AbhIXHmZ (ORCPT ); Fri, 24 Sep 2021 03:42:25 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:33871 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244428AbhIXHmV (ORCPT ); Fri, 24 Sep 2021 03:42:21 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id BB54D58108A; Fri, 24 Sep 2021 03:40:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 24 Sep 2021 03:40:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=K3QOPik4vRo2PwF4S+8r6PvTMNG R4DNlcHp3C4PMAhE=; b=M8hnKTD50ReAPzl0RlF/ztAW4kotH682kO97BICtjBG fJp7GBylbLlEN3GvzlAcyNv/oy3L/jP+ojNx/eG+wmTLOOxY6VSXSJ8KqcPOTkRZ RDJGlvOcc2EHY1MjnaiR6+CMihq5pSWv8dInwJ6i3yGdGpkCBv91RgTQf2zsWWA6 hvh0Zbm2Xw+QSggEVX9uC1EJ8Mw0d0fm+T4LZZAsmBgUwmPo+ORDQb7MzgprxaP9 geQBiW8obyrbRHmQH0AlZcBbN3+4S70jClXmmPxd2eYRQaUDbhj9r3grTMiTWgJr m8469NC+UPGuNsumoWcxgR5E5tDeYnbNjrZ6Bhynq8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=K3QOPi k4vRo2PwF4S+8r6PvTMNGR4DNlcHp3C4PMAhE=; b=Her9lJ199ZKS6moX4znHgd P7t5m7vSo/Ks9ZAJD3g8dveBxBd9EulVPJemuOIr1PpbJd7RKvSpALZ7EpK3bHlu iTj+Ma+fC8WdbK6hk6i/qREQFjHTmWScIaZfWhI+mBEuh1keuEYpsFD9uaShwXj9 1DULJ1aj7EgmB/LLdhMOhrR08oNWK4Xka5vnsYBfKaN2p4F5yQcxq2gDS7bG7feI FtRK5RRPXlDoyHTpl6mv21WlY/bfe8RY8A4jlcnxLphFCJCr8S5z2uwpM4bhoQ4j 0k3vbU9B9Kx1lXLiGyvMRCfB9eGtWCbXxoDT/Ixf/hq7Wrt3oiFHc7MEkbrMG+Fg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudejtddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheei heegudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Sep 2021 03:40:46 -0400 (EDT) Date: Fri, 24 Sep 2021 09:40:44 +0200 From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Nicolas Saenz Julienne , Florian Fainelli , Michael Stapelberg , Linus Torvalds Subject: Re: [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Message-ID: <20210924074044.e24kbxr7lhdtb3eg@gilmour> References: <20210922125419.4125779-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k62r2q7dvrx6knrx" Content-Disposition: inline In-Reply-To: <20210922125419.4125779-1-maxime@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --k62r2q7dvrx6knrx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Sep 22, 2021 at 02:54:14PM +0200, Maxime Ripard wrote: > Hi, >=20 > Here's another attempt at fixing the complete CPU stall while retrieving = the > HDMI connector status when the connector is disabled. >=20 > This was fixed already, but eventually got reverted by Linus due to the s= ame > symptom happening in another situation. This was likely (but not confirme= d by > the reporter) due to the kernel being booted without an HDMI display conn= ected, > in which case the firmware won't initialise the HDMI State Machine clock. >=20 > This is fixed by patch 3. However, further changes in the clock drivers w= ere > needed for clk_set_min_rate to be used, which are patches 1 and 2. >=20 > Finally, patches 4 and 5 are the original patches that were reverted. Pat= ch 4 > got a small modification to move the clk_set_min_rate() call before the H= SM > clock is enabled. If we merge the clock patches and DRM patches separately we're going to break bisectability. I guess the easiest approach would be to merge the clk patches through DRM. Does that work for everyone? Maxime --k62r2q7dvrx6knrx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYU2A/AAKCRDj7w1vZxhR xSzSAP45QmM9fnpXAlV7Z4FF/GWq+5uBTj+BJgYc/Sp1CRU8NgEApgY92jEO2DOp O0tfsNiRmZTEEVL196/9ZqmSvH9nWA8= =aOPg -----END PGP SIGNATURE----- --k62r2q7dvrx6knrx-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72473C433F5 for ; Fri, 24 Sep 2021 07:42:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43EDF60E9B for ; Fri, 24 Sep 2021 07:42:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43EDF60E9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2pJqkzPmPCLYrToEi55LxpbDJxV/BHtJEkKRobzeILw=; b=aQMZkwxVLAfv5cTHlLZz3ij+/3 VGa8ocptCCoSCl9qw7a1MV3sEj2Cn5xnxyS3oalVGn3jVKm+aR+w2NCa28mnFAabt9W/j3Jdy3bwi 0RZGWAzLxjqPt4WouvAtO55IWNQ107ZCP5D0djsYudXpKT5z1kZCnfX3NEOf3uT2u9gLWczRnqmU1 RmrjLy6x74U/c8dwiI3ztIjqGLk/fVd1A7kqWQIC0xrT5TRnmLUVatCHVv7dWJaDAkH0grDZzA9LJ fIvrmlswcLSg7lwrtc0J1051RgvSVD+wCFhONXfTMQn7sgyiVN3UILwG+mVYpyAlkxbIiWUwnDM0P uOFT/5fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTfpE-00DMFu-K9; Fri, 24 Sep 2021 07:40:52 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTfpB-00DMFR-4y; Fri, 24 Sep 2021 07:40:50 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id BB54D58108A; Fri, 24 Sep 2021 03:40:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 24 Sep 2021 03:40:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=K3QOPik4vRo2PwF4S+8r6PvTMNG R4DNlcHp3C4PMAhE=; b=M8hnKTD50ReAPzl0RlF/ztAW4kotH682kO97BICtjBG fJp7GBylbLlEN3GvzlAcyNv/oy3L/jP+ojNx/eG+wmTLOOxY6VSXSJ8KqcPOTkRZ RDJGlvOcc2EHY1MjnaiR6+CMihq5pSWv8dInwJ6i3yGdGpkCBv91RgTQf2zsWWA6 hvh0Zbm2Xw+QSggEVX9uC1EJ8Mw0d0fm+T4LZZAsmBgUwmPo+ORDQb7MzgprxaP9 geQBiW8obyrbRHmQH0AlZcBbN3+4S70jClXmmPxd2eYRQaUDbhj9r3grTMiTWgJr m8469NC+UPGuNsumoWcxgR5E5tDeYnbNjrZ6Bhynq8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=K3QOPi k4vRo2PwF4S+8r6PvTMNGR4DNlcHp3C4PMAhE=; b=Her9lJ199ZKS6moX4znHgd P7t5m7vSo/Ks9ZAJD3g8dveBxBd9EulVPJemuOIr1PpbJd7RKvSpALZ7EpK3bHlu iTj+Ma+fC8WdbK6hk6i/qREQFjHTmWScIaZfWhI+mBEuh1keuEYpsFD9uaShwXj9 1DULJ1aj7EgmB/LLdhMOhrR08oNWK4Xka5vnsYBfKaN2p4F5yQcxq2gDS7bG7feI FtRK5RRPXlDoyHTpl6mv21WlY/bfe8RY8A4jlcnxLphFCJCr8S5z2uwpM4bhoQ4j 0k3vbU9B9Kx1lXLiGyvMRCfB9eGtWCbXxoDT/Ixf/hq7Wrt3oiFHc7MEkbrMG+Fg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudejtddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheei heegudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 24 Sep 2021 03:40:46 -0400 (EDT) Date: Fri, 24 Sep 2021 09:40:44 +0200 From: Maxime Ripard To: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Nicolas Saenz Julienne , Florian Fainelli , Michael Stapelberg , Linus Torvalds Subject: Re: [PATCH 0/5] drm/vc4: hdmi: Remove CPU hangs, take 2 Message-ID: <20210924074044.e24kbxr7lhdtb3eg@gilmour> References: <20210922125419.4125779-1-maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: <20210922125419.4125779-1-maxime@cerno.tech> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210924_004049_288862_0D15CABC X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2401605819776616104==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2401605819776616104== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k62r2q7dvrx6knrx" Content-Disposition: inline --k62r2q7dvrx6knrx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Sep 22, 2021 at 02:54:14PM +0200, Maxime Ripard wrote: > Hi, >=20 > Here's another attempt at fixing the complete CPU stall while retrieving = the > HDMI connector status when the connector is disabled. >=20 > This was fixed already, but eventually got reverted by Linus due to the s= ame > symptom happening in another situation. This was likely (but not confirme= d by > the reporter) due to the kernel being booted without an HDMI display conn= ected, > in which case the firmware won't initialise the HDMI State Machine clock. >=20 > This is fixed by patch 3. However, further changes in the clock drivers w= ere > needed for clk_set_min_rate to be used, which are patches 1 and 2. >=20 > Finally, patches 4 and 5 are the original patches that were reverted. Pat= ch 4 > got a small modification to move the clk_set_min_rate() call before the H= SM > clock is enabled. If we merge the clock patches and DRM patches separately we're going to break bisectability. I guess the easiest approach would be to merge the clk patches through DRM. Does that work for everyone? Maxime --k62r2q7dvrx6knrx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYU2A/AAKCRDj7w1vZxhR xSzSAP45QmM9fnpXAlV7Z4FF/GWq+5uBTj+BJgYc/Sp1CRU8NgEApgY92jEO2DOp O0tfsNiRmZTEEVL196/9ZqmSvH9nWA8= =aOPg -----END PGP SIGNATURE----- --k62r2q7dvrx6knrx-- --===============2401605819776616104== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2401605819776616104==--