All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Luke Hsiao <luke.w.hsiao@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, Yuchung Cheng <ycheng@google.com>,
	Lawrence Brakmo <brakmo@fb.com>,
	Neal Cardwell <ncardwell@google.com>,
	Eric Dumazet <edumazet@google.com>,
	Luke Hsiao <lukehsiao@google.com>
Subject: Re: [PATCH net-next] tcp: tracking packets with CE marks in BW rate sample
Date: Fri, 24 Sep 2021 13:20:05 -0700	[thread overview]
Message-ID: <20210924132005.264e4e2d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210923211706.2553282-1-luke.w.hsiao@gmail.com>

On Thu, 23 Sep 2021 21:17:07 +0000 Luke Hsiao wrote:
> From: Yuchung Cheng <ycheng@google.com>
> 
> In order to track CE marks per rate sample (one round trip), TCP needs a
> per-skb header field to record the tp->delivered_ce count when the skb
> was sent. To make space, we replace the "last_in_flight" field which is
> used exclusively for NV congestion control. The stat needed by NV can be
> alternatively approximated by existing stats tcp_sock delivered and
> mss_cache.
> 
> This patch counts the number of packets delivered which have CE marks in
> the rate sample, using similar approach of delivery accounting.

Is this expected to be used from BPF CC? I don't see a user..

  parent reply	other threads:[~2021-09-24 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 21:17 [PATCH net-next] tcp: tracking packets with CE marks in BW rate sample Luke Hsiao
2021-09-24 13:30 ` patchwork-bot+netdevbpf
2021-09-24 20:20 ` Jakub Kicinski [this message]
2021-09-24 23:30   ` Yuchung Cheng
2021-09-24 23:42     ` Jakub Kicinski
2021-09-26 22:31     ` Dave Taht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924132005.264e4e2d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=brakmo@fb.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=luke.w.hsiao@gmail.com \
    --cc=lukehsiao@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.