All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, sjg@chromium.org,
	Wolfgang Denk <wd@denx.de>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH v6 1/3] arm64: arch/arm/lib: Add optimized memset/memcpy/memmove functions
Date: Fri, 24 Sep 2021 10:14:20 -0400	[thread overview]
Message-ID: <20210924141420.GB31748@bill-the-cat> (raw)
In-Reply-To: <20210902150019.1349263-2-sr@denx.de>

[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]

On Thu, Sep 02, 2021 at 05:00:17PM +0200, Stefan Roese wrote:

> Ported from https://github.com/ARM-software/optimized-routines
> 
> These files are included from this repository, including the latest
> git commit ID:
> string/aarch64/memcpy.S: afd6244a1f8d
> string/aarch64/memset.S: e823e3abf5f8
> string/asmdefs.h: e823e3abf5f8
> 
> Note that memmove is also handled by the memcpy function.
> 
> Please note that when adding these optimized functions as default memset
> memcpy functions in U-Boot, U-Boot fails to boot on the LX2160ARDB.
> After the initial ATF output, no U-Boot output is shown on the serial
> console. Some exception is triggered here in the very early boot process
> as some of the assembler opcodes need the caches to be enabled.
> 
> Because of this, a follow-up patch will add a check to use a simple
> non-optimized memset for the "cache disabled" case.
> 
> Note:
> I also integrated and tested with the Linux versions of these optimized
> functions. They are similar to the ones now integrated but these ARM
> versions are still a small bit faster.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-09-24 14:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 15:00 [PATCH v6 0/3] arm64: Add optimized memset/memcpy/memove functions Stefan Roese
2021-09-02 15:00 ` [PATCH v6 1/3] arm64: arch/arm/lib: Add optimized memset/memcpy/memmove functions Stefan Roese
2021-09-24 14:14   ` Tom Rini [this message]
2021-09-02 15:00 ` [PATCH v6 2/3] arm64: memset-arm64: Use simple memset when cache is disabled Stefan Roese
2021-09-24 14:14   ` Tom Rini
2021-09-02 15:00 ` [PATCH v6 3/3] arm64: Kconfig: Enable usage of optimized memset/memcpy/memmove Stefan Roese
2021-09-23 19:56   ` Tom Rini
2021-09-24  7:21     ` Stefan Roese
2021-09-24 14:14   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924141420.GB31748@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.