From: Christoph Hellwig <hch@lst.de>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Ming Lei <ming.lei@redhat.com>,
Zdenek Kabelac <zkabelac@redhat.com>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard
Date: Fri, 24 Sep 2021 17:58:22 +0200 [thread overview]
Message-ID: <20210924155822.GA10064@lst.de> (raw)
In-Reply-To: <alpine.LRH.2.02.2109231539520.27863@file01.intranet.prod.int.rdu2.redhat.com>
On Thu, Sep 23, 2021 at 03:48:27PM -0400, Mikulas Patocka wrote:
> Hi
>
> When running the lvm testsuite, we get a lot of warnings
> "blk_update_request: operation not supported error, dev loop0, sector 0 op
> 0x9:(WRITE_ZEROES) flags 0x800800 phys_seg 0 prio class 0". The lvm
> testsuite puts the loop device on tmpfs and the reason for the warning is
> that tmpfs supports fallocate, but doesn't support FALLOC_FL_ZERO_RANGE.
>
> I've created this patch to silence the warnings.
>
> Mikulas
>
>
>
> From: Mikulas Patocka <mpatocka@redhat.com>
>
> The loop driver checks for the fallocate method and if it is present, it
> assumes that the filesystem can do FALLOC_FL_ZERO_RANGE and
> FALLOC_FL_PUNCH_HOLE requests. However, some filesystems (such as fat, or
> tmpfs) have the fallocate method, but lack the capability to do
> FALLOC_FL_ZERO_RANGE and/or FALLOC_FL_PUNCH_HOLE.
>
> This results in syslog warnings "blk_update_request: operation not
> supported error, dev loop0, sector 0 op 0x9:(WRITE_ZEROES) flags 0x800800
> phys_seg 0 prio class 0"
>
> This patch sets RQF_QUIET to silence the warnings.
Doesn't this just paper over the problem? I think we need an
unsigned int with flag in the file_operations for the supported
operations for this kind of use.
next prev parent reply other threads:[~2021-09-24 15:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 19:48 [PATCH] loop: don't print warnings if the underlying filesystem doesn't support discard Mikulas Patocka
2021-09-24 0:17 ` Ming Lei
2021-09-24 15:58 ` Christoph Hellwig [this message]
2021-10-04 13:01 ` [dm-devel] " Mikulas Patocka
2021-10-04 13:01 ` Mikulas Patocka
2021-10-12 6:20 ` Christoph Hellwig
2021-10-12 6:20 ` [dm-devel] " Christoph Hellwig
2021-10-12 20:25 ` [PATCH v3] " Mikulas Patocka
2021-10-12 20:25 ` [dm-devel] " Mikulas Patocka
2021-10-13 2:56 ` kernel test robot
2021-10-13 2:56 ` kernel test robot
2021-10-13 2:56 ` [dm-devel] " kernel test robot
2021-10-13 5:06 ` kernel test robot
2021-10-13 5:06 ` kernel test robot
2021-10-13 5:06 ` [dm-devel] " kernel test robot
2021-10-13 9:28 ` [PATCH v4] " Mikulas Patocka
2021-10-13 9:28 ` [dm-devel] " Mikulas Patocka
2021-10-27 5:02 ` Dave Chinner
2021-10-27 5:02 ` [dm-devel] " Dave Chinner
2021-10-27 8:28 ` Mikulas Patocka
2021-10-27 8:28 ` [dm-devel] " Mikulas Patocka
2021-10-28 4:15 ` Dave Chinner
2021-10-28 4:15 ` [dm-devel] " Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924155822.GA10064@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.