From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Jared Bents <jared.bents@rockwellcollins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host
Date: Sat, 25 Sep 2021 08:32:09 +0200 [thread overview]
Message-ID: <20210925063209.GJ3176@scaer> (raw)
In-Reply-To: <20210924213946.2888625-1-fontaine.fabrice@gmail.com>
Fabrice, All,
On 2021-09-24 23:39 +0200, Fabrice Fontaine spake thusly:
> Make a standard install (i.e. with pvcreate) for host as it is needed
> for libvirt
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/lvm2/lvm2.mk | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 3a94aebfd4..d918b5f5b6 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -72,8 +72,7 @@ HOST_LVM2_CONF_OPTS = \
> --disable-fsadm \
> --disable-readline \
> --disable-selinux
> -HOST_LVM2_MAKE_OPTS = device-mapper
> -HOST_LVM2_INSTALL_OPTS = install_device-mapper
> +HOST_LVM2_INSTALL_OPTS = DESTDIR=$(HOST_DIR) install
DESTDIR must not be used for host variants.
Indeed, they are already configured with --prefix=$(HOST_DIR) :
https://git.buildroot.org/buildroot/tree/package/pkg-autotools.mk#n223
And DESTDIR is for out-of-tree installation, but for host packages we do
not install out-of-tree as their prefix is already correct.
https://www.gnu.org/software/automake/manual/automake.html#DESTDIR
If the install fails because of things installed in /etc and such, then
appropriate --sysconfdir=$(HOST_DIR)/etc et al. should be specified
instead. Or maybe we only need 'make install-exec' ?
Regards,
Yann E. MORIN.
> $(eval $(autotools-package))
> $(eval $(host-autotools-package))
> --
> 2.33.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-09-25 6:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 21:39 [Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host Fabrice Fontaine
2021-09-24 21:39 ` [Buildroot] [PATCH 2/2] package/libvirt: add host-lvm2 dependency Fabrice Fontaine
2021-09-25 6:32 ` Yann E. MORIN [this message]
2021-09-25 6:49 ` [Buildroot] [PATCH 1/2] package/lvm2: make a standard install for host Yann E. MORIN
2021-09-25 7:45 ` Fabrice Fontaine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210925063209.GJ3176@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=jared.bents@rockwellcollins.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.