All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net: cisco: Fix a function name in comments
@ 2021-09-25 12:46 Cai Huoqing
  2021-09-26 23:45 ` Govindarajulu Varadarajan
  2021-09-27 12:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-25 12:46 UTC (permalink / raw)
  To: caihuoqing
  Cc: Christian Benvenuti, Govindarajulu Varadarajan, David S. Miller,
	Jakub Kicinski, netdev, linux-kernel

Use dma_alloc_coherent() instead of pci_alloc_consistent(),
because only dma_alloc_coherent() is called here.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
 drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
 drivers/net/ethernet/cisco/enic/enic_main.c    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_ethtool.c b/drivers/net/ethernet/cisco/enic/enic_ethtool.c
index 12ffc14fbecd..6ded4d9fa32a 100644
--- a/drivers/net/ethernet/cisco/enic/enic_ethtool.c
+++ b/drivers/net/ethernet/cisco/enic/enic_ethtool.c
@@ -139,7 +139,7 @@ static void enic_get_drvinfo(struct net_device *netdev,
 	int err;
 
 	err = enic_dev_fw_info(enic, &fw_info);
-	/* return only when pci_zalloc_consistent fails in vnic_dev_fw_info
+	/* return only when dma_alloc_coherent fails in vnic_dev_fw_info
 	 * For other failures, like devcmd failure, we return previously
 	 * recorded info.
 	 */
@@ -270,7 +270,7 @@ static void enic_get_ethtool_stats(struct net_device *netdev,
 	int err;
 
 	err = enic_dev_stats_dump(enic, &vstats);
-	/* return only when pci_zalloc_consistent fails in vnic_dev_stats_dump
+	/* return only when dma_alloc_coherent fails in vnic_dev_stats_dump
 	 * For other failures, like devcmd failure, we return previously
 	 * recorded stats.
 	 */
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index d0a8f7106958..13dbdd5d07b4 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -882,7 +882,7 @@ static void enic_get_stats(struct net_device *netdev,
 	int err;
 
 	err = enic_dev_stats_dump(enic, &stats);
-	/* return only when pci_zalloc_consistent fails in vnic_dev_stats_dump
+	/* return only when dma_alloc_coherent fails in vnic_dev_stats_dump
 	 * For other failures, like devcmd failure, we return previously
 	 * recorded stats.
 	 */
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: cisco: Fix a function name in comments
  2021-09-25 12:46 [PATCH] net: cisco: Fix a function name in comments Cai Huoqing
@ 2021-09-26 23:45 ` Govindarajulu Varadarajan
  2021-09-27 12:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Govindarajulu Varadarajan @ 2021-09-26 23:45 UTC (permalink / raw)
  To: Cai Huoqing
  Cc: Christian Benvenuti, David S. Miller, Jakub Kicinski, netdev,
	linux-kernel

On Sat, Sep 25, 2021 at 5:46 AM Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> Use dma_alloc_coherent() instead of pci_alloc_consistent(),
> because only dma_alloc_coherent() is called here.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Thanks.

Reviewed-by: Govindarajulu Varadarajan <gvaradar@cisco.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: cisco: Fix a function name in comments
  2021-09-25 12:46 [PATCH] net: cisco: Fix a function name in comments Cai Huoqing
  2021-09-26 23:45 ` Govindarajulu Varadarajan
@ 2021-09-27 12:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-27 12:30 UTC (permalink / raw)
  To: Cai Huoqing; +Cc: benve, _govind, davem, kuba, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Sat, 25 Sep 2021 20:46:28 +0800 you wrote:
> Use dma_alloc_coherent() instead of pci_alloc_consistent(),
> because only dma_alloc_coherent() is called here.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
>  drivers/net/ethernet/cisco/enic/enic_ethtool.c | 4 ++--
>  drivers/net/ethernet/cisco/enic/enic_main.c    | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Here is the summary with links:
  - net: cisco: Fix a function name in comments
    https://git.kernel.org/netdev/net-next/c/f947fcaffd6a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-27 12:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-25 12:46 [PATCH] net: cisco: Fix a function name in comments Cai Huoqing
2021-09-26 23:45 ` Govindarajulu Varadarajan
2021-09-27 12:30 ` patchwork-bot+netdevbpf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.