From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
bcm-kernel-feedback-list@broadcom.com (open list:BROADCOM GENET
ETHERNET DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net-next 1/4] net: bcmgenet: remove netif_carrier_off from adjust_link
Date: Sat, 25 Sep 2021 20:21:11 -0700 [thread overview]
Message-ID: <20210926032114.1785872-2-f.fainelli@gmail.com> (raw)
In-Reply-To: <20210926032114.1785872-1-f.fainelli@gmail.com>
From: Doug Berger <opendmb@gmail.com>
The bcmgenet_mii_setup() function is registered as the adjust_link
callback from the phylib for the GENET driver.
The phylib always sets the netif_carrier according to phydev->link
prior to invoking the adjust_link callback, so there is no need to
repeat that in the link down case within the network driver.
Signed-off-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/genet/bcmmii.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index ff1efd52ce16..8a9d8ceaa5bf 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -106,9 +106,6 @@ void bcmgenet_mii_setup(struct net_device *dev)
/* done if nothing has changed */
if (!status_changed)
return;
-
- /* needed for MoCA fixed PHY to reflect correct link status */
- netif_carrier_off(dev);
}
phy_print_status(phydev);
--
2.25.1
next prev parent reply other threads:[~2021-09-26 3:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 3:21 [PATCH net-next 0/4] net: bcmgenet: support for flow control Florian Fainelli
2021-09-26 3:21 ` Florian Fainelli [this message]
2021-09-26 13:59 ` [PATCH net-next 1/4] net: bcmgenet: remove netif_carrier_off from adjust_link Andrew Lunn
2021-09-26 3:21 ` [PATCH net-next 2/4] net: bcmgenet: remove old link state values Florian Fainelli
2021-09-26 14:00 ` Andrew Lunn
2021-09-26 3:21 ` [PATCH net-next 3/4] net: bcmgenet: pull mac_config from adjust_link Florian Fainelli
2021-09-26 14:05 ` Andrew Lunn
2021-09-26 3:21 ` [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control Florian Fainelli
2021-09-26 14:26 ` Andrew Lunn
2021-10-12 19:13 ` Doug Berger
2021-10-25 17:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210926032114.1785872-2-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.