All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sergio M. Iglesias" <sergio@lony.xyz>
To: bhelgaas@google.com
Cc: lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: About the "__refdata" tag in pci-keystone.c
Date: Mon, 27 Sep 2021 12:33:21 +0200	[thread overview]
Message-ID: <20210927103321.v4kod7xfiv5sreet@lony.xyz> (raw)

Hello!

I have checked the "__refdata" tag that appears in the file
"drivers/pci/controller/dwc/pci-keystone.c" and it is needed. The tag has
been there since the creation of the file on commit 6e0832fa432e and
nothing has changed since that would make it redundant.

The reason it is needed is because the struct references "ks_pcie_probe",
which is a function tagged as "__init", so the compiler will most likely
complain about the "__refdata" being removed.

Should I send a patch to add a comment explaining why it is a necessary
tag as recommended in "include/linux/init.h"?
> [...] so optimally document why the __ref is needed and why it's OK).

Thanks for your time,
Sergio M. Iglesias.

             reply	other threads:[~2021-09-27 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 10:33 Sergio M. Iglesias [this message]
2021-09-27 15:31 ` About the "__refdata" tag in pci-keystone.c Bjorn Helgaas
2021-09-29 13:23   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210927103321.v4kod7xfiv5sreet@lony.xyz \
    --to=sergio@lony.xyz \
    --cc=bhelgaas@google.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.