From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Perry Yuan <Perry.Yuan@dell.com>,
Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>
Subject: [PATCH] platform: dell: all DELL_WMI driver options depend on DELL_WMI
Date: Mon, 27 Sep 2021 13:53:54 -0700 [thread overview]
Message-ID: <20210927205354.19342-1-rdunlap@infradead.org> (raw)
A randconfig or a user can set/enable DELL_WMI_PRIVACY even when
DELL_WMI is not enabled. This leads to a build error in
dell-laptop.o:
ld: drivers/platform/x86/dell/dell-laptop.o: in function `dell_init':
dell-laptop.c:(.init.text+0x719): undefined reference to `dell_privacy_has_mic_mute'
Fix this by enclosing the DELL_WMI driver options inside a
if DELL_WMI / endif bracket.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Perry Yuan <Perry.Yuan@dell.com>
Cc: Dell.Client.Kernel@dell.com
Cc: platform-driver-x86@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <mgross@linux.intel.com>
---
Found in linux-next, applies to mainline.
The last time that I sent a patch to Perry Yuan (about 2 weeks ago),
it bounced...
drivers/platform/x86/dell/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
--- linux-next-20210927.orig/drivers/platform/x86/dell/Kconfig
+++ linux-next-20210927/drivers/platform/x86/dell/Kconfig
@@ -164,6 +164,8 @@ config DELL_WMI
To compile this driver as a module, choose M here: the module will
be called dell-wmi.
+if DELL_WMI
+
config DELL_WMI_PRIVACY
bool "Dell WMI Hardware Privacy Support"
depends on LEDS_TRIGGER_AUDIO = y || DELL_WMI = LEDS_TRIGGER_AUDIO
@@ -198,6 +200,8 @@ config DELL_WMI_LED
This adds support for the Latitude 2100 and similar
notebooks that have an external LED.
+endif # DELL_WMI
+
config DELL_WMI_SYSMAN
tristate "Dell WMI-based Systems management driver"
default m
next reply other threads:[~2021-09-27 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 20:53 Randy Dunlap [this message]
2021-10-08 14:49 ` [PATCH] platform: dell: all DELL_WMI driver options depend on DELL_WMI Randy Dunlap
2021-10-11 13:15 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927205354.19342-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.