From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 531A4C433EF for ; Mon, 27 Sep 2021 23:50:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA3C0611CE for ; Mon, 27 Sep 2021 23:50:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA3C0611CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C309382DF7; Tue, 28 Sep 2021 01:50:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="btHfv3PE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A83B682DB3; Tue, 28 Sep 2021 01:49:00 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2062b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E000F82DB2 for ; Tue, 28 Sep 2021 01:48:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S1SKKLH6nqSe+IUEEETtukNy9zr4fI3/K7rHkU3E2AOa6W3gNQL/xcvZFvGDCE/vReBCcgZy8q1QGrmAemSAIzgGGGrVtt3du/vSaV2T1F96jpQnJwr1PWhsX0DC2+xucyHhyDiVHbQIWIr0cm2ySo515AFkMDdG2hiloO2WCeCWi3mJpd62Bq+sHPdu+O5u+EkmnkNsPy819O3u+ewsmZcQbRqU5a+kgYrulhcSd0U0DIqn7ew3kSnoGMKBlc/4LOGyvAgeCce8ZwsX7yII36ogLP3VI7Ss8wNFw7aL624mQYWMMeUy6yhDxAbW1iPErIPIcAr8uT+dBEn2k2rGJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mzlJIZ78HV783e1Fofxpi/5g8Z2arASrakQC6EZbqeA=; b=OfuQQ350eDFuT1BW9iXWAz8yDmCVOq1PNNpO27rnA8gHCeAjEFGjH8BNJqj/KrHK/EFTi2DbiEpWHUKO7oM0nBj4wxrU8SZNiHrgRgV7INIOcimjFtT2EFB29pmW+nfvFy9oh1hzSKzbHl6V+RaGc5625f6AGZz8XF1qn1xNqjfuxNPVpCTXbcAHxJFNMp4aDU4qEowtzNJ8jUV5LUmaredkYOavNDVhKcDGTdQnLhIRejOxA1s08oYDml/Z7c04I1gmWwjqMnsj1AyNxNWfrLYLSywxTFz7lWYtKQgg11KsiIzdGS5UR6YLww/o7IcwChxB5CAbfrRAVfVUviJffA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mzlJIZ78HV783e1Fofxpi/5g8Z2arASrakQC6EZbqeA=; b=btHfv3PEE71utVNFmZ9uE0+E+ApUu+552q6lDIIBumVb7rWYNdiU+SFTkEschNxU42M3w9gVn2PDUEml4ModJGxNFRFp5ijEXFsvrsLXVo6Fx+6KwSE0KMhqkzEIDrVdPvlTM50WR8MLlJc9+MiFODxSo7ekPn+VvK3OdlOtOnI= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VE1PR04MB6637.eurprd04.prod.outlook.com (2603:10a6:803:126::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Mon, 27 Sep 2021 23:48:52 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.021; Mon, 27 Sep 2021 23:48:51 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de, Joe Hershberger , Ramon Fried , Priyanka Jain Subject: [PATCH 5/9] net: dsa: felix: configure the in-band autoneg property based on OF node info Date: Tue, 28 Sep 2021 02:48:21 +0300 Message-Id: <20210927234825.823582-6-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210927234825.823582-1-vladimir.oltean@nxp.com> References: <20210927234825.823582-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM0PR10CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::15) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM0PR10CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:17c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13 via Frontend Transport; Mon, 27 Sep 2021 23:48:51 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2cac57b4-b220-44d0-a641-08d982115bd5 X-MS-TrafficTypeDiagnostic: VE1PR04MB6637: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9prIjDqhPYjxLcN+nvvMdwVLQcYcE/T+Br/laLhRNSxuciP4H+kTqs9nnWoLXks4BwTV4aVMvKRpn34hdEnlFK89wkFZNTcDODJoRFnzEr/DWjD72zai2qTnF3N3/LgSDwJ9cnsPQyJnIlQ1v0GK1tF+mPk0vDeqF+SOJFU6+AmW1W4t99CHsW7SHdZDMwx2KDyOxUy061SUCLDydcJpJY+uDmRwn+mpElOh8IWZu4Uchbe6J7mO4ZfIaNqU7KqQkBQv3JXgICCAO0mpR/Ip1tm1cVzMnVAE0GzfSJd624TZFq+YfKGs73DA4G2KR1f15kac/+lHC6iQmWgpNx1gsYKVJQcNqUBv9pzkcKiLwadeogirugISxyQtH4X9R3693KGmFim6v1rqCohRCeqZNJLKAdASSPuEcLyoWvFgAVwN44/xe7GiQRh8TEvEhsXKUpWhdfOYOQvHz1KJ6brcxOc7lape0xvByUE9KINSxDkWDtPqSKsNN7ianlQy7mj/0xjOBGEknYGd5nzfvRg8w8C0g1+7wB5A067vy6IeQuo4aQmm+LulCgeweYebNLX4SF6/1nZJM4rI2yjdJLJwZeu+jkDsjqIzDgRaKH8ImZzdka8HTLxRRcjzAVkQCawyxFVPLM8Rq7U4ZtMfwOUsG6Yn1305o4iGS/RZ+QQBUEPfI32GlMRwKPlE4Q2vdbpVQIhX8Jz6OF7KOlfZKYOjdw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(44832011)(66946007)(1076003)(508600001)(6636002)(38100700002)(38350700002)(66556008)(66476007)(6666004)(36756003)(6486002)(6506007)(6512007)(8676002)(110136005)(8936002)(83380400001)(2616005)(316002)(956004)(86362001)(2906002)(26005)(186003)(5660300002)(52116002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CwuzxcGjVCgwxxcP4mv2NUIOG/xaCXdRttvKZZhajnffXSkXEDE5speLO2Oi?= =?us-ascii?Q?n6NZCMuOb4cJhrTYoaNl4rN0IPLuvSHEJFUnQ06AQZJkV4QXnM2sb9PiZkaJ?= =?us-ascii?Q?Rxz+UH3wWKNCJlH+jTqNAApZJucClyxIm1MzuoNyCbJsYO8xt/pAlyqet8BV?= =?us-ascii?Q?knYCIl8Tpd/2RgLoWdc1AjEx4eYwNM0QFky9GgrqAcC+1waz/WM71eUaR7XQ?= =?us-ascii?Q?Z1nFE1aXrpOPYaK04LC9rwIbGgKMsL76DgppTdkJV9cyKTKsXUYcyTpQuxX2?= =?us-ascii?Q?Zuoi25OSVheefr8lhydoa0L/RZP7UNqWYOALlLSylJ8CgV3CcOt8Sb+ZJ80J?= =?us-ascii?Q?HiN+h3oz2Rro3wYtbjnYPL51/FRTqy7bu+DK87gIga6yLdAG+u5vxT3O5fui?= =?us-ascii?Q?spje47UcJqwvvKap9gfEb0bNKfkGsCu88dsJFpJmCFoSmNR7e1TeZd4e2R2H?= =?us-ascii?Q?61gHv2IYfPiTbffO3lmrY6GmVJiIN3JspDdvMhum6vsOanlBYleS/bdv2y6e?= =?us-ascii?Q?JJKumnYDtT/bTC1zjTGs74vdC1kZF7dMYkgTt9T8wrW7boDMN4cIWpTqnwep?= =?us-ascii?Q?bumN/PcE+q804TTpHO9DntG9hFA1WWguKiFZzMjrmWs3FsOLvA2LeyHehk6r?= =?us-ascii?Q?MOviqGPmmG3sPqC8262kVL0CyCxMDBVHQBlSU4GMZLrWn6vRMUCUsCv1gpFp?= =?us-ascii?Q?3uE+ejEqR/L14oKhjkzvmGaf5JSXDe2yzjmYBbB4bwq0DfzvX6NfdoKy9j/r?= =?us-ascii?Q?p7XQAEr+hon1J9LLciAXVCLd84dECubjwQC7QlqOt6IKHEZT2CzgMiBjzOYB?= =?us-ascii?Q?icqjkvwwE9baxBGtDv0r5sCvuLmRE722JO5wO9x2P/ZzOVFWjHN5Tw5btLoy?= =?us-ascii?Q?0wrlwUKMu74zdhbOyAUNAyYRUciOD5gaeym9n7cBk0Htm/fmEBmSUrgia7rM?= =?us-ascii?Q?OI17tH3QTDe9u+qdKiRunKrx/GxYhn31sQHp/O8Ckop5JyKHUHtsmqmfrAOX?= =?us-ascii?Q?BULzK2AyqwNkD1FXk7aWCiGG5B6yUPdjl+zLw8tawFi4/78FTQMAUhJwaVSA?= =?us-ascii?Q?qAsAHO2YWvKur8CGRZ0M8j4fnYGvGS1N1FtxDgg0F1DkE2Y3zzZvJkGn7quR?= =?us-ascii?Q?pVD7bPBKCvjZf0j0Y7MarLlsWuw4+MEG6P9jdjw7vDyDG6ZsZS/FQjOnrmhG?= =?us-ascii?Q?Lc1scnFXdCjKI6TOFw8p7uw9A4f+3NhdQgmyH+2dPvSBLlBGl7Yv5mYrb5iE?= =?us-ascii?Q?Nc9NSkXgPCnI/yTn7gkrQPcQF8s4uuSh/nLLtfC3t8szrl1vLTs0PW8qQd7/?= =?us-ascii?Q?CSqeARhEg+bRSipsYqFpdSLs?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2cac57b4-b220-44d0-a641-08d982115bd5 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2021 23:48:51.8437 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uGXUv4hpWj8D0m76oecTi4zj+4qOaKCSsyj4ZYzF0d7KfS83LqUjI427z3+62LpkKaKDQKiSlW8IxldIs9XkDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6637 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Instead of trying to guess which operating modes need in-band negotiation to be active and which ones don't, parse the available information from the device tree. That will be correct in the cases we can already guess, and more. Signed-off-by: Vladimir Oltean --- drivers/net/mscc_eswitch/felix_switch.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c index 6aa79784460d..1df7d03fc40c 100644 --- a/drivers/net/mscc_eswitch/felix_switch.c +++ b/drivers/net/mscc_eswitch/felix_switch.c @@ -16,6 +16,7 @@ */ #include +#include #include #include #include @@ -210,17 +211,14 @@ static int felix_init_sxgmii(struct mii_dev *imdio, int pidx) static void felix_start_pcs(struct udevice *dev, int port, struct phy_device *phy, struct mii_dev *imdio) { - bool autoneg = true; - - if (phy->phy_id == PHY_FIXED_ID || - phy->interface == PHY_INTERFACE_MODE_SGMII_2500) - autoneg = false; + ofnode node = dsa_port_get_ofnode(dev, port); + bool inband_an = ofnode_eth_uses_inband_aneg(node); switch (phy->interface) { case PHY_INTERFACE_MODE_SGMII: case PHY_INTERFACE_MODE_SGMII_2500: case PHY_INTERFACE_MODE_QSGMII: - felix_init_sgmii(imdio, port, autoneg); + felix_init_sgmii(imdio, port, inband_an); break; case PHY_INTERFACE_MODE_XGMII: case PHY_INTERFACE_MODE_XFI: -- 2.25.1