All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Steven Seungcheol Lee <sc108.lee@gmail.com>
Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme.h: expend lbaf on nvme_id_ns, lbafe on nvme_zns_id_ns
Date: Mon, 27 Sep 2021 19:59:16 -0700	[thread overview]
Message-ID: <20210928025916.GA389836@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <CAGrZSEw-YnoeJbt3_JQ6v81YWV6Lc3ao7eh8dNA0+aS8p7mWBw@mail.gmail.com>

On Tue, Sep 28, 2021 at 11:51:30AM +0900, Steven Seungcheol Lee wrote:
> I only mean lbaf, lbafe field.
> other than lbaf, lbafe fields are not used.
> I thought It would be nice to add other fields as well, since the
> structure will be changed with lbaf, lbafe.
> should I comment about other fields instead of just mentioning spec ?

The driver currently can't access the new elements, though, so what's
the point of defining them? If you want to enable these formats, then
this change needs to be part of a larger patch that properly enables the
feature.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-09-28  2:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26  4:34 [PATCH] nvme.h: expend lbaf on nvme_id_ns, lbafe on nvme_zns_id_ns Steven Seungcheol Lee
2021-09-27 10:24 ` Niklas Cassel
2021-09-27 19:23 ` Chaitanya Kulkarni
2021-09-27 20:03 ` Keith Busch
2021-09-28  2:19   ` Steven Seungcheol Lee
2021-09-28  2:43     ` Keith Busch
2021-09-28  2:51       ` Steven Seungcheol Lee
2021-09-28  2:59         ` Keith Busch [this message]
2021-09-28  3:44           ` Steven Seungcheol Lee
2021-09-28  8:45             ` Steven Seungcheol Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210928025916.GA389836@dhcp-10-100-145-180.wdc.com \
    --to=kbusch@kernel.org \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    --cc=sc108.lee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.