All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up
@ 2021-09-28  7:14 Markus Armbruster
  2021-09-28  8:47 ` Daniel P. Berrangé
  2021-09-28  9:10 ` Laurent Vivier
  0 siblings, 2 replies; 3+ messages in thread
From: Markus Armbruster @ 2021-09-28  7:14 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial

Fixes: 5dd1f02b4bc2f2c2ef3a2adfd8a412c8c8769085
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 8f603cc7e6..27e7b9a77c 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3188,7 +3188,7 @@ DEFHEADING(Character device options:)
 DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
     "-chardev help\n"
     "-chardev null,id=id[,mux=on|off][,logfile=PATH][,logappend=on|off]\n"
-    "-chardev socket,id=id[,host=host],port=port[,to=to][,ipv4=on|off][,ipv6=on|off][,nodelay=on|off][,reconnect=seconds]\n"
+    "-chardev socket,id=id[,host=host],port=port[,to=to][,ipv4=on|off][,ipv6=on|off][,nodelay=on|off]\n"
     "         [,server=on|off][,wait=on|off][,telnet=on|off][,websocket=on|off][,reconnect=seconds][,mux=on|off]\n"
     "         [,logfile=PATH][,logappend=on|off][,tls-creds=ID][,tls-authz=ID] (tcp)\n"
     "-chardev socket,id=id,path=path[,server=on|off][,wait=on|off][,telnet=on|off][,websocket=on|off][,reconnect=seconds]\n"
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up
  2021-09-28  7:14 [PATCH] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up Markus Armbruster
@ 2021-09-28  8:47 ` Daniel P. Berrangé
  2021-09-28  9:10 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2021-09-28  8:47 UTC (permalink / raw)
  To: Markus Armbruster; +Cc: qemu-trivial, qemu-devel

On Tue, Sep 28, 2021 at 09:14:49AM +0200, Markus Armbruster wrote:
> Fixes: 5dd1f02b4bc2f2c2ef3a2adfd8a412c8c8769085
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up
  2021-09-28  7:14 [PATCH] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up Markus Armbruster
  2021-09-28  8:47 ` Daniel P. Berrangé
@ 2021-09-28  9:10 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2021-09-28  9:10 UTC (permalink / raw)
  To: Markus Armbruster, qemu-devel; +Cc: qemu-trivial

Le 28/09/2021 à 09:14, Markus Armbruster a écrit :
> Fixes: 5dd1f02b4bc2f2c2ef3a2adfd8a412c8c8769085
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 8f603cc7e6..27e7b9a77c 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -3188,7 +3188,7 @@ DEFHEADING(Character device options:)
>  DEF("chardev", HAS_ARG, QEMU_OPTION_chardev,
>      "-chardev help\n"
>      "-chardev null,id=id[,mux=on|off][,logfile=PATH][,logappend=on|off]\n"
> -    "-chardev socket,id=id[,host=host],port=port[,to=to][,ipv4=on|off][,ipv6=on|off][,nodelay=on|off][,reconnect=seconds]\n"
> +    "-chardev socket,id=id[,host=host],port=port[,to=to][,ipv4=on|off][,ipv6=on|off][,nodelay=on|off]\n"
>      "         [,server=on|off][,wait=on|off][,telnet=on|off][,websocket=on|off][,reconnect=seconds][,mux=on|off]\n"
>      "         [,logfile=PATH][,logappend=on|off][,tls-creds=ID][,tls-authz=ID] (tcp)\n"
>      "-chardev socket,id=id,path=path[,server=on|off][,wait=on|off][,telnet=on|off][,websocket=on|off][,reconnect=seconds]\n"
> 

Applied to my trivial-patches branch.

Thanks,
Laurent


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-09-28  9:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28  7:14 [PATCH] qemu-options: -chardev reconnect=seconds duplicated in help, tidy up Markus Armbruster
2021-09-28  8:47 ` Daniel P. Berrangé
2021-09-28  9:10 ` Laurent Vivier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.