From: Prashant Malani <pmalani@chromium.org>
To: linux-kernel@vger.kernel.org
Cc: bleung@chromium.org, Prashant Malani <pmalani@chromium.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
platform-driver-x86@vger.kernel.org (open list:X86 PLATFORM
DRIVERS)
Subject: [PATCH 1/3] platform/x86: intel_scu_ipc: Fix busy loop expiry time
Date: Tue, 28 Sep 2021 03:19:30 -0700 [thread overview]
Message-ID: <20210928101932.2543937-2-pmalani@chromium.org> (raw)
In-Reply-To: <20210928101932.2543937-1-pmalani@chromium.org>
The macro IPC_TIMEOUT is already in jiffies (it is also used like that
elsewhere in the file when calling wait_for_completion_timeout()). Don’t
convert it using helper functions for the purposes of calculating the
busy loop expiry time.
Fixes: e7b7ab3847c9 (“platform/x86: intel_scu_ipc: Sleeping is fine when polling”)
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Cc: Benson Leung <bleung@chromium.org>
---
drivers/platform/x86/intel_scu_ipc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
index bfa0cc20750d..cfb249da2a7b 100644
--- a/drivers/platform/x86/intel_scu_ipc.c
+++ b/drivers/platform/x86/intel_scu_ipc.c
@@ -232,7 +232,7 @@ static inline u32 ipc_data_readl(struct intel_scu_ipc_dev *scu, u32 offset)
/* Wait till scu status is busy */
static inline int busy_loop(struct intel_scu_ipc_dev *scu)
{
- unsigned long end = jiffies + msecs_to_jiffies(IPC_TIMEOUT);
+ unsigned long end = jiffies + IPC_TIMEOUT;
do {
u32 status;
--
2.33.0.685.g46640cef36-goog
next prev parent reply other threads:[~2021-09-28 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 10:19 [PATCH 0/3] platform/x86: intel_scu_ipc: timeout fixes and cleanup Prashant Malani
2021-09-28 10:19 ` Prashant Malani [this message]
2021-09-28 10:54 ` [PATCH 1/3] platform/x86: intel_scu_ipc: Fix busy loop expiry time Mika Westerberg
2021-09-28 10:19 ` [PATCH 2/3] platform/x86: intel_scu_ipc: Increase virtual timeout to 10s Prashant Malani
2021-09-28 10:55 ` Mika Westerberg
2021-09-28 10:19 ` [PATCH 3/3] platform/x86: intel_scu_ipc: Update timeout value in comment Prashant Malani
2021-09-28 10:55 ` Mika Westerberg
2021-10-11 13:36 ` [PATCH 0/3] platform/x86: intel_scu_ipc: timeout fixes and cleanup Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928101932.2543937-2-pmalani@chromium.org \
--to=pmalani@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bleung@chromium.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.