All of lore.kernel.org
 help / color / mirror / Atom feed
* [freescale-fslc:5.4-2.3.x-imx 12229/21308] drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6764:22: sparse: sparse: incorrect type in assignment (different base types)
@ 2021-09-28  2:50 kernel test robot
  2021-09-28  2:50 ` [RFC PATCH freescale-fslc] MLK-24458 net: wireless: nxp: mxm_wifiex: woal_uap_update_11ax_ie() can be static kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2021-09-28  2:50 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 20010 bytes --]

tree:   https://github.com/Freescale/linux-fslc 5.4-2.3.x-imx
head:   5e2f889a8a3a0b326eb96497906bc7bcb6bcb743
commit: ec10135c193594eff7ee081099b4a409d2c89205 [12229/21308] MLK-24458 net: wireless: nxp: mxm_wifiex: upgrade to mxm4x17186 release
config: x86_64-randconfig-s022-20210927 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/Freescale/linux-fslc/commit/ec10135c193594eff7ee081099b4a409d2c89205
        git remote add freescale-fslc https://github.com/Freescale/linux-fslc
        git fetch --no-tags freescale-fslc 5.4-2.3.x-imx
        git checkout ec10135c193594eff7ee081099b4a409d2c89205
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:142:8: sparse: sparse: symbol 'woal_is_country_code_supported' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:167:6: sparse: sparse: symbol 'region_string_2_region_code' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c: note: in included file (through drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/mlan.h, drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.h):
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/mlan_ioctl.h:2346:22: sparse: sparse: array of flexible structures
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:1653:5: sparse: sparse: symbol 'woal_set_countrycode' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:4338:21: sparse: sparse: Using plain integer as NULL pointer
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:4440:21: sparse: sparse: Using plain integer as NULL pointer
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6764:22: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned int [usertype] flag @@     got restricted gfp_t @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6764:22: sparse:     expected unsigned int [usertype] flag
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6764:22: sparse:     got restricted gfp_t
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6768:67: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected restricted gfp_t [usertype] flags @@     got unsigned int [usertype] flag @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6768:67: sparse:     expected restricted gfp_t [usertype] flags
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6768:67: sparse:     got unsigned int [usertype] flag
--
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:1972:13: sparse: sparse: symbol 'woal_set_coalesce' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3433:28: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3433:28: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3433:28: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3433:28: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3434:27: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3434:27: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3434:27: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3434:27: sparse: sparse: cast to restricted __be16
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:3422:6: sparse: sparse: symbol 'is_selected_registrar_on' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4114:37: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] rx_mcs_map @@     got unsigned short [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4114:37: sparse:     expected restricted __le16 [usertype] rx_mcs_map
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4114:37: sparse:     got unsigned short [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4115:37: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] rx_highest @@     got unsigned short [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4115:37: sparse:     expected restricted __le16 [usertype] rx_highest
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4115:37: sparse:     got unsigned short [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4117:37: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] tx_mcs_map @@     got unsigned short [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4117:37: sparse:     expected restricted __le16 [usertype] tx_mcs_map
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4117:37: sparse:     got unsigned short [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4118:37: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] tx_highest @@     got unsigned short [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4118:37: sparse:     expected restricted __le16 [usertype] tx_highest
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4118:37: sparse:     got unsigned short [usertype]
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4244:6: sparse: sparse: symbol 'woal_uap_update_11ax_ie' was not declared. Should it be static?
--
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:38:11: sparse: sparse: symbol 'cfg80211_cipher_suites' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2015:29: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] frame_control @@     got restricted __le16 [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2015:29: sparse:     expected unsigned short [usertype] frame_control
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2015:29: sparse:     got restricted __le16 [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2066:31: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] auth_alg @@     got restricted __le16 [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2066:31: sparse:     expected unsigned short [usertype] auth_alg
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2066:31: sparse:     got restricted __le16 [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:516:6: sparse: sparse: symbol 'is_cfg80211_special_region_code' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1205:13: sparse: sparse: symbol 'woal_set_ewpa_mode' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1616:5: sparse: sparse: symbol 'woal_cfg80211_connect_scan' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1702:6: sparse: sparse: symbol 'woal_save_assoc_params' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:1761:6: sparse: sparse: symbol 'woal_save_auth_params' was not declared. Should it be static?
>> drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2270:6: sparse: sparse: symbol 'woal_assoc_resp_event' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3532:13: sparse: sparse: symbol 'woal_role_switch' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3622:13: sparse: sparse: symbol 'woal_uap_scan' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:3709:6: sparse: sparse: symbol 'woal_is_scan_result_expired' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4099:29: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] frame_control @@     got restricted __le16 [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4099:29: sparse:     expected unsigned short [usertype] frame_control
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4099:29: sparse:     got restricted __le16 [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4205:29: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] frame_control @@     got restricted __le16 [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4205:29: sparse:     expected unsigned short [usertype] frame_control
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4205:29: sparse:     got restricted __le16 [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4216:31: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] auth_alg @@     got restricted __le16 [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4216:31: sparse:     expected unsigned short [usertype] auth_alg
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4216:31: sparse:     got restricted __le16 [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4217:39: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] auth_transaction @@     got restricted __le16 [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4217:39: sparse:     expected unsigned short [usertype] auth_transaction
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4217:39: sparse:     got restricted __le16 [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4218:34: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] status_code @@     got restricted __le16 [usertype] @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4218:34: sparse:     expected unsigned short [usertype] status_code
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4218:34: sparse:     got restricted __le16 [usertype]
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:4933:6: sparse: sparse: symbol 'woal_bandcfg_to_ieee_band' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:6537:5: sparse: sparse: symbol 'woal_update_okc_roaming_ie' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7063:29: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] frame_control @@     got int @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7063:29: sparse:     expected restricted __le16 [usertype] frame_control
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7063:29: sparse:     got int
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7066:36: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le16 [usertype] reason_code @@     got unsigned short [usertype] reason_code @@
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7066:36: sparse:     expected restricted __le16 [usertype] reason_code
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7066:36: sparse:     got unsigned short [usertype] reason_code
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7197:13: sparse: sparse: symbol 'woal_cfg80211_init_wiphy' was not declared. Should it be static?
   drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:7378:6: sparse: sparse: symbol 'woal_update_channel_flag' was not declared. Should it be static?

Please review and possibly fold the followup patch.

vim +6764 drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c

  6611	
  6612	/*
  6613	 *  @brief Parse mfg cmd tx frame string
  6614	 *
  6615	 *  @param s        A pointer to user buffer
  6616	 *  @param len      Length of user buffer
  6617	 *  @param d        A pointer to mfg_cmd_tx_frame2 struct
  6618	 *  @return         0 on success, -EINVAL otherwise
  6619	 */
  6620	static int parse_tx_frame_string(const char *s, size_t len,
  6621					 struct mfg_cmd_tx_frame2 *d)
  6622	{
  6623		int ret = MLAN_STATUS_SUCCESS;
  6624		char *string = NULL;
  6625		char *tmp = NULL;
  6626		char *pos = NULL;
  6627		int i;
  6628		gfp_t flag;
  6629	
  6630		ENTER();
  6631		if (!s || !d) {
  6632			LEAVE();
  6633			return -EINVAL;
  6634		}
  6635		flag = (in_atomic() || irqs_disabled()) ? GFP_ATOMIC : GFP_KERNEL;
  6636		string = kzalloc(TX_FRAME_STR_LEN, flag);
  6637		if (string == NULL)
  6638			return -ENOMEM;
  6639	
  6640		moal_memcpy_ext(NULL, string, s + strlen("tx_frame="),
  6641				len - strlen("tx_frame="), TX_FRAME_STR_LEN - 1);
  6642	
  6643		tmp = string;
  6644		string = strstrip(string);
  6645	
  6646		pos = strsep(&string, " \t");
  6647		if (pos)
  6648			d->enable = (t_u32)woal_string_to_number(pos);
  6649	
  6650		if (d->enable == MFALSE)
  6651			goto done;
  6652	
  6653		pos = strsep(&string, " \t");
  6654		if (pos)
  6655			d->data_rate = (t_u32)woal_string_to_number(pos);
  6656	
  6657		pos = strsep(&string, " \t");
  6658		if (pos)
  6659			d->frame_pattern = (t_u32)woal_string_to_number(pos);
  6660	
  6661		pos = strsep(&string, " \t");
  6662		if (pos)
  6663			d->frame_length = (t_u32)woal_string_to_number(pos);
  6664	
  6665		pos = strsep(&string, " \t");
  6666		if (pos)
  6667			d->adjust_burst_sifs = (t_u16)woal_string_to_number(pos);
  6668	
  6669		pos = strsep(&string, " \t");
  6670		if (pos)
  6671			d->burst_sifs_in_us = (t_u32)woal_string_to_number(pos);
  6672	
  6673		pos = strsep(&string, " \t");
  6674		if (pos)
  6675			d->short_preamble = (t_u32)woal_string_to_number(pos);
  6676	
  6677		pos = strsep(&string, " \t");
  6678		if (pos)
  6679			d->act_sub_ch = (t_u32)woal_string_to_number(pos);
  6680	
  6681		pos = strsep(&string, " \t");
  6682		if (pos)
  6683			d->short_gi = (t_u32)woal_string_to_number(pos);
  6684	
  6685		pos = strsep(&string, " \t");
  6686		if (pos)
  6687			d->adv_coding = (t_u32)woal_string_to_number(pos);
  6688	
  6689		pos = strsep(&string, " \t");
  6690		if (pos)
  6691			d->tx_bf = (t_u32)woal_string_to_number(pos);
  6692	
  6693		pos = strsep(&string, " \t");
  6694		if (pos)
  6695			d->gf_mode = (t_u32)woal_string_to_number(pos);
  6696	
  6697		pos = strsep(&string, " \t");
  6698		if (pos)
  6699			d->stbc = (t_u32)woal_string_to_number(pos);
  6700	
  6701		pos = strsep(&string, " \t");
  6702		if (pos) {
  6703			for (i = 0; i < ETH_ALEN; i++) {
  6704				pos = strsep(&string, ":");
  6705				if (pos)
  6706					d->bssid[i] = woal_atox(pos);
  6707			}
  6708		}
  6709	
  6710		if ((d->enable > 1) || (d->frame_length == 0) ||
  6711		    (d->adjust_burst_sifs > 1) || (d->burst_sifs_in_us > 255) ||
  6712		    (d->short_preamble > 1) ||
  6713		    (d->act_sub_ch == 2 || d->act_sub_ch > 3) || (d->short_gi > 1) ||
  6714		    (d->adv_coding > 1) || (d->tx_bf > 1) || (d->gf_mode > 1) ||
  6715		    (d->stbc > 1))
  6716			ret = -EINVAL;
  6717	done:
  6718		kfree(tmp);
  6719		LEAVE();
  6720		return ret;
  6721	}
  6722	/**
  6723	 *  @brief This function enables/disables RF test mode in firmware
  6724	 *
  6725	 *  @param handle   A pointer to moal_handle structure
  6726	 *  @return         MLAN_STATUS_SUCCESS/MLAN_STATUS_PENDING on success,
  6727	 *                  otherwise failure code
  6728	 */
  6729	mlan_status woal_process_rf_test_mode(moal_handle *handle, t_u32 mode)
  6730	{
  6731		mlan_status ret = MLAN_STATUS_FAILURE;
  6732		mlan_ioctl_req *req = NULL;
  6733		mlan_ds_misc_cfg *misc = NULL;
  6734		t_u32 flag = 0;
  6735	
  6736		ENTER();
  6737	#ifdef MFG_CMD_SUPPORT
  6738		if (mfg_mode) {
  6739			LEAVE();
  6740			return ret;
  6741		}
  6742	#endif
  6743		if (mode != MFG_CMD_SET_TEST_MODE && mode != MFG_CMD_UNSET_TEST_MODE) {
  6744			LEAVE();
  6745			return ret;
  6746		}
  6747	
  6748		req = woal_alloc_mlan_ioctl_req(sizeof(mlan_ds_misc_cfg));
  6749		if (req) {
  6750			misc = (mlan_ds_misc_cfg *)req->pbuf;
  6751			misc->sub_command = MLAN_OID_MISC_RF_TEST_GENERIC;
  6752			req->req_id = MLAN_IOCTL_MISC_CFG;
  6753			req->action = MLAN_ACT_SET;
  6754			if (mode == MFG_CMD_SET_TEST_MODE)
  6755				misc->param.mfg_generic_cfg.mfg_cmd =
  6756					MFG_CMD_SET_TEST_MODE;
  6757			ret = woal_request_ioctl(woal_get_priv(handle,
  6758							       MLAN_BSS_ROLE_ANY),
  6759						 req, MOAL_IOCTL_WAIT);
  6760		}
  6761	
  6762		if (ret == MLAN_STATUS_SUCCESS && mode == MFG_CMD_SET_TEST_MODE &&
  6763		    handle->rf_data == NULL) {
> 6764			flag = (in_atomic() || irqs_disabled()) ? GFP_ATOMIC :
  6765								  GFP_KERNEL;
  6766			/* Allocate memory to hold RF test mode data */
  6767			handle->rf_data =
> 6768				kzalloc(sizeof(struct rf_test_mode_data), flag);
  6769			if (!handle->rf_data)
  6770				PRINTM(MERROR,
  6771				       "Couldn't allocate memory for RF test mode\n");
  6772			handle->rf_test_mode = MTRUE;
  6773			if (handle->rf_data) {
  6774				/* antenna is set to 1 by default */
  6775				handle->rf_data->tx_antenna = 1;
  6776				handle->rf_data->rx_antenna = 1;
  6777			}
  6778		} else if (mode == MFG_CMD_UNSET_TEST_MODE) {
  6779			if (handle->rf_data) {
  6780				/* Free RF test mode data memory */
  6781				kfree(handle->rf_data);
  6782				handle->rf_data = NULL;
  6783			}
  6784			handle->rf_test_mode = MFALSE;
  6785		}
  6786		if (ret != MLAN_STATUS_PENDING)
  6787			kfree(req);
  6788		LEAVE();
  6789		return ret;
  6790	}
  6791	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38592 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [RFC PATCH freescale-fslc] MLK-24458 net: wireless: nxp: mxm_wifiex: woal_uap_update_11ax_ie() can be static
  2021-09-28  2:50 [freescale-fslc:5.4-2.3.x-imx 12229/21308] drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6764:22: sparse: sparse: incorrect type in assignment (different base types) kernel test robot
@ 2021-09-28  2:50 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2021-09-28  2:50 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2389 bytes --]

drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c:4244:6: warning: symbol 'woal_uap_update_11ax_ie' was not declared. Should it be static?
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c:2270:6: warning: symbol 'woal_assoc_resp_event' was not declared. Should it be static?

Fixes: ec10135c1935 ("MLK-24458 net: wireless: nxp: mxm_wifiex: upgrade to mxm4x17186 release")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c     |    2 +-
 drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c
index 5b3abded4ccd3..529ec4b02fb5d 100644
--- a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c
+++ b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.c
@@ -4241,7 +4241,7 @@ Bit75: 0x1 (Rx 1024-QAM Support < 242-tone RU)
  *
  *  @return         0--success, otherwise failure
  */
-void woal_uap_update_11ax_ie(t_u8 band, mlan_ds_11ax_he_capa *hecap_ie)
+static void woal_uap_update_11ax_ie(t_u8 band, mlan_ds_11ax_he_capa *hecap_ie)
 {
 	if (band == BAND_5GHZ) {
 		hecap_ie->he_mac_cap[0] &= UAP_HE_MAC_CAP0_MASK;
diff --git a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c
index 38d3ea66d574d..97572342ba0a3 100644
--- a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c
+++ b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_sta_cfg80211.c
@@ -2267,8 +2267,8 @@ void woal_host_mlme_process_assoc_resp(moal_private *priv,
  * @return          N/A
  */
 
-void woal_assoc_resp_event(moal_private *priv,
-			   mlan_ds_misc_assoc_rsp *passoc_rsp)
+static void woal_assoc_resp_event(moal_private *priv,
+				  mlan_ds_misc_assoc_rsp *passoc_rsp)
 {
 	struct woal_event *evt;
 	unsigned long flags;
diff --git a/scripts/spdxcheck-test.sh b/scripts/spdxcheck-test.sh
old mode 100644
new mode 100755
diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh
old mode 100644
new mode 100755

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-28  2:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-28  2:50 [freescale-fslc:5.4-2.3.x-imx 12229/21308] drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_ioctl.c:6764:22: sparse: sparse: incorrect type in assignment (different base types) kernel test robot
2021-09-28  2:50 ` [RFC PATCH freescale-fslc] MLK-24458 net: wireless: nxp: mxm_wifiex: woal_uap_update_11ax_ie() can be static kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.