From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D3D0C433F5 for ; Tue, 28 Sep 2021 12:14:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0282A611CB for ; Tue, 28 Sep 2021 12:14:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0282A611CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56902 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mVC0Y-00051S-6f for qemu-devel@archiver.kernel.org; Tue, 28 Sep 2021 08:14:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVBxp-0008VM-BV for qemu-devel@nongnu.org; Tue, 28 Sep 2021 08:12:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVBxn-0000pR-V3 for qemu-devel@nongnu.org; Tue, 28 Sep 2021 08:12:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632831119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZZrk8Sa31YIbiWVmHJ66JNKhskis3QqPpmnw51WX2/o=; b=gL5/y1sBVnvKZdiso0pp3iSXaX9HHAIYAejczWjZM6YsaOdwJR/y7fm3wvBHLzU/WVF7uQ YfQCYo2A/JXqKkO2lwF3LeJ9+b7c6iOJP3qBOyCeQnU0sINQnttH4VC/MZEqUt5ANipgZA iWWJ64qTS495IqUThTJwpSGnLUBeaO0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-o7oXnew_MLSAw8AUsBogmg-1; Tue, 28 Sep 2021 08:11:49 -0400 X-MC-Unique: o7oXnew_MLSAw8AUsBogmg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C923F19253C0; Tue, 28 Sep 2021 12:11:45 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59FE7100164A; Tue, 28 Sep 2021 12:11:28 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9934C18003B6; Tue, 28 Sep 2021 14:11:26 +0200 (CEST) Date: Tue, 28 Sep 2021 14:11:26 +0200 From: Gerd Hoffmann To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 09/29] tcg/module: add tcg-module.[ch] infrastructure Message-ID: <20210928121126.6t6zyrlp5dmxqdtv@sirius.home.kraxel.org> References: <20210831121545.2874233-1-kraxel@redhat.com> <20210831121545.2874233-10-kraxel@redhat.com> <5e36f960-7b40-a55b-ddba-1f635a39941a@redhat.com> MIME-Version: 1.0 In-Reply-To: <5e36f960-7b40-a55b-ddba-1f635a39941a@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Bin Meng , David Hildenbrand , qemu-devel@nongnu.org, Peter Xu , Max Filippov , Alistair Francis , "Edgar E. Iglesias" , Alexandre Iooss , Huacai Chen , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Stafford Horne , Alex =?utf-8?Q?Benn=C3=A9e?= , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , Laurent Vivier , qemu-ppc@nongnu.org, Paolo Bonzini , Mahmoud Mandour , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > > +struct TCGModuleOps { > > +}; > > +extern struct TCGModuleOps tcg; > > TCG functions taking a CPUState argument should reside in > CPUClass's AccelCPUClass/TCGCPUOps, not a global struct. It's not that easy. Tried that first, but using TCGCPUOps outside cpu code doesn't work. take care, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mVBxn-0008SN-D3 for mharc-qemu-riscv@gnu.org; Tue, 28 Sep 2021 08:11:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVBxj-0008MD-BU for qemu-riscv@nongnu.org; Tue, 28 Sep 2021 08:11:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mVBxg-0000ku-60 for qemu-riscv@nongnu.org; Tue, 28 Sep 2021 08:11:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632831110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZZrk8Sa31YIbiWVmHJ66JNKhskis3QqPpmnw51WX2/o=; b=RCW5fUc0po0jFcItvakEF/UY+m3kG7/gFnsQKFQXtoK+RVapSsSm7nn+W7vzmZOz2BFkwp KHixm1ru3mn0bhOPUAmf+3Q+ENa655HSdebRp535hEO9o+Wa6RvIONc1yJkiy65SfH5aDz 2jiWHkUFjwwZjHZjo2hhxTE5i0JT5dQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-o7oXnew_MLSAw8AUsBogmg-1; Tue, 28 Sep 2021 08:11:49 -0400 X-MC-Unique: o7oXnew_MLSAw8AUsBogmg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C923F19253C0; Tue, 28 Sep 2021 12:11:45 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59FE7100164A; Tue, 28 Sep 2021 12:11:28 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 9934C18003B6; Tue, 28 Sep 2021 14:11:26 +0200 (CEST) Date: Tue, 28 Sep 2021 14:11:26 +0200 From: Gerd Hoffmann To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Aurelien Jarno , Laurent Vivier , Peter Xu , Peter Maydell , Marcel Apfelbaum , Cornelia Huck , qemu-ppc@nongnu.org, Bastian Koppelmann , Thomas Huth , Eduardo Habkost , qemu-riscv@nongnu.org, David Gibson , Aleksandar Rikalo , Stafford Horne , Huacai Chen , Halil Pasic , Palmer Dabbelt , Bin Meng , Mahmoud Mandour , Max Filippov , Alexandre Iooss , Greg Kurz , "Edgar E. Iglesias" , Richard Henderson , qemu-arm@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , "Michael S. Tsirkin" , Paolo Bonzini , Alistair Francis , qemu-s390x@nongnu.org, Christian Borntraeger , Jiaxun Yang , David Hildenbrand Subject: Re: [PATCH 09/29] tcg/module: add tcg-module.[ch] infrastructure Message-ID: <20210928121126.6t6zyrlp5dmxqdtv@sirius.home.kraxel.org> References: <20210831121545.2874233-1-kraxel@redhat.com> <20210831121545.2874233-10-kraxel@redhat.com> <5e36f960-7b40-a55b-ddba-1f635a39941a@redhat.com> MIME-Version: 1.0 In-Reply-To: <5e36f960-7b40-a55b-ddba-1f635a39941a@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 12:11:55 -0000 Hi, > > +struct TCGModuleOps { > > +}; > > +extern struct TCGModuleOps tcg; > > TCG functions taking a CPUState argument should reside in > CPUClass's AccelCPUClass/TCGCPUOps, not a global struct. It's not that easy. Tried that first, but using TCGCPUOps outside cpu code doesn't work. take care, Gerd