All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [RFC PATCH freescale-fslc] MLK-25112: net: wireless: nxp: mxm_wifiex: woal_check_media_connected() can be static
Date: Tue, 28 Sep 2021 20:54:05 +0800	[thread overview]
Message-ID: <20210928125405.GA54529@04eac9d2ae97> (raw)
In-Reply-To: <202109282026.FQlUc5pt-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 4745 bytes --]

drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c:1451:5: warning: symbol 'woal_check_media_connected' was not declared. Should it be static?
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c:1472:6: warning: symbol 'moal_connection_status_check_pmqos' was not declared. Should it be static?
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c:5434:5: warning: symbol 'woal_start_xmit' was not declared. Should it be static?
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c:8305:16: warning: symbol 'woal_skb_dequeue_spinlock' was not declared. Should it be static?
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c:8322:8: warning: symbol 'woal_tx_work_handler' was not declared. Should it be static?
drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c:14923:5: warning: symbol 'woal_priv_set_tp_state' was not declared. Should it be static?

Fixes: 1599bbb24319 ("MLK-25112: net: wireless: nxp: mxm_wifiex: upgrade to mxm5x16215 release")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c |    2 +-
 drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c      |    6 +++---
 drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c      |    4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c
index 60d229b2abbe0..6c3be6fb91cd0 100644
--- a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c
+++ b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c
@@ -14920,7 +14920,7 @@ void woal_set_tp_state(moal_private *priv)
  *
  *  @return             Number of bytes written, negative for failure.
  */
-int woal_priv_set_tp_state(moal_private *priv, t_u8 *respbuf, t_u32 respbuflen)
+static int woal_priv_set_tp_state(moal_private *priv, t_u8 *respbuf, t_u32 respbuflen)
 {
 	moal_handle *handle = priv->phandle;
 	int ret = 0;
diff --git a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c
index f7d66598accc8..6d1cface8533b 100644
--- a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c
+++ b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_main.c
@@ -5431,7 +5431,7 @@ int woal_process_tcp_ack(moal_private *priv, mlan_buffer *pmbuf)
  *
  *  @return        0 --success
  */
-int woal_start_xmit(moal_private *priv, struct sk_buff *skb)
+static int woal_start_xmit(moal_private *priv, struct sk_buff *skb)
 {
 	mlan_buffer *pmbuf = NULL;
 	mlan_status status;
@@ -8302,7 +8302,7 @@ t_void woal_rx_work_queue(struct work_struct *work)
  *  @return        skb buffer
  */
 
-struct sk_buff *woal_skb_dequeue_spinlock(struct sk_buff_head *list)
+static struct sk_buff *woal_skb_dequeue_spinlock(struct sk_buff_head *list)
 {
 	struct sk_buff *result;
 
@@ -8319,7 +8319,7 @@ struct sk_buff *woal_skb_dequeue_spinlock(struct sk_buff_head *list)
  *
  *  @return        N/A
  */
-t_void woal_tx_work_handler(struct work_struct *work)
+static t_void woal_tx_work_handler(struct work_struct *work)
 {
 	moal_handle *handle = container_of(work, moal_handle, tx_work);
 	moal_private *priv = NULL;
diff --git a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c
index ff3b593e9c1c3..76ac5adc56aad 100644
--- a/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c
+++ b/drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c
@@ -1448,7 +1448,7 @@ mlan_status moal_recv_packet(t_void *pmoal_handle, pmlan_buffer pmbuf)
  *  @param pmoal_handle Pointer to the MOAL context
  *
  */
-int woal_check_media_connected(t_void *pmoal_handle)
+static int woal_check_media_connected(t_void *pmoal_handle)
 {
 	int i;
 	moal_handle *pmhandle = (moal_handle *)pmoal_handle;
@@ -1469,7 +1469,7 @@ int woal_check_media_connected(t_void *pmoal_handle)
  *  @param pmoal_handle Pointer to the MOAL context
  *
  */
-void moal_connection_status_check_pmqos(t_void *pmoal_handle)
+static void moal_connection_status_check_pmqos(t_void *pmoal_handle)
 {
 	moal_handle *pmhandle = (moal_handle *)pmoal_handle;
 	if ((woal_check_media_connected(pmoal_handle) == MTRUE)) {
diff --git a/scripts/spdxcheck-test.sh b/scripts/spdxcheck-test.sh
old mode 100644
new mode 100755
diff --git a/scripts/xen-hypercalls.sh b/scripts/xen-hypercalls.sh
old mode 100644
new mode 100755

      reply	other threads:[~2021-09-28 12:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 12:54 [freescale-fslc:pr/317 16/48] drivers/net/wireless/nxp/mxm_wifiex/wlan_src/mlinux/moal_shim.c:1451:5: sparse: sparse: symbol 'woal_check_media_connected' was not declared. Should it be static? kernel test robot
2021-09-28 12:54 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210928125405.GA54529@04eac9d2ae97 \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.