All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: jsnow@redhat.com
Subject: [PATCH 0/3] python: remove socket_scm_helper
Date: Tue, 28 Sep 2021 15:53:05 +0200	[thread overview]
Message-ID: <20210928135309.199796-1-pbonzini@redhat.com> (raw)

I suspect no one has ever looked at socket_scm_helper.c, because when I
did my reaction was just "why".  The functionality of this 136-line program
can be reproduced in Python with fewer lines of code than it takes to
invoke it.  Do it, and let it rest in peace.

The only reason not to do that could be because of the upcoming switch
to aqmp.  For that, the new send_fd method has to be wrapped to use
transport.get_extra_info('socket') and loop.run_in_executor.  Let me
know if you prefer to hold on this until later.

Paolo

Paolo Bonzini (4):
  python: stop using socket_scm_helper
  socket_scm_helper: remove
  python: raise OSError from send_fd_scm
  python: split the two sides of send_fd_scm

 python/qemu/machine/machine.py         |  58 +++--------
 python/qemu/machine/qtest.py           |   2 -
 python/qemu/qmp/__init__.py            |  15 +++
 tests/Makefile.include                 |   5 +-
 tests/meson.build                      |   4 -
 tests/qemu-iotests/045                 |   3 +-
 tests/qemu-iotests/147                 |   3 +-
 tests/qemu-iotests/iotests.py          |   3 -
 tests/qemu-iotests/meson.build         |   5 -
 tests/qemu-iotests/socket_scm_helper.c | 136 -------------------------
 tests/qemu-iotests/testenv.py          |   8 +-
 11 files changed, 35 insertions(+), 207 deletions(-)
 delete mode 100644 tests/qemu-iotests/meson.build
 delete mode 100644 tests/qemu-iotests/socket_scm_helper.c

-- 
2.31.1



             reply	other threads:[~2021-09-28 13:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 13:53 Paolo Bonzini [this message]
2021-09-28 13:53 ` [PATCH 1/4] python: stop using socket_scm_helper Paolo Bonzini
2021-09-28 13:53 ` [PATCH 2/4] socket_scm_helper: remove Paolo Bonzini
2021-09-28 13:53 ` [PATCH 3/4] python: raise OSError from send_fd_scm Paolo Bonzini
2021-09-28 13:53 ` [PATCH 4/4] python: split the two sides of send_fd_scm Paolo Bonzini
2021-09-28 17:46 ` [PATCH 0/3] python: remove socket_scm_helper John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210928135309.199796-1-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.