From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469D7C433F5 for ; Tue, 28 Sep 2021 18:22:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DA316136A for ; Tue, 28 Sep 2021 18:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242152AbhI1SYH (ORCPT ); Tue, 28 Sep 2021 14:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242162AbhI1SYE (ORCPT ); Tue, 28 Sep 2021 14:24:04 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34C1AC06161C; Tue, 28 Sep 2021 11:22:25 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id g184so22098835pgc.6; Tue, 28 Sep 2021 11:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=knXL02VOmkFLU9YLWF/5g5SfaxjLRPWcMFGGkfQ2MJo=; b=YfTvKPMV9bMEJzY5iInORnexx/3hegz8PI3DEcB0pgPFaINO/RNHFnPjSryI+E57GO MyFTELurYhdgmIuVtrrTVeldLitYMvKwMESeCojCrKycjhi8vGLm8PZgSUhGeznN3JR1 bza7N91AlrXdoBa/8yC5N5VROau9/Y4fx9WnNIV7JOTC+eEaj+74ozgOzm+qAY2AdNo3 ueOXz/VmnWQNXkiQY3rTg0Fwmffn4r5cpMgPo6JNsS0shoD48F3VGqKOgNN923CkYf3O t+kqvH6aFEdXDkq1+B+CJu/KaHLxXGthwb9bmvYYL6Hobb0WIyPPBwCWyH0FUzK6pwCp /2Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=knXL02VOmkFLU9YLWF/5g5SfaxjLRPWcMFGGkfQ2MJo=; b=68ImWXbfycLf32H8vIFb8lduKYNzlNF06EaWTsxqIQtRp81Iivx0CyF6ear990JQFu VNz4xTvTzdGkRBx/u7tAKgBGUJ26B2911uvZRaBPoXgsVn4H4np8z4tz5aPiBQ1mxoY1 U6GsFeHgBRpUGoVrToZczPZy0HqVTqmSoiM++w7Z9MRPek59RYC/K5gDnBcy3Sxg7I/W VfMFLGenR1HTTi3dBkqC9n1nTNLBeYHRkh1Xh6dVlTG+6qvN9oZgQAJZy+i+X2WmMi+C rG219rpcws9QkQ8ADk7IjrOh+00qkra5w8Yl3vf+ONdQXlj0UNJ+TiJGVVjECklRMsNH pP7g== X-Gm-Message-State: AOAM531dba1DMq5ozlROzYHiSpGZL0X9+lr7wCxSkzTxLhMP8kfl0OEf mapDxZ/is5KOsvb5u7OuvqWdNzT+0T0= X-Google-Smtp-Source: ABdhPJzBkkkTfPaj6nkEz7iWLe04W8uwPzujCOo5VdzxnWQ+PdGxbj9GhnDWDX8j1UiqMe9Iw1umqg== X-Received: by 2002:a65:448a:: with SMTP id l10mr5712298pgq.313.1632853344389; Tue, 28 Sep 2021 11:22:24 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x19sm20855288pfn.105.2021.09.28.11.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 11:22:23 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v3 02/14] irqchip/irq-bcm7038-l1: Remove .irq_cpu_offline() Date: Tue, 28 Sep 2021 11:21:27 -0700 Message-Id: <20210928182139.652896-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210928182139.652896-1-f.fainelli@gmail.com> References: <20210928182139.652896-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With arch/mips/kernel/smp-bmips.c having been migrated away from irq_cpu_offline() and use irq_migrate_all_off_this_cpu() instead, we no longer need to implement an .irq_cpu_offline() callback. This is a necessary change to facilitate the building of this driver as a module. Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-bcm7038-l1.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index a035c385ca7a..750156217c82 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -221,33 +221,6 @@ static int bcm7038_l1_set_affinity(struct irq_data *d, return 0; } -#ifdef CONFIG_SMP -static void bcm7038_l1_cpu_offline(struct irq_data *d) -{ - struct cpumask *mask = irq_data_get_affinity_mask(d); - int cpu = smp_processor_id(); - cpumask_t new_affinity; - - /* This CPU was not on the affinity mask */ - if (!cpumask_test_cpu(cpu, mask)) - return; - - if (cpumask_weight(mask) > 1) { - /* - * Multiple CPU affinity, remove this CPU from the affinity - * mask - */ - cpumask_copy(&new_affinity, mask); - cpumask_clear_cpu(cpu, &new_affinity); - } else { - /* Only CPU, put on the lowest online CPU */ - cpumask_clear(&new_affinity); - cpumask_set_cpu(cpumask_first(cpu_online_mask), &new_affinity); - } - irq_set_affinity_locked(d, &new_affinity, false); -} -#endif - static int __init bcm7038_l1_init_one(struct device_node *dn, unsigned int idx, struct bcm7038_l1_chip *intc) @@ -396,9 +369,6 @@ static struct irq_chip bcm7038_l1_irq_chip = { .irq_mask = bcm7038_l1_mask, .irq_unmask = bcm7038_l1_unmask, .irq_set_affinity = bcm7038_l1_set_affinity, -#ifdef CONFIG_SMP - .irq_cpu_offline = bcm7038_l1_cpu_offline, -#endif #ifdef CONFIG_PM_SLEEP .irq_set_wake = bcm7038_l1_set_wake, #endif -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC070C433EF for ; Tue, 28 Sep 2021 18:26:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B0906137E for ; Tue, 28 Sep 2021 18:26:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7B0906137E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dX7z4Kl/qXNg24Rf2jbO+TrgQCc2vwgDm0pndgG8lAM=; b=xdmZqq2D+aHbIW 0gupKCAiTn4yo7JfIXUutwa/hCuG4zQxcohjxJvRROREB2cU5unYCerj+Zbi0TnyOUKiuu8bFolfk g2UPxirf++Iy1drI4c8DoxjzY6ZCDmYri+VISLDpJgZoVaS4OvnZS1o90cIK6JiwZc0dOtdTQkPHd RoFruRMHUM+YWOL3Tk/UzfBlCSegUr6NQa3ylX/GUcCkFu3TGF59DQ2s1L4Qv56DoQzzEi3/JXqgy Dcg9jC/itWHVERat6rskaBQTUCdwRY6gxlneAcHVxgNjQ6N0UiOx6HYYQ7QddYVtbkEUXD4GkGhXh kJjo//tpYR2t9BzUcZGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVHke-008OGc-Co; Tue, 28 Sep 2021 18:22:48 +0000 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVHkH-008O8x-I1 for linux-arm-kernel@lists.infradead.org; Tue, 28 Sep 2021 18:22:26 +0000 Received: by mail-pg1-x52e.google.com with SMTP id x191so15160023pgd.9 for ; Tue, 28 Sep 2021 11:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=knXL02VOmkFLU9YLWF/5g5SfaxjLRPWcMFGGkfQ2MJo=; b=YfTvKPMV9bMEJzY5iInORnexx/3hegz8PI3DEcB0pgPFaINO/RNHFnPjSryI+E57GO MyFTELurYhdgmIuVtrrTVeldLitYMvKwMESeCojCrKycjhi8vGLm8PZgSUhGeznN3JR1 bza7N91AlrXdoBa/8yC5N5VROau9/Y4fx9WnNIV7JOTC+eEaj+74ozgOzm+qAY2AdNo3 ueOXz/VmnWQNXkiQY3rTg0Fwmffn4r5cpMgPo6JNsS0shoD48F3VGqKOgNN923CkYf3O t+kqvH6aFEdXDkq1+B+CJu/KaHLxXGthwb9bmvYYL6Hobb0WIyPPBwCWyH0FUzK6pwCp /2Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=knXL02VOmkFLU9YLWF/5g5SfaxjLRPWcMFGGkfQ2MJo=; b=vAnj8iBluJo2d3OksrL5cbQScWN+0t4m7qdX8N0ci1hbC+oWOCw8MpQ3n9ViV/DzJ/ MuqdC1XGTOkAPKPCFEuRtKKeApnzraNgTyvKQx56dg5wAdCYE2JrW47VlaehXff4LVA0 fVKSzl+lSBU8y4Yz6y17lRFpTLJLv5y+e0fyRsscJ5K7PnhSUBNVnQoaE8SQyDbAmxYO l8V56dbbnO73J+hQnxst9SmLsSdcOjGEgZi+lRbVMzGAgu4tEmO1lam7S4lR6wxkEI/e PrdCXNrGbzSoilPLeyiW6yO2pNJl6IUwawi5AgT1nd1EnREEOdof0+01wducK/YCDVBi 6ZVA== X-Gm-Message-State: AOAM531Zw+MA9VA9bFn41ZVcelKAhQ97cQ6w9ukEtcrfyYDakDY2cMaG dIgvEdysuhovoDlqIstDT+s= X-Google-Smtp-Source: ABdhPJzBkkkTfPaj6nkEz7iWLe04W8uwPzujCOo5VdzxnWQ+PdGxbj9GhnDWDX8j1UiqMe9Iw1umqg== X-Received: by 2002:a65:448a:: with SMTP id l10mr5712298pgq.313.1632853344389; Tue, 28 Sep 2021 11:22:24 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x19sm20855288pfn.105.2021.09.28.11.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 11:22:23 -0700 (PDT) From: Florian Fainelli To: linux-kernel@vger.kernel.org Cc: Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com (maintainer:BROADCOM BCM281XX/BCM11XXX/BCM216XX ARM ARCHITE...), Russell King , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Thomas Gleixner , Marc Zyngier , Rob Herring , Frank Rowand , linux-arm-kernel@lists.infradead.org (moderated list:ARM SUB-ARCHITECTURES), linux-mips@vger.kernel.org (open list:MIPS), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE) Subject: [PATCH v3 02/14] irqchip/irq-bcm7038-l1: Remove .irq_cpu_offline() Date: Tue, 28 Sep 2021 11:21:27 -0700 Message-Id: <20210928182139.652896-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210928182139.652896-1-f.fainelli@gmail.com> References: <20210928182139.652896-1-f.fainelli@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_112225_618497_142F4FDB X-CRM114-Status: GOOD ( 16.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org With arch/mips/kernel/smp-bmips.c having been migrated away from irq_cpu_offline() and use irq_migrate_all_off_this_cpu() instead, we no longer need to implement an .irq_cpu_offline() callback. This is a necessary change to facilitate the building of this driver as a module. Signed-off-by: Florian Fainelli --- drivers/irqchip/irq-bcm7038-l1.c | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/drivers/irqchip/irq-bcm7038-l1.c b/drivers/irqchip/irq-bcm7038-l1.c index a035c385ca7a..750156217c82 100644 --- a/drivers/irqchip/irq-bcm7038-l1.c +++ b/drivers/irqchip/irq-bcm7038-l1.c @@ -221,33 +221,6 @@ static int bcm7038_l1_set_affinity(struct irq_data *d, return 0; } -#ifdef CONFIG_SMP -static void bcm7038_l1_cpu_offline(struct irq_data *d) -{ - struct cpumask *mask = irq_data_get_affinity_mask(d); - int cpu = smp_processor_id(); - cpumask_t new_affinity; - - /* This CPU was not on the affinity mask */ - if (!cpumask_test_cpu(cpu, mask)) - return; - - if (cpumask_weight(mask) > 1) { - /* - * Multiple CPU affinity, remove this CPU from the affinity - * mask - */ - cpumask_copy(&new_affinity, mask); - cpumask_clear_cpu(cpu, &new_affinity); - } else { - /* Only CPU, put on the lowest online CPU */ - cpumask_clear(&new_affinity); - cpumask_set_cpu(cpumask_first(cpu_online_mask), &new_affinity); - } - irq_set_affinity_locked(d, &new_affinity, false); -} -#endif - static int __init bcm7038_l1_init_one(struct device_node *dn, unsigned int idx, struct bcm7038_l1_chip *intc) @@ -396,9 +369,6 @@ static struct irq_chip bcm7038_l1_irq_chip = { .irq_mask = bcm7038_l1_mask, .irq_unmask = bcm7038_l1_unmask, .irq_set_affinity = bcm7038_l1_set_affinity, -#ifdef CONFIG_SMP - .irq_cpu_offline = bcm7038_l1_cpu_offline, -#endif #ifdef CONFIG_PM_SLEEP .irq_set_wake = bcm7038_l1_set_wake, #endif -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel