From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79B663FD3 for ; Wed, 29 Sep 2021 13:40:07 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 632EC6137A; Wed, 29 Sep 2021 13:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632922807; bh=HRxvn3IUjfecEGEfskFUy3y0BDqwSgrQjWLQzEOJJgw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RTPVEKKDWu8xLuOVgrWyDppGS6t0eE5njBJgD1i3idYi2+uHPuZa5cxEcjeFQ3cZe 6NABzyvWfwl476XJU0PdI98Izs20RoC9vvAoAveJEZuCn+cAfihiwiMabw0KRLU2e+ TjWVzaCDWGdqoHQJP8rzeE3N3fWPyiTmO527AagTY9mO2loOHnXdQV7WiMI4gLE6vU ul6sdJZ8l6+2P15LTHORFb07eoWaQztgWFnh43dsVGZ4Hd/JzdNsuR4airw1rBFwB3 v8FM8IQp926Dnl24p7J95hZj1aT8hWczKBdj0YqITOJZkMf+W5a/5yeHOFVImIQmNU 0lw8wtPminwVw== Date: Wed, 29 Sep 2021 06:40:04 -0700 From: Jakub Kicinski To: Leon Romanovsky Cc: "David S . Miller" , Leon Romanovsky , Alexandre Belloni , Andrew Lunn , Ariel Elior , Bin Luo , Claudiu Manoil , Coiby Xu , Derek Chickles , drivers@pensando.io, Eric Dumazet , Felix Manlunas , Florian Fainelli , Geetha sowjanya , Greg Kroah-Hartman , GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com, hariprasad , Ido Schimmel , intel-wired-lan@lists.osuosl.org, Ioana Ciornei , Jerin Jacob , Jesse Brandeburg , Jiri Pirko , Jonathan Lemon , Linu Cherian , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev, Manish Chopra , Michael Chan , Moshe Shemesh , netdev@vger.kernel.org, oss-drivers@corigine.com, Richard Cochran , Saeed Mahameed , Salil Mehta , Satanand Burla , Shannon Nelson , Shay Drory , Simon Horman , Subbaraya Sundeep , Sunil Goutham , Taras Chornyi , Tariq Toukan , Tony Nguyen , UNGLinuxDriver@microchip.com, Vadym Kochan , Vivien Didelot , Vladimir Oltean , Yisen Zhuang Subject: Re: [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Message-ID: <20210929064004.3172946e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 29 Sep 2021 15:00:41 +0300 Leon Romanovsky wrote: > This series starts from the fixing the bug introduced by implementing > devlink delayed notifications logic, where I missed some of the > notifications functions. > > The rest series provides a way to dynamically set devlink ops that is > needed for mlx5 multiport device and starts cleanup by removing > not-needed logic. > > In the next series, we will delete various publish API, drop general > lock, annotate the code and rework logic around devlink->lock. > > All this is possible because driver initialization is separated from the > user input now. Swapping ops is a nasty hack in my book. And all that to avoid having two op structures in one driver. Or to avoid having counters which are always 0? Sorry, at the very least you need better explanation for this. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Wed, 29 Sep 2021 06:40:04 -0700 Subject: [Intel-wired-lan] [PATCH net-next v1 0/5] Devlink reload and missed notifications fix In-Reply-To: References: Message-ID: <20210929064004.3172946e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, 29 Sep 2021 15:00:41 +0300 Leon Romanovsky wrote: > This series starts from the fixing the bug introduced by implementing > devlink delayed notifications logic, where I missed some of the > notifications functions. > > The rest series provides a way to dynamically set devlink ops that is > needed for mlx5 multiport device and starts cleanup by removing > not-needed logic. > > In the next series, we will delete various publish API, drop general > lock, annotate the code and rework logic around devlink->lock. > > All this is possible because driver initialization is separated from the > user input now. Swapping ops is a nasty hack in my book. And all that to avoid having two op structures in one driver. Or to avoid having counters which are always 0? Sorry, at the very least you need better explanation for this.