From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A0FC433EF for ; Wed, 29 Sep 2021 13:27:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA70C61452 for ; Wed, 29 Sep 2021 13:27:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235524AbhI2N3b (ORCPT ); Wed, 29 Sep 2021 09:29:31 -0400 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:41655 "EHLO wnew2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229846AbhI2N3a (ORCPT ); Wed, 29 Sep 2021 09:29:30 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 79F072B011A1; Wed, 29 Sep 2021 09:27:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 29 Sep 2021 09:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=6C/iJ1ffI9rUTpcaRyBkXlkx1Zb QQSzY1AH6rDwK+gA=; b=GkkoLWN3ri9d+BfDmgSm2OKR/XM+FqAmQhi5SYtoSlK sT4AQMylXQVJotsD5eUckYqxMY9UmOn3v5wDXt9w/y88z8qVHwAcqBkYJ8VwINPM bcu47E9plfgPbvaRzRrqTT9ZveQLXULZnvXRxhfgBln8wMfQ5HQAR2jbm79DHYvc jS03fLGlo6J+MBQVhIPyF79eC4lQ/GNF4AXGZqr5Wn9f3MVcVB41+SK7gduU33sb fIsZLmNtoCN+hb2Stf5n2feT7JkLaq+4cr2JSkJlK4Ln6uZSRZbHPbGqO2LMugIX eHvl+Xw6hOyXpiJR+ReFlbb5Z1QgYejkKupntmk+wtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6C/iJ1 ffI9rUTpcaRyBkXlkx1ZbQQSzY1AH6rDwK+gA=; b=cRxhesrhf48+fFs+bZQONN SD6ToSeTE2KbD3yjtbqLKmOXeHgGTMB8efTcWkQS6e28Y4aBRoH4EBbUHNsegF8C Khmew77Af076NbK2AN62gRm+wEO/T6koUVz/iIrQq0+FnETl74rHHIs0/9kG+MA+ O6uStJzfSGCooUoI0ZZrW4DMFqGGkaDDFiDrG7Tjl4R6OZ1l5tQ/ABHwl1vaZnBP 68RCbNK3HC1yHECJPC3ZXCmQk6x9RZgX3y5rZxcZyjcRidx0eBjI71OhEW/nHCzn UPFFg8JYc7iU+cmLhMnFJbRk3oHJZVo4oIWbbcPd1GcA/L/Bq+g24ijkKzIhgH7g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 09:27:47 -0400 (EDT) Date: Wed, 29 Sep 2021 15:27:44 +0200 From: Maxime Ripard To: nicolas saenz julienne Cc: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds Subject: Re: [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Message-ID: <20210929132744.ursafra4jajpmljg@gilmour> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-3-maxime@cerno.tech> <1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k7dl7qcxxmtg7pfs" Content-Disposition: inline In-Reply-To: <1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org --k7dl7qcxxmtg7pfs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 28, 2021 at 06:26:55PM +0200, nicolas saenz julienne wrote: > On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > > The driver, once it found a divider, tries to round it up by increasing > > the least significant bit of the fractional part by one when the > > round_up argument is set and there's a remainder. > >=20 > > However, since it increases the divider it will actually reduce the > > clock rate below what we were asking for, leading to issues with > > clk_set_min_rate() that will complain that our rounded clock rate is > > below the minimum of the rate. > >=20 > > Since the dividers are fairly precise already, let's remove that part so > > that we can have clk_set_min_rate() working. > >=20 > > This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round > > up ability to the clock divisor"). > >=20 > > Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock= divisor") > > Signed-off-by: Maxime Ripard > > --- >=20 > Reviewed-by: Nicolas Saenz Julienne > Tested-by: Nicolas Saenz Julienne # boot and basic fu= nctionality Does that mean you're ok with merging it through the DRM-misc tree? Florian, Mike, Stephen, any objection? Maxime --k7dl7qcxxmtg7pfs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYVRp0AAKCRDj7w1vZxhR xSWSAP9XndCsJarnvHMEXFLHhCdYgDMbnHRCxZttFGFS4pAP6gEAzwFfFa+DnjcF dhUDt6RJQPGoYz/lejjdLlzIvSIkeg8= =7O+H -----END PGP SIGNATURE----- --k7dl7qcxxmtg7pfs-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7371DC433EF for ; Wed, 29 Sep 2021 13:30:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E813F61353 for ; Wed, 29 Sep 2021 13:30:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E813F61353 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rtuqrgHSxgRyn9KsxTTi12OfRq3SDsw42jILnYr5RkM=; b=gjXJ7OFp/CUSZHCPwHCpy4WeMw Dtb8D5xx/M7YuMfkbiqTQV8+2+4ckRuE66cF/ACESbQjM/Q29DRvbXO6w1S7wtzeDq00WfpS4fAAD 7yiSDHS3sUfrELKIf+dlfxrkbK9tLwHDZ/+GNyuWpOxz+8oA5J3hwPEP9X7HTSrG0acSr2xz/CUrM iBpPlYQAIpBCpN6SSV3PKKPHP3eQ3LS2HjB9TZjjc6RgAn7Yin6j7uMffqjSqJultk37mzvXwmYH+ gHNeys0wHAGI9trd8zdzC1ARdocpnM/vzHILRy3Q4y1oih8hWKq2CLcoZEF1j6j8Q6UunzzmRnxv5 k9mnZgpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVZcq-00B8ZK-SN; Wed, 29 Sep 2021 13:27:57 +0000 Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVZcn-00B8Yj-2E; Wed, 29 Sep 2021 13:27:54 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 79F072B011A1; Wed, 29 Sep 2021 09:27:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 29 Sep 2021 09:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=6C/iJ1ffI9rUTpcaRyBkXlkx1Zb QQSzY1AH6rDwK+gA=; b=GkkoLWN3ri9d+BfDmgSm2OKR/XM+FqAmQhi5SYtoSlK sT4AQMylXQVJotsD5eUckYqxMY9UmOn3v5wDXt9w/y88z8qVHwAcqBkYJ8VwINPM bcu47E9plfgPbvaRzRrqTT9ZveQLXULZnvXRxhfgBln8wMfQ5HQAR2jbm79DHYvc jS03fLGlo6J+MBQVhIPyF79eC4lQ/GNF4AXGZqr5Wn9f3MVcVB41+SK7gduU33sb fIsZLmNtoCN+hb2Stf5n2feT7JkLaq+4cr2JSkJlK4Ln6uZSRZbHPbGqO2LMugIX eHvl+Xw6hOyXpiJR+ReFlbb5Z1QgYejkKupntmk+wtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=6C/iJ1 ffI9rUTpcaRyBkXlkx1ZbQQSzY1AH6rDwK+gA=; b=cRxhesrhf48+fFs+bZQONN SD6ToSeTE2KbD3yjtbqLKmOXeHgGTMB8efTcWkQS6e28Y4aBRoH4EBbUHNsegF8C Khmew77Af076NbK2AN62gRm+wEO/T6koUVz/iIrQq0+FnETl74rHHIs0/9kG+MA+ O6uStJzfSGCooUoI0ZZrW4DMFqGGkaDDFiDrG7Tjl4R6OZ1l5tQ/ABHwl1vaZnBP 68RCbNK3HC1yHECJPC3ZXCmQk6x9RZgX3y5rZxcZyjcRidx0eBjI71OhEW/nHCzn UPFFg8JYc7iU+cmLhMnFJbRk3oHJZVo4oIWbbcPd1GcA/L/Bq+g24ijkKzIhgH7g == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 09:27:47 -0400 (EDT) Date: Wed, 29 Sep 2021 15:27:44 +0200 From: Maxime Ripard To: nicolas saenz julienne Cc: Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds Subject: Re: [PATCH 2/5] clk: bcm-2835: Remove rounding up the dividers Message-ID: <20210929132744.ursafra4jajpmljg@gilmour> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-3-maxime@cerno.tech> <1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org> MIME-Version: 1.0 In-Reply-To: <1d94747e74061f05395c34a4c441f96823dbf53a.camel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_062753_389157_BEE9126E X-CRM114-Status: GOOD ( 20.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1725148081154750845==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1725148081154750845== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="k7dl7qcxxmtg7pfs" Content-Disposition: inline --k7dl7qcxxmtg7pfs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 28, 2021 at 06:26:55PM +0200, nicolas saenz julienne wrote: > On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > > The driver, once it found a divider, tries to round it up by increasing > > the least significant bit of the fractional part by one when the > > round_up argument is set and there's a remainder. > >=20 > > However, since it increases the divider it will actually reduce the > > clock rate below what we were asking for, leading to issues with > > clk_set_min_rate() that will complain that our rounded clock rate is > > below the minimum of the rate. > >=20 > > Since the dividers are fairly precise already, let's remove that part so > > that we can have clk_set_min_rate() working. > >=20 > > This is effectively a revert of 9c95b32ca093 ("clk: bcm2835: add a round > > up ability to the clock divisor"). > >=20 > > Fixes: 9c95b32ca093 ("clk: bcm2835: add a round up ability to the clock= divisor") > > Signed-off-by: Maxime Ripard > > --- >=20 > Reviewed-by: Nicolas Saenz Julienne > Tested-by: Nicolas Saenz Julienne # boot and basic fu= nctionality Does that mean you're ok with merging it through the DRM-misc tree? Florian, Mike, Stephen, any objection? Maxime --k7dl7qcxxmtg7pfs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYVRp0AAKCRDj7w1vZxhR xSWSAP9XndCsJarnvHMEXFLHhCdYgDMbnHRCxZttFGFS4pAP6gEAzwFfFa+DnjcF dhUDt6RJQPGoYz/lejjdLlzIvSIkeg8= =7O+H -----END PGP SIGNATURE----- --k7dl7qcxxmtg7pfs-- --===============1725148081154750845== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1725148081154750845==--