From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90E4C433F5 for ; Wed, 29 Sep 2021 14:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BDB06140F for ; Wed, 29 Sep 2021 14:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344761AbhI2Oyz (ORCPT ); Wed, 29 Sep 2021 10:54:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:38804 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344618AbhI2Oyx (ORCPT ); Wed, 29 Sep 2021 10:54:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 26F716108F; Wed, 29 Sep 2021 14:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632927192; bh=ZXFeAykbe3FWDJHs3l07s5lyMtmL1ik905y6YTUAdNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O5WH2FzwlbnIS26FrCLvV1Ue7B7uJLnZiLu5E+PDWI/pjjZlFm+dIDbeNMansdXOM 3x+2Dp/nv4IN+/ct0CRn4oBM9JZ6EjOyQnlcNcubUnRVhkJmhJ/ljbhaFweqLJ8wlA cmSK+9sEWTsI2AsRt+hKhl99cCtTr/1PBQp2rx8f2ZVp2vhSmluDRXswcYTBtALvY5 /jACyU5Ia/jF9x2CFJq/MEFAYlSioLpNcuLRaVLwJJjH+Z4Q6mYiGaYvRDS8qctIty ssibvFEZCyT2HL+qEqmO+IC/CyyR2UBJ52BLuYbzpw5fGfOfML/OJcMxXgpP2BPIYY RsNrxHVSNPorA== Date: Wed, 29 Sep 2021 15:52:22 +0100 From: Mark Brown To: Simon Trimmer Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] ASoC: wm_adsp: Fix compilation when debugfs is disabled Message-ID: <20210929145222.GR4199@sirena.org.uk> References: <20210929145040.793252-1-simont@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5xr6Gr0irOxp3+3c" Content-Disposition: inline In-Reply-To: <20210929145040.793252-1-simont@opensource.cirrus.com> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --5xr6Gr0irOxp3+3c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 29, 2021 at 03:50:40PM +0100, Simon Trimmer wrote: > +#if IS_ENABLED(CONFIG_DEBUG_FS) > cs_dsp_init_debugfs(&dsp->cs_dsp, component->debugfs_root); > +#endif The more common pattern is to declare a static inline stub function instead of the prototype if debugfs is disabled. --5xr6Gr0irOxp3+3c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFUfaYACgkQJNaLcl1U h9BWVAf/cHwn2KpyrGKblOiTYsbswKKh0yuTZvFgjjc17LMet2Y4XSv+dV1NDVnO 9JJt1mhlTU70VtE9lgVP5e1nmQNMSoGKgPBgg9FvgITYXDLEEC14tjhd5MQOynld INPOk+XVQRWSejSrdkm+OTRbe6HyoDtbi2xnEcOhuwdEew5aidefO20IxpReCN00 iFTebQGL43HZuzy+8km4YvwUpGbwNrB4OhKIvr1wmycq9BSr5Rsnaz8F/fTy6fJn tr+cuySzDXT4Rzw/My4Q3s0H/cVqDVYyhF6pYgI9tr+Gg91P/I0VJEFkGTt06MWo su8Dk2aTjTZ0Z8Ud9bEfRzaLzI++4g== =xvyI -----END PGP SIGNATURE----- --5xr6Gr0irOxp3+3c-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE37EC433EF for ; Wed, 29 Sep 2021 14:54:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 211F361440 for ; Wed, 29 Sep 2021 14:54:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 211F361440 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B15B116D1; Wed, 29 Sep 2021 16:53:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B15B116D1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632927249; bh=ZXFeAykbe3FWDJHs3l07s5lyMtmL1ik905y6YTUAdNY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CsJVNZ1OcBaDwMEB8bjAc/wl+y2nbgn1qe34xpv+dH3IZT+pKfWHYruQuVzw5PpYS lI+xbN/U79VMaZBFbgbrWvAjgrzlkgwza6jTZdt15wFNbk7j76/J4YAxFUSBQ6M0bT X6l4NRsaunEcsRWB7AZL2Xfs71GWucHGDHvcw0Ok= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3D9BAF801F7; Wed, 29 Sep 2021 16:53:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3B0E7F80227; Wed, 29 Sep 2021 16:53:17 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A2175F80113 for ; Wed, 29 Sep 2021 16:53:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A2175F80113 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O5WH2Fzw" Received: by mail.kernel.org (Postfix) with ESMTPSA id 26F716108F; Wed, 29 Sep 2021 14:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632927192; bh=ZXFeAykbe3FWDJHs3l07s5lyMtmL1ik905y6YTUAdNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=O5WH2FzwlbnIS26FrCLvV1Ue7B7uJLnZiLu5E+PDWI/pjjZlFm+dIDbeNMansdXOM 3x+2Dp/nv4IN+/ct0CRn4oBM9JZ6EjOyQnlcNcubUnRVhkJmhJ/ljbhaFweqLJ8wlA cmSK+9sEWTsI2AsRt+hKhl99cCtTr/1PBQp2rx8f2ZVp2vhSmluDRXswcYTBtALvY5 /jACyU5Ia/jF9x2CFJq/MEFAYlSioLpNcuLRaVLwJJjH+Z4Q6mYiGaYvRDS8qctIty ssibvFEZCyT2HL+qEqmO+IC/CyyR2UBJ52BLuYbzpw5fGfOfML/OJcMxXgpP2BPIYY RsNrxHVSNPorA== Date: Wed, 29 Sep 2021 15:52:22 +0100 From: Mark Brown To: Simon Trimmer Subject: Re: [PATCH] ASoC: wm_adsp: Fix compilation when debugfs is disabled Message-ID: <20210929145222.GR4199@sirena.org.uk> References: <20210929145040.793252-1-simont@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5xr6Gr0irOxp3+3c" Content-Disposition: inline In-Reply-To: <20210929145040.793252-1-simont@opensource.cirrus.com> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, kernel test robot , lgirdwood@gmail.com, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --5xr6Gr0irOxp3+3c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 29, 2021 at 03:50:40PM +0100, Simon Trimmer wrote: > +#if IS_ENABLED(CONFIG_DEBUG_FS) > cs_dsp_init_debugfs(&dsp->cs_dsp, component->debugfs_root); > +#endif The more common pattern is to declare a static inline stub function instead of the prototype if debugfs is disabled. --5xr6Gr0irOxp3+3c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFUfaYACgkQJNaLcl1U h9BWVAf/cHwn2KpyrGKblOiTYsbswKKh0yuTZvFgjjc17LMet2Y4XSv+dV1NDVnO 9JJt1mhlTU70VtE9lgVP5e1nmQNMSoGKgPBgg9FvgITYXDLEEC14tjhd5MQOynld INPOk+XVQRWSejSrdkm+OTRbe6HyoDtbi2xnEcOhuwdEew5aidefO20IxpReCN00 iFTebQGL43HZuzy+8km4YvwUpGbwNrB4OhKIvr1wmycq9BSr5Rsnaz8F/fTy6fJn tr+cuySzDXT4Rzw/My4Q3s0H/cVqDVYyhF6pYgI9tr+Gg91P/I0VJEFkGTt06MWo su8Dk2aTjTZ0Z8Ud9bEfRzaLzI++4g== =xvyI -----END PGP SIGNATURE----- --5xr6Gr0irOxp3+3c--