From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F28E0C433F5 for ; Wed, 29 Sep 2021 15:06:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74870613A6 for ; Wed, 29 Sep 2021 15:06:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 74870613A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 099C480FA5; Wed, 29 Sep 2021 17:06:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="Qt5yFfRp"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C2B2380F3B; Wed, 29 Sep 2021 17:05:20 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on20629.outbound.protection.outlook.com [IPv6:2a01:111:f400:7d00::629]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3608380F5F for ; Wed, 29 Sep 2021 17:05:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dosvZNPphHci5f34QuJHImHwPjA2yZQMArCrLde3cHsRCNCbSXTVUTPbxvl4OXo33tmmJohOlEJqnih9k2qXiM53aa5gpUoXTIQLM09ilN7qlWErGb28mf+S7ga7YZTJh4VIZ+7AiS0lkwgCg2haOwbzg5bUS6DT9tKgzgyWFHQwA95f+fgOKkCxy/SfPS5ASAXQZK/9jQ5UunpGMVA0ClZ2voi/D5ThiyoqQ/MU9zrMDv+DOWdS2Lvx4sCTo4dDrKpmS596eIcnruvFzldPABF/yVM/2ANH/Tap8kySULRniOMe5/kVu6yfl+s4aWH5E5931su9jw81fdEVIFmeHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=BtMQ/vGiq3WtmN2+7VYqzYJKlMdnk4l68l3AMyg5E/I=; b=OLkLPUcd0r5V2LVdJtSsvW3nOPwoh5jl7kIcUbig5lf5qhE5BXEpRt/DHwT3tjsDaw4kaqfi4EoHfi2Kg32x2rgVNLEIc2hcAdRb6ZSfJ+RxzK4NYlbNPuBm0pUgRV8JNzjm5aKOUB7Lb99EnSL0dA+VE1nVFs+pJ7PaSlniKfcbqs5R5VFxtHmeP2lC0OuWgwFg/Myj+ITUJXO4EGb0Dl26Ea/8gihoX6ipVRY6EL/aHRkc8/22yNdRjjTbMnouIxhlOwf2S9I+mOVDjRdydNEzlIGeJ4NJmDt6/0mr9vaX86hDqxg3q3KDBjZOjuGZ0BKgmKK5zNumkYVEcplcKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BtMQ/vGiq3WtmN2+7VYqzYJKlMdnk4l68l3AMyg5E/I=; b=Qt5yFfRpY72t2lzXyDine0BIzud25t2WKGc1/TJb+VnTXbmG+5zzj0/6rU7FtpGJOP8yWWI+GGCxap8je0WZuYh3a9Hjrpnns7gdHpbI+yPwHwQG0E4oM9Fw5arJT2UjogdfKoBFD7oR274m+qt+6nCS6hAxg4avPwdTPaKREMQ= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=nxp.com; Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR0402MB3550.eurprd04.prod.outlook.com (2603:10a6:803:3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.20; Wed, 29 Sep 2021 15:05:05 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::e157:3280:7bc3:18c4%5]) with mapi id 15.20.4544.022; Wed, 29 Sep 2021 15:05:05 +0000 From: Vladimir Oltean To: u-boot@lists.denx.de, Joe Hershberger , Ramon Fried Cc: Priyanka Jain , Bin Meng , Michael Walle Subject: [PATCH v2 05/10] net: dsa: felix: configure the in-band autoneg property based on OF node info Date: Wed, 29 Sep 2021 18:04:40 +0300 Message-Id: <20210929150445.1593364-6-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210929150445.1593364-1-vladimir.oltean@nxp.com> References: <20210929150445.1593364-1-vladimir.oltean@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM0PR01CA0171.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::40) To VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) MIME-Version: 1.0 Received: from localhost.localdomain (188.26.53.217) by AM0PR01CA0171.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Wed, 29 Sep 2021 15:05:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04a8f173-e23f-4e85-5852-08d9835a8506 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3550: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7YHzIDW8Xf29F/Zfvh46erw916SxWjaodN/o2jnH5263PcPMzcXy2PPtLZ06Wj34lqCWo7f73rYM79hVt1KsoxmELwu/lElfF+H1q3W3KOZYkvacAV1KlUV91YeCYbS5pQdLugprNj+jtMFvq9A8nvBZnm1vUGv/VK5PEj37JhEiXOn9IqxCw6ID0NmHe7DVflVZp5uz//8xZdq+O3lD6k3ja6gt7reHivFH0asJ7h1rgzpXMvFbMsX8js1yCmrmLzpBT0bNliJkIXF1KD27CYeVxL29QQSRJs3BC7VmFYfaC0O8VmpZwEQFihoQI60w2fjPCqAqMBaIefqK57FDmJUtiXhJ31z03esoWigz3+xNSQxD4uV4j8Izo204l4jWSQaVCh6JJk+ODDSQ1cMvB01CHYz+TmHpmfIzv46BeyLAMPY5bOdyScn41TmbSqpiVHTjXjV0a18GX1MYR37jvPd5qLX16ub4Lv5Ze0XYZqzJQJsesJRnkY5StXYev+TyicPRSTSTkWIM6k/qfABKFNtxaEbB6garqKWpmdkgLV7gvICv/HqGP83ge3ef/f6m8ZXFNb2yr0N0pa/t54SvmjGoDvQI10XX6/FsJKvQa1FtKQullF3/aMz3v+ZbIXrHwwyiKYVCkqqpqSQpQFOkT+VI3AHuGxirdOD3+BXNm/p8GBIPp3qZOPJdAoQnvwf/tbroRvs02eEJ3Q1mNNDf0w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(54906003)(83380400001)(66476007)(508600001)(6512007)(2906002)(4326008)(2616005)(44832011)(86362001)(956004)(1076003)(316002)(66946007)(110136005)(36756003)(186003)(6486002)(8676002)(5660300002)(52116002)(38100700002)(6506007)(38350700002)(6666004)(26005)(66556008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ur18VuyLpKAppfjUYGeihPjkRpG6mST9qIfm9hXIaRdRE3Ld3nXzwOFd8ODW?= =?us-ascii?Q?7uQGB5fLSZXIkBR6UKPRWl2Ad5tBVR+kjBm6cVdo9P4Qq5vqiqYgt72cn7m2?= =?us-ascii?Q?Ks4mqRKbAYmb1q8noSGQHdCAHql/+NZiN39zvLkfx4zwjFwD1vwqdeUN/lsL?= =?us-ascii?Q?PwdvOJ8GJTRHOMMJFE/p/JNScG1NlAuoBzX72v/uHlTcu3LaqX7DWtPWu0AQ?= =?us-ascii?Q?uITjXhj/pgCf3Klhc7mW+EEgi6Hd6lYPQMyCbBHYwjicUvrFrpDoKSGbvgQx?= =?us-ascii?Q?HnAbLgmRbW3L0m9CMzmpc5RtbYQkyxo75kxL8zSIX2Fo4vJ/VBHz7ZMIwdZn?= =?us-ascii?Q?g+9WbXBjuUVlHobw4yY0lm+rs5lsnu4W0wp7o9LgN2VdBYBrkjdQ3MGQPcxS?= =?us-ascii?Q?uP+kxlgTVMqINpjs0yySFGMN9yTbBixgIZUPY8Q5DU4lPwNImsWbShzkKSrM?= =?us-ascii?Q?Bux6SY4TIeoaAMEiYu5nrCU3hBJ1AaBgd5cNqxnokYp1bSa+BETRLrIR03/u?= =?us-ascii?Q?0pJOqdPlXPiyvlNTutRV1i72bEM+E8d4Ni+jmkAISQh/MF4sV8xi1lSMZm9u?= =?us-ascii?Q?9vNMrUcN80/MGiEWDNpojRI2R7e0tReeLg1LIV0IUENkB7Adldv81+fEYcbP?= =?us-ascii?Q?LTifWemtEEZ/plHxfXKXsZzWCeSBy3fLxvO3w3WWegrOULGqHuoLQsjP6S5U?= =?us-ascii?Q?ruit/ZsvJZVo57YYLp4PD2aAdwXptZK8cr8hJtEFOOvAquJHUo5kZLxgrmyR?= =?us-ascii?Q?EtR4EBTXtt4z2Nx/FCDm4+LqxwrVPpoxJ3ykBJemYuA/VQwE1COUjATVrYQK?= =?us-ascii?Q?9Zy6QhQwTtJrQQLpSbCnNfjRhN6XkxqzlVqZkgdBhU0G6oxGASdhRHLP+8vH?= =?us-ascii?Q?765hfXVV1QSvXeukZsB/GNAV+b7pkoq2Snc6fXUmSdmf0jBx3kbK/QdbF58p?= =?us-ascii?Q?Ip0CI0ft18NNMNzFdVIUgRjVYpGVzU6Z/RxTDWFpQFm5xCPiNaxUHikfU/mS?= =?us-ascii?Q?FsuGQHA0QKzIEQBxJ4+00Xp12qxt9AmYCWLq3nNp2YF16qcSMNhYpnjxNtCw?= =?us-ascii?Q?j9bBwsimZzzWAp68XeuVMpyptVdDJ5Ch/GaKk5NT1cZI8Vmubse+xPjklkgg?= =?us-ascii?Q?zLz0QDXmv/cAK35WrusTMYt3/ndyj35RKcSbo7NpeBd6LPcV0JrBs04auFkK?= =?us-ascii?Q?unezUDpTOBo1Gk2I6OQgKfJCg21q434XaYDWEN8sL8vUwQIymoc6+/gwUpvp?= =?us-ascii?Q?VuhhmllZ56sRZQdVjBe6q3dH6W6XH5TbP3+bUQsNmsF2Exy1Lu9wpf5FDs8R?= =?us-ascii?Q?QcO7siAiLpWUExJVqfIzNwfn?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04a8f173-e23f-4e85-5852-08d9835a8506 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 15:05:05.3775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T/3B9vDf8envdB9pR0gCwj1BLf9q8WHUBWumhCJ8yUaMtk/bYrn+U+bbaXp7ViVClZPitxSo6HKrM9qqI7jerA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3550 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Instead of trying to guess which operating modes need in-band negotiation to be active and which ones don't, parse the available information from the device tree. That will be correct in the cases we can already guess, and more. Signed-off-by: Vladimir Oltean Reviewed-by: Ramon Fried --- v1->v2: none drivers/net/mscc_eswitch/felix_switch.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c index 551fc2c9f969..2df8dde55fb9 100644 --- a/drivers/net/mscc_eswitch/felix_switch.c +++ b/drivers/net/mscc_eswitch/felix_switch.c @@ -16,6 +16,7 @@ */ #include +#include #include #include #include @@ -210,17 +211,14 @@ static int felix_init_sxgmii(struct mii_dev *imdio, int pidx) static void felix_start_pcs(struct udevice *dev, int port, struct phy_device *phy, struct mii_dev *imdio) { - bool autoneg = true; - - if (phy->phy_id == PHY_FIXED_ID || - phy->interface == PHY_INTERFACE_MODE_2500BASEX) - autoneg = false; + ofnode node = dsa_port_get_ofnode(dev, port); + bool inband_an = ofnode_eth_uses_inband_aneg(node); switch (phy->interface) { case PHY_INTERFACE_MODE_SGMII: case PHY_INTERFACE_MODE_2500BASEX: case PHY_INTERFACE_MODE_QSGMII: - felix_init_sgmii(imdio, port, autoneg); + felix_init_sgmii(imdio, port, inband_an); break; case PHY_INTERFACE_MODE_10GBASER: case PHY_INTERFACE_MODE_USXGMII: -- 2.25.1