All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com
Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates
Date: Wed, 29 Sep 2021 16:35:12 +0100	[thread overview]
Message-ID: <20210929153511.GB22029@willie-the-truck> (raw)
In-Reply-To: <20210929144323.GQ4199@sirena.org.uk>

On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote:
> On Wed, Sep 29, 2021 at 03:31:14PM +0100, Will Deacon wrote:
> 
> > With this series applied, I see a test failing under qemu with:
> 
> > # selftests: arm64: vec-syscfg
> > # TAP version 13
> > # 1..10
> > # ok 1 SVE default vector length 64
> > # ok 2 # SKIP Need to be root to write to /proc
> > # ok 3 # SKIP Need to be root to write to /proc
> 
> AFAICT this is due to running as a non-root user, the testsuite was
> already having serious issues before then...
> 
> > # ok 4 SVE current VL is 64
> > # ok 5 SVE set VL 64 and have VL 64
> > # ok 6 # SKIP SVE only one VL supported
> > # ok 7 # SKIP SVE only one VL supported
> > # ok 8 # SKIP SVE only one VL supported
> > # ok 9 # SKIP SVE only one VL supported
> > # # SVE VL 272 returned 256 not maximum 0
> 
> ...as it's starting off by testing an interface that's only writable by
> root and then relying on that information, the existing tests were also
> not working usefully.  qemu by default supports way more than one vector
> length.  In any case it's just the test added by the last patch that's
> causing the output here, the first four patches should be fine and fix
> issues.
> 
> I'm not sure it's a particularly good idea to run kselftest as a
> non-root user TBH, it's going to cause you to skip a lot of tests.

Ah, thanks for pointing that out. It would probably be better to skip the
tests rather than fail them if they're not running with sufficient
permissions, but I'll go ahead and queue your v3 for now.

Will

WARNING: multiple messages have this Message-ID
From: Will Deacon <will@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com
Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates
Date: Wed, 29 Sep 2021 16:35:12 +0100	[thread overview]
Message-ID: <20210929153511.GB22029@willie-the-truck> (raw)
In-Reply-To: <20210929144323.GQ4199@sirena.org.uk>

On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote:
> On Wed, Sep 29, 2021 at 03:31:14PM +0100, Will Deacon wrote:
> 
> > With this series applied, I see a test failing under qemu with:
> 
> > # selftests: arm64: vec-syscfg
> > # TAP version 13
> > # 1..10
> > # ok 1 SVE default vector length 64
> > # ok 2 # SKIP Need to be root to write to /proc
> > # ok 3 # SKIP Need to be root to write to /proc
> 
> AFAICT this is due to running as a non-root user, the testsuite was
> already having serious issues before then...
> 
> > # ok 4 SVE current VL is 64
> > # ok 5 SVE set VL 64 and have VL 64
> > # ok 6 # SKIP SVE only one VL supported
> > # ok 7 # SKIP SVE only one VL supported
> > # ok 8 # SKIP SVE only one VL supported
> > # ok 9 # SKIP SVE only one VL supported
> > # # SVE VL 272 returned 256 not maximum 0
> 
> ...as it's starting off by testing an interface that's only writable by
> root and then relying on that information, the existing tests were also
> not working usefully.  qemu by default supports way more than one vector
> length.  In any case it's just the test added by the last patch that's
> causing the output here, the first four patches should be fine and fix
> issues.
> 
> I'm not sure it's a particularly good idea to run kselftest as a
> non-root user TBH, it's going to cause you to skip a lot of tests.

Ah, thanks for pointing that out. It would probably be better to skip the
tests rather than fail them if they're not running with sufficient
permissions, but I'll go ahead and queue your v3 for now.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-29 15:35 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 12:08 Mark Brown
2021-09-17 12:08 ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 1/4] selftests: arm64: Fix printf() format mismatch in vec-syscfg Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 2/4] selftests: arm64: Remove bogus error check on writing to files Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 3/4] selftests: arm64: Fix and enable test for setting current VL in vec-syscfg Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:08 ` [PATCH v2 4/4] selftests: arm64: Verify that all possible vector lengths are handled Mark Brown
2021-09-17 12:08   ` Mark Brown
2021-09-17 12:26   ` misono.tomohiro
2021-09-17 12:26     ` misono.tomohiro
2021-09-29 14:31 ` [PATCH v2 0/4] selftests: arm64: vec-syscfg updates Will Deacon
2021-09-29 14:31   ` Will Deacon
2021-09-29 14:43   ` Mark Brown
2021-09-29 14:43     ` Mark Brown
2021-09-29 15:35     ` Will Deacon [this message]
2021-09-29 15:35       ` Will Deacon
2021-09-29 15:38       ` Mark Brown
2021-09-29 15:38         ` Mark Brown
2021-09-29 16:26       ` Shuah Khan
2021-09-29 16:26         ` Shuah Khan
2021-09-29 16:37         ` Mark Brown
2021-09-29 16:37           ` Mark Brown
2021-09-29 18:23           ` Shuah Khan
2021-09-29 18:23             ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929153511.GB22029@willie-the-truck \
    --to=will@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=misono.tomohiro@fujitsu.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --subject='Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.