From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFB0BC433FE for ; Wed, 29 Sep 2021 16:38:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DB4561406 for ; Wed, 29 Sep 2021 16:38:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345911AbhI2Qjw (ORCPT ); Wed, 29 Sep 2021 12:39:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:40244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344376AbhI2Qjw (ORCPT ); Wed, 29 Sep 2021 12:39:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B5C760F6E; Wed, 29 Sep 2021 16:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632933490; bh=seeBK6jT9/yDCZFkA5WcebzZu0xlpHUHOmo08Y4Y3MQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Woa15ujxFTWO4EXjfY/kEs2ppTWT6EfuKSlaBvzC24HirWQn2Z+THQOFbBPpkDnnj 4tXPfpxmW1ITDujaMvZakDYrRuWbLOzwdbmx6omxo2MzenLeFjTW/G2K8kLumA+pRr qL3Z18Mmtw/c7niKYN63Fnxfd1Migb9q7aEK6e8lboMaYixpENKhUvNmRMGfuW/iox i6x6ZvFK/RXIEqNQI53N68ZSNPuGhWAuD78DXyrnGMUm3u3AvE2DVR+7aRQkX89u8s mAV9H9zPc4/TvUoK6xuvw+1cQbRVc8rGXKMH9pVkZZsgs9Wn46W80EovsJ8ziSAXV8 vOHL93Y0o76qQ== Date: Wed, 29 Sep 2021 17:37:21 +0100 From: Mark Brown To: Shuah Khan Cc: Will Deacon , Catalin Marinas , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates Message-ID: <20210929163721.GT4199@sirena.org.uk> References: <20210917120855.13858-1-broonie@kernel.org> <20210929143113.GA22029@willie-the-truck> <20210929144323.GQ4199@sirena.org.uk> <20210929153511.GB22029@willie-the-truck> <1b573881-ef9f-c7ae-c08b-8079f63f66ec@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aEcIyhw0mmnxygNd" Content-Disposition: inline In-Reply-To: <1b573881-ef9f-c7ae-c08b-8079f63f66ec@linuxfoundation.org> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org --aEcIyhw0mmnxygNd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 29, 2021 at 10:26:49AM -0600, Shuah Khan wrote: > On 9/29/21 9:35 AM, Will Deacon wrote: > > On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote: > > > I'm not sure it's a particularly good idea to run kselftest as a > > > non-root user TBH, it's going to cause you to skip a lot of tests. > We don't want Kselftest default run to be as root. Users can choose to > run as root which would be an explicit choice so they expect and plan > for the impact. Example panic test. OTOH if you're trying to verify that the tests aren't broken it's not that great since it'll mean that you'll not be exercising a bunch of the code. > > Ah, thanks for pointing that out. It would probably be better to skip the > > tests rather than fail them if they're not running with sufficient > > permissions, but I'll go ahead and queue your v3 for now. > Correct. I would like to see tests skipped not failed if either config > or permissions are lacking to run the tests. As I said previously that's what my v3 that Will referenced above does. --aEcIyhw0mmnxygNd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFUlkAACgkQJNaLcl1U h9BXCwf8C/QJ0Wk8Siu/Ov7a+fsmZ72GiFe+uTJyGHx5p6qudilGHoMRmOZx7bcN lteDZh2DjfwkAltlZX56Yr1nqo1R/UdxboUJoH3VhGwVuC/1RgRQw2YGb77wbsz9 kyVU1H1RR8muJ0heM7LBYPdo91EE+/cB6onssOcLhlQ5uj/apaaGje6bxGz3gTDo +XQbzsepyf0avQVGI0ULYh9gzjw746fopDzZ1PzyBM7ZytdYSMAjoYenKvCLQ/h7 eYch0qsCVUWJwhRiPKdVwsHH1Z7v6jSaGigaajwDN6NP8j3/Qn8+zepGTBJbEcrl OKh0AxT5/J0Yy1sEcawT0VkwHZUUQQ== =Qqh1 -----END PGP SIGNATURE----- --aEcIyhw0mmnxygNd-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8B7C433EF for ; Wed, 29 Sep 2021 16:39:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FA5061406 for ; Wed, 29 Sep 2021 16:39:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3FA5061406 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dB5PgateDAFPw3ZHJj1Un2dZPvn0Tzeftwo1luvVBsY=; b=YEtHTU0MG3FH9tp6Plurcg8K1E TT0mxhJFS5yl4SbaktfDoU+Sa3IBZMWo07XvBPO5OiiHNiETXWzSLWya0zJuEX2ksuzyUS0YVxoI+ DqV9x4MU9DQAkBCNvQcb3RrEBVYDkT3KZPWuEhMkuRWtQ6Solj9iJZKP5A+zikLEgtmKFMl/6wgSD 9nBA4V7Zrzek9JjgOnEvAY/3eT2w4XWtmFWOZhagWJvPtMdMTxXhtHKsLL+NJZp/M6axx30h30Vy1 EwR0k2RUuc3pL7JgM55AtZGhOqNQThFxgdk1FNbHbL4p5ug+cXC3+HtXXRRT7lBUPskkbW4mEz4j+ nyAZSUrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcb0-00BqMi-R9; Wed, 29 Sep 2021 16:38:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVcax-00BqLz-Bg for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 16:38:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 6B5C760F6E; Wed, 29 Sep 2021 16:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632933490; bh=seeBK6jT9/yDCZFkA5WcebzZu0xlpHUHOmo08Y4Y3MQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Woa15ujxFTWO4EXjfY/kEs2ppTWT6EfuKSlaBvzC24HirWQn2Z+THQOFbBPpkDnnj 4tXPfpxmW1ITDujaMvZakDYrRuWbLOzwdbmx6omxo2MzenLeFjTW/G2K8kLumA+pRr qL3Z18Mmtw/c7niKYN63Fnxfd1Migb9q7aEK6e8lboMaYixpENKhUvNmRMGfuW/iox i6x6ZvFK/RXIEqNQI53N68ZSNPuGhWAuD78DXyrnGMUm3u3AvE2DVR+7aRQkX89u8s mAV9H9zPc4/TvUoK6xuvw+1cQbRVc8rGXKMH9pVkZZsgs9Wn46W80EovsJ8ziSAXV8 vOHL93Y0o76qQ== Date: Wed, 29 Sep 2021 17:37:21 +0100 From: Mark Brown To: Shuah Khan Cc: Will Deacon , Catalin Marinas , Shuah Khan , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, misono.tomohiro@fujitsu.com Subject: Re: [PATCH v2 0/4] selftests: arm64: vec-syscfg updates Message-ID: <20210929163721.GT4199@sirena.org.uk> References: <20210917120855.13858-1-broonie@kernel.org> <20210929143113.GA22029@willie-the-truck> <20210929144323.GQ4199@sirena.org.uk> <20210929153511.GB22029@willie-the-truck> <1b573881-ef9f-c7ae-c08b-8079f63f66ec@linuxfoundation.org> MIME-Version: 1.0 In-Reply-To: <1b573881-ef9f-c7ae-c08b-8079f63f66ec@linuxfoundation.org> X-Cookie: 98% lean. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_093811_439613_B9AEA96F X-CRM114-Status: GOOD ( 19.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2908654752830055098==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2908654752830055098== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aEcIyhw0mmnxygNd" Content-Disposition: inline --aEcIyhw0mmnxygNd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 29, 2021 at 10:26:49AM -0600, Shuah Khan wrote: > On 9/29/21 9:35 AM, Will Deacon wrote: > > On Wed, Sep 29, 2021 at 03:43:23PM +0100, Mark Brown wrote: > > > I'm not sure it's a particularly good idea to run kselftest as a > > > non-root user TBH, it's going to cause you to skip a lot of tests. > We don't want Kselftest default run to be as root. Users can choose to > run as root which would be an explicit choice so they expect and plan > for the impact. Example panic test. OTOH if you're trying to verify that the tests aren't broken it's not that great since it'll mean that you'll not be exercising a bunch of the code. > > Ah, thanks for pointing that out. It would probably be better to skip the > > tests rather than fail them if they're not running with sufficient > > permissions, but I'll go ahead and queue your v3 for now. > Correct. I would like to see tests skipped not failed if either config > or permissions are lacking to run the tests. As I said previously that's what my v3 that Will referenced above does. --aEcIyhw0mmnxygNd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFUlkAACgkQJNaLcl1U h9BXCwf8C/QJ0Wk8Siu/Ov7a+fsmZ72GiFe+uTJyGHx5p6qudilGHoMRmOZx7bcN lteDZh2DjfwkAltlZX56Yr1nqo1R/UdxboUJoH3VhGwVuC/1RgRQw2YGb77wbsz9 kyVU1H1RR8muJ0heM7LBYPdo91EE+/cB6onssOcLhlQ5uj/apaaGje6bxGz3gTDo +XQbzsepyf0avQVGI0ULYh9gzjw746fopDzZ1PzyBM7ZytdYSMAjoYenKvCLQ/h7 eYch0qsCVUWJwhRiPKdVwsHH1Z7v6jSaGigaajwDN6NP8j3/Qn8+zepGTBJbEcrl OKh0AxT5/J0Yy1sEcawT0VkwHZUUQQ== =Qqh1 -----END PGP SIGNATURE----- --aEcIyhw0mmnxygNd-- --===============2908654752830055098== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2908654752830055098==--